Re: [PATCH v10] x86/KASLR: Clarify identity map interface

2016-06-15 Thread Kees Cook
On Wed, Jun 15, 2016 at 4:23 PM, Yinghai Lu wrote: > On Wed, Jun 15, 2016 at 12:03 PM, Kees Cook wrote: >> index cfeb0259ed81..03a6f5d85a6b 100644 >> --- a/arch/x86/boot/compressed/kaslr.c >> +++ b/arch/x86/boot/compressed/kaslr.c >> @@ -485,6 +485,9 @@ unsigned char *choose_random_location(unsig

Re: [PATCH v10] x86/KASLR: Clarify identity map interface

2016-06-15 Thread Yinghai Lu
On Wed, Jun 15, 2016 at 12:03 PM, Kees Cook wrote: > index cfeb0259ed81..03a6f5d85a6b 100644 > --- a/arch/x86/boot/compressed/kaslr.c > +++ b/arch/x86/boot/compressed/kaslr.c > @@ -485,6 +485,9 @@ unsigned char *choose_random_location(unsigned long input, > > boot_params->hdr.loadflags |=

[PATCH v10] x86/KASLR: Clarify identity map interface

2016-06-15 Thread Kees Cook
This extracts the call to prepare_level4() into a top-level function that the user of the pagetable.c interface must call to initialize the new page tables. For clarity and to match the "finalize" function, it has been renamed to initialize_identity_maps(). This function also gains the initializati