Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-04-07 Thread Morten Rasmussen
On Thu, Apr 02, 2015 at 06:32:38PM +0100, Peter Zijlstra wrote: > On Thu, Apr 02, 2015 at 05:53:09PM +0100, Morten Rasmussen wrote: > > Could you enlighten me a bit about how to define the arch specific > > implementation without getting into trouble? I'm failing miserably :( > > Hmm, this was

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-04-07 Thread Morten Rasmussen
On Thu, Apr 02, 2015 at 06:32:38PM +0100, Peter Zijlstra wrote: On Thu, Apr 02, 2015 at 05:53:09PM +0100, Morten Rasmussen wrote: Could you enlighten me a bit about how to define the arch specific implementation without getting into trouble? I'm failing miserably :( Hmm, this was not

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-04-02 Thread Peter Zijlstra
On Thu, Apr 02, 2015 at 05:53:09PM +0100, Morten Rasmussen wrote: > Could you enlighten me a bit about how to define the arch specific > implementation without getting into trouble? I'm failing miserably :( Hmm, this was not supposed to be difficult.. :/ > I thought the arm arch-specific

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-04-02 Thread Morten Rasmussen
On Wed, Mar 25, 2015 at 05:33:09PM +, Peter Zijlstra wrote: > On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote: > > On 23 March 2015 at 14:19, Peter Zijlstra wrote: > > > On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent Guittot wrote: > > > > > >> + unsigned long

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-04-02 Thread Peter Zijlstra
On Thu, Apr 02, 2015 at 05:53:09PM +0100, Morten Rasmussen wrote: Could you enlighten me a bit about how to define the arch specific implementation without getting into trouble? I'm failing miserably :( Hmm, this was not supposed to be difficult.. :/ I thought the arm arch-specific topology.h

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-04-02 Thread Morten Rasmussen
On Wed, Mar 25, 2015 at 05:33:09PM +, Peter Zijlstra wrote: On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote: On 23 March 2015 at 14:19, Peter Zijlstra pet...@infradead.org wrote: On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent Guittot wrote: + unsigned long

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-27 Thread Vincent Guittot
On 27 March 2015 at 09:17, Vincent Guittot wrote: > On 26 March 2015 at 18:38, Morten Rasmussen wrote: >> On Wed, Mar 25, 2015 at 06:08:42PM +, Vincent Guittot wrote: >>> On 25 March 2015 at 18:33, Peter Zijlstra wrote: >>> > On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote:

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-27 Thread Vincent Guittot
On 26 March 2015 at 18:38, Morten Rasmussen wrote: > On Wed, Mar 25, 2015 at 06:08:42PM +, Vincent Guittot wrote: >> On 25 March 2015 at 18:33, Peter Zijlstra wrote: >> > On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote: >> >> On 23 March 2015 at 14:19, Peter Zijlstra wrote:

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-27 Thread Vincent Guittot
On 26 March 2015 at 18:38, Morten Rasmussen morten.rasmus...@arm.com wrote: On Wed, Mar 25, 2015 at 06:08:42PM +, Vincent Guittot wrote: On 25 March 2015 at 18:33, Peter Zijlstra pet...@infradead.org wrote: On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote: On 23 March 2015

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-27 Thread Vincent Guittot
On 27 March 2015 at 09:17, Vincent Guittot vincent.guit...@linaro.org wrote: On 26 March 2015 at 18:38, Morten Rasmussen morten.rasmus...@arm.com wrote: On Wed, Mar 25, 2015 at 06:08:42PM +, Vincent Guittot wrote: On 25 March 2015 at 18:33, Peter Zijlstra pet...@infradead.org wrote: On

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-26 Thread Morten Rasmussen
On Thu, Mar 26, 2015 at 05:47:00PM +, Peter Zijlstra wrote: > On Thu, Mar 26, 2015 at 05:38:45PM +, Morten Rasmussen wrote: > > Another potential solution is to stay with weak functions but move the > > multiplication and shift into the arch_scale_*() functions by passing > > the value we

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-26 Thread Peter Zijlstra
On Thu, Mar 26, 2015 at 05:38:45PM +, Morten Rasmussen wrote: > Another potential solution is to stay with weak functions but move the > multiplication and shift into the arch_scale_*() functions by passing > the value we want to scale into the arch_scale_*() function. That way we > can

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-26 Thread Morten Rasmussen
On Thu, Mar 26, 2015 at 05:38:45PM +, Morten Rasmussen wrote: > The only downside is that for frequency invariance we need three > arch_scale_freq_capacity() calls instead of two. It should have been instead of one... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-26 Thread Morten Rasmussen
On Wed, Mar 25, 2015 at 06:08:42PM +, Vincent Guittot wrote: > On 25 March 2015 at 18:33, Peter Zijlstra wrote: > > On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote: > >> On 23 March 2015 at 14:19, Peter Zijlstra wrote: > >> > On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-26 Thread Morten Rasmussen
On Wed, Mar 25, 2015 at 06:08:42PM +, Vincent Guittot wrote: On 25 March 2015 at 18:33, Peter Zijlstra pet...@infradead.org wrote: On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote: On 23 March 2015 at 14:19, Peter Zijlstra pet...@infradead.org wrote: On Fri, Feb 27, 2015

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-26 Thread Peter Zijlstra
On Thu, Mar 26, 2015 at 05:38:45PM +, Morten Rasmussen wrote: Another potential solution is to stay with weak functions but move the multiplication and shift into the arch_scale_*() functions by passing the value we want to scale into the arch_scale_*() function. That way we can completely

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-26 Thread Morten Rasmussen
On Thu, Mar 26, 2015 at 05:47:00PM +, Peter Zijlstra wrote: On Thu, Mar 26, 2015 at 05:38:45PM +, Morten Rasmussen wrote: Another potential solution is to stay with weak functions but move the multiplication and shift into the arch_scale_*() functions by passing the value we want to

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-26 Thread Morten Rasmussen
On Thu, Mar 26, 2015 at 05:38:45PM +, Morten Rasmussen wrote: The only downside is that for frequency invariance we need three arch_scale_freq_capacity() calls instead of two. It should have been instead of one... -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-25 Thread Vincent Guittot
On 25 March 2015 at 18:33, Peter Zijlstra wrote: > On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote: >> On 23 March 2015 at 14:19, Peter Zijlstra wrote: >> > On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent Guittot wrote: >> > >> >> + unsigned long scale_freq =

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-25 Thread Peter Zijlstra
On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote: > On 23 March 2015 at 14:19, Peter Zijlstra wrote: > > On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent Guittot wrote: > > > >> + unsigned long scale_freq = arch_scale_freq_capacity(NULL, cpu); > > > >> +

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-25 Thread Peter Zijlstra
On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote: On 23 March 2015 at 14:19, Peter Zijlstra pet...@infradead.org wrote: On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent Guittot wrote: + unsigned long scale_freq = arch_scale_freq_capacity(NULL, cpu); +

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-25 Thread Vincent Guittot
On 25 March 2015 at 18:33, Peter Zijlstra pet...@infradead.org wrote: On Tue, Mar 24, 2015 at 11:00:57AM +0100, Vincent Guittot wrote: On 23 March 2015 at 14:19, Peter Zijlstra pet...@infradead.org wrote: On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent Guittot wrote: + unsigned long

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-24 Thread Vincent Guittot
On 23 March 2015 at 14:19, Peter Zijlstra wrote: > On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent Guittot wrote: > >> + unsigned long scale_freq = arch_scale_freq_capacity(NULL, cpu); > >> + sa->running_avg_sum += delta_w * scale_freq >> + >>

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-24 Thread Vincent Guittot
On 23 March 2015 at 14:19, Peter Zijlstra pet...@infradead.org wrote: On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent Guittot wrote: + unsigned long scale_freq = arch_scale_freq_capacity(NULL, cpu); + sa-running_avg_sum += delta_w * scale_freq +

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-23 Thread Peter Zijlstra
On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent Guittot wrote: > + unsigned long scale_freq = arch_scale_freq_capacity(NULL, cpu); > + sa->running_avg_sum += delta_w * scale_freq > + >> SCHED_CAPACITY_SHIFT; so the only thing that could be

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-23 Thread Peter Zijlstra
On Fri, Feb 27, 2015 at 04:54:07PM +0100, Vincent Guittot wrote: + unsigned long scale_freq = arch_scale_freq_capacity(NULL, cpu); + sa-running_avg_sum += delta_w * scale_freq + SCHED_CAPACITY_SHIFT; so the only thing that could be

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-03 Thread Vincent Guittot
On 3 March 2015 at 13:51, Dietmar Eggemann wrote: > On 27/02/15 15:54, Vincent Guittot wrote: >> From: Morten Rasmussen >> >> Apply frequency scale-invariance correction factor to usage tracking. >> Each segment of the running_load_avg geometric series is now scaled by the > > The same comment I

[PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-03 Thread Vincent Guittot
From: Morten Rasmussen Apply frequency scale-invariance correction factor to usage tracking. Each segment of the running_avg_sum geometric series is now scaled by the current frequency so the utilization_avg_contrib of each entity will be invariant with frequency scaling. As a result,

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-03 Thread Dietmar Eggemann
On 27/02/15 15:54, Vincent Guittot wrote: > From: Morten Rasmussen > > Apply frequency scale-invariance correction factor to usage tracking. > Each segment of the running_load_avg geometric series is now scaled by the The same comment I sent out on [PATCH v10 07/11]: The use of underscores in

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-03 Thread Dietmar Eggemann
On 27/02/15 15:54, Vincent Guittot wrote: From: Morten Rasmussen morten.rasmus...@arm.com Apply frequency scale-invariance correction factor to usage tracking. Each segment of the running_load_avg geometric series is now scaled by the The same comment I sent out on [PATCH v10 07/11]: The

[PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-03 Thread Vincent Guittot
From: Morten Rasmussen morten.rasmus...@arm.com Apply frequency scale-invariance correction factor to usage tracking. Each segment of the running_avg_sum geometric series is now scaled by the current frequency so the utilization_avg_contrib of each entity will be invariant with frequency scaling.

Re: [PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-03-03 Thread Vincent Guittot
On 3 March 2015 at 13:51, Dietmar Eggemann dietmar.eggem...@arm.com wrote: On 27/02/15 15:54, Vincent Guittot wrote: From: Morten Rasmussen morten.rasmus...@arm.com Apply frequency scale-invariance correction factor to usage tracking. Each segment of the running_load_avg geometric series is

[PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-02-27 Thread Vincent Guittot
From: Morten Rasmussen Apply frequency scale-invariance correction factor to usage tracking. Each segment of the running_load_avg geometric series is now scaled by the current frequency so the utilization_avg_contrib of each entity will be invariant with frequency scaling. As a result,

[PATCH v10 04/11] sched: Make sched entity usage tracking scale-invariant

2015-02-27 Thread Vincent Guittot
From: Morten Rasmussen morten.rasmus...@arm.com Apply frequency scale-invariance correction factor to usage tracking. Each segment of the running_load_avg geometric series is now scaled by the current frequency so the utilization_avg_contrib of each entity will be invariant with frequency