Re: [PATCH v10 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2019-01-15 Thread Jae Hyun Yoo
On 1/15/2019 3:14 PM, Joel Stanley wrote: On Tue, 15 Jan 2019 at 09:49, Jae Hyun Yoo wrote: + /** +* We check that the regmap works on this very first access, +* but as this is an MMIO-backed regmap, subsequent regmap +* access is not going to fail and we skip erro

Re: [PATCH v10 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2019-01-15 Thread Joel Stanley
On Tue, 15 Jan 2019 at 09:49, Jae Hyun Yoo wrote: > >> + /** > >> +* We check that the regmap works on this very first access, > >> +* but as this is an MMIO-backed regmap, subsequent regmap > >> +* access is not going to fail and we skip error checks from > >> +

Re: [PATCH v10 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2019-01-14 Thread Jae Hyun Yoo
On 1/14/2019 3:37 AM, Joel Stanley wrote: On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: + ret = of_property_read_u32(priv->dev->of_node, "cmd-timeout-ms", + &priv->cmd_timeout_ms); + if (ret || priv->cmd_timeout_ms > PECI_CMD_TIMEOUT_MS_MAX || +

Re: [PATCH v10 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2019-01-14 Thread Joel Stanley
On Tue, 8 Jan 2019 at 08:11, Jae Hyun Yoo wrote: > + ret = of_property_read_u32(priv->dev->of_node, "cmd-timeout-ms", > + &priv->cmd_timeout_ms); > + if (ret || priv->cmd_timeout_ms > PECI_CMD_TIMEOUT_MS_MAX || > + priv->cmd_timeout_ms == 0) {

[PATCH v10 06/12] peci: Add a PECI adapter driver for Aspeed AST24xx/AST25xx

2019-01-07 Thread Jae Hyun Yoo
This commit adds PECI adapter driver implementation for Aspeed AST24xx/AST25xx SoCs. Cc: Joel Stanley Cc: Andrew Jeffery Cc: Andy Shevchenko Cc: Greg Kroah-Hartman Cc: Robin Murphy Cc: Ryan Chen Signed-off-by: Jae Hyun Yoo Reviewed-by: Haiyue Wang Reviewed-by: James Feist Reviewed-by: Ver