Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-26 Thread Preeti U Murthy
On 03/26/2015 04:25 PM, Peter Zijlstra wrote: > On Fri, Feb 27, 2015 at 04:54:13PM +0100, Vincent Guittot wrote: >> Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that >> the scheduler will put at least 1 task per core. >> >> Signed-off-by: Vincent Guittot >> Reviewed-by: Preeti

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-26 Thread Peter Zijlstra
On Fri, Feb 27, 2015 at 04:54:13PM +0100, Vincent Guittot wrote: > Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that > the scheduler will put at least 1 task per core. > > Signed-off-by: Vincent Guittot > Reviewed-by: Preeti U. Murthy Preeti, what benchmarks did you use on

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-26 Thread Peter Zijlstra
On Fri, Feb 27, 2015 at 04:54:13PM +0100, Vincent Guittot wrote: Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that the scheduler will put at least 1 task per core. Signed-off-by: Vincent Guittot vincent.guit...@linaro.org Reviewed-by: Preeti U. Murthy

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-26 Thread Preeti U Murthy
On 03/26/2015 04:25 PM, Peter Zijlstra wrote: On Fri, Feb 27, 2015 at 04:54:13PM +0100, Vincent Guittot wrote: Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that the scheduler will put at least 1 task per core. Signed-off-by: Vincent Guittot vincent.guit...@linaro.org

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-23 Thread Preeti U Murthy
On 03/23/2015 02:41 PM, Peter Zijlstra wrote: > On Tue, Mar 03, 2015 at 09:38:11AM +0100, Vincent Guittot wrote: > >>> Prefer siblings logic dates back to https://lkml.org/lkml/2009/8/27/210 >>> and only used in update_sd_lb_stats() where we have >>> >>> if (child && child->flags &

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-23 Thread Peter Zijlstra
On Tue, Mar 03, 2015 at 09:38:11AM +0100, Vincent Guittot wrote: > > Prefer siblings logic dates back to https://lkml.org/lkml/2009/8/27/210 > > and only used in update_sd_lb_stats() where we have > > > > if (child && child->flags & SD_PREFER_SIBLING) > > prefer_sibling = 1; > > > >

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-23 Thread Peter Zijlstra
On Tue, Mar 03, 2015 at 09:38:11AM +0100, Vincent Guittot wrote: Prefer siblings logic dates back to https://lkml.org/lkml/2009/8/27/210 and only used in update_sd_lb_stats() where we have if (child child-flags SD_PREFER_SIBLING) prefer_sibling = 1; However what confuses

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-23 Thread Preeti U Murthy
On 03/23/2015 02:41 PM, Peter Zijlstra wrote: On Tue, Mar 03, 2015 at 09:38:11AM +0100, Vincent Guittot wrote: Prefer siblings logic dates back to https://lkml.org/lkml/2009/8/27/210 and only used in update_sd_lb_stats() where we have if (child child-flags SD_PREFER_SIBLING)

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-03 Thread Vincent Guittot
On 2 March 2015 at 12:52, Srikar Dronamraju wrote: > * Vincent Guittot [2015-02-27 16:54:13]: > >> Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that >> the scheduler will put at least 1 task per core. >> >> Signed-off-by: Vincent Guittot >> Reviewed-by: Preeti U. Murthy >>

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-03 Thread Vincent Guittot
On 2 March 2015 at 12:52, Srikar Dronamraju sri...@linux.vnet.ibm.com wrote: * Vincent Guittot vincent.guit...@linaro.org [2015-02-27 16:54:13]: Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that the scheduler will put at least 1 task per core. Signed-off-by: Vincent

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-02 Thread Srikar Dronamraju
* Vincent Guittot [2015-02-27 16:54:13]: > Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that > the scheduler will put at least 1 task per core. > > Signed-off-by: Vincent Guittot > Reviewed-by: Preeti U. Murthy > --- > kernel/sched/core.c | 1 + > 1 file changed, 1

Re: [PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-03-02 Thread Srikar Dronamraju
* Vincent Guittot vincent.guit...@linaro.org [2015-02-27 16:54:13]: Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that the scheduler will put at least 1 task per core. Signed-off-by: Vincent Guittot vincent.guit...@linaro.org Reviewed-by: Preeti U. Murthy

[PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-02-27 Thread Vincent Guittot
Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that the scheduler will put at least 1 task per core. Signed-off-by: Vincent Guittot Reviewed-by: Preeti U. Murthy --- kernel/sched/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/sched/core.c

[PATCH v10 10/11] sched: add SD_PREFER_SIBLING for SMT level

2015-02-27 Thread Vincent Guittot
Add the SD_PREFER_SIBLING flag for SMT level in order to ensure that the scheduler will put at least 1 task per core. Signed-off-by: Vincent Guittot vincent.guit...@linaro.org Reviewed-by: Preeti U. Murthy pre...@linux.vnet.ibm.com --- kernel/sched/core.c | 1 + 1 file changed, 1 insertion(+)