Re: [PATCH v10 12/12] tracing: define trace_dump_stack() if !CONFIG_STACKTRACE

2013-10-11 Thread Steven Rostedt
On Fri, 2013-10-11 at 08:32 -0500, Tom Zanussi wrote: > Yeah, it's not easy to turn off CONFIG_STACKTRACE - I basically had to > tweak a couple Kconfigs to do it, so I could test my stacktrace trigger > CONFIG_STACKTRACE ifdefs. If there's no way to do make it fail currently, then it's not really

Re: [PATCH v10 12/12] tracing: define trace_dump_stack() if !CONFIG_STACKTRACE

2013-10-11 Thread Tom Zanussi
On Fri, 2013-10-11 at 22:00 +0900, Masami Hiramatsu wrote: > (2013/10/11 9:48), Tom Zanussi wrote: > > If CONFIG_STACKTRACE is turned off, trace_dump_stack() isn't defined, > > resulting in an 'undefined reference' error - define a stub to remedy > > that. > > > > Signed-off-by: Tom Zanussi > >

Re: [PATCH v10 12/12] tracing: define trace_dump_stack() if !CONFIG_STACKTRACE

2013-10-11 Thread Masami Hiramatsu
(2013/10/11 9:48), Tom Zanussi wrote: > If CONFIG_STACKTRACE is turned off, trace_dump_stack() isn't defined, > resulting in an 'undefined reference' error - define a stub to remedy > that. > > Signed-off-by: Tom Zanussi Hmm, what kernel config caused that error? It seems that the CONFIG_STACKTR

[PATCH v10 12/12] tracing: define trace_dump_stack() if !CONFIG_STACKTRACE

2013-10-10 Thread Tom Zanussi
If CONFIG_STACKTRACE is turned off, trace_dump_stack() isn't defined, resulting in an 'undefined reference' error - define a stub to remedy that. Signed-off-by: Tom Zanussi --- kernel/trace/trace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c