Re: [PATCH v10 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time

2019-02-12 Thread Thomas Gleixner
On Tue, 12 Feb 2019, Li, Aubrey wrote: > On 2019/2/12 21:24, Thomas Gleixner wrote: > > And please take your time and do not shoot out half baken patch series > > every 5 minutes. > > > Sorry for the trouble, just want to solve the problem before your eyes move > away from this thread. You

Re: [PATCH v10 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time

2019-02-12 Thread Li, Aubrey
On 2019/2/12 21:24, Thomas Gleixner wrote: > On Tue, 12 Feb 2019, Li, Aubrey wrote: > >> On 2019/2/12 21:03, Thomas Gleixner wrote: >> I didn't include the first patch, because I saw it's already in tip >> tree. Did you use tip tree? > > Yes, that's my bad, forgot to switch branches. That still

Re: [PATCH v10 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time

2019-02-12 Thread Thomas Gleixner
On Tue, 12 Feb 2019, Thomas Gleixner wrote: > On Tue, 12 Feb 2019, Li, Aubrey wrote: > > > On 2019/2/12 21:03, Thomas Gleixner wrote: > > I didn't include the first patch, because I saw it's already in tip > > tree. Did you use tip tree? > > Yes, that's my bad, forgot to switch branches. That

Re: [PATCH v10 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time

2019-02-12 Thread Thomas Gleixner
On Tue, 12 Feb 2019, Li, Aubrey wrote: > On 2019/2/12 21:03, Thomas Gleixner wrote: > I didn't include the first patch, because I saw it's already in tip > tree. Did you use tip tree? Yes, that's my bad, forgot to switch branches. That still does not solve: > > arch/x86/kernel/fpu/xstate.c: At

Re: [PATCH v10 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time

2019-02-12 Thread Li, Aubrey
On 2019/2/12 21:03, Thomas Gleixner wrote: > On Tue, 12 Feb 2019, Aubrey Li wrote: > > arch/x86/kernel/fpu/xstate.c:1252:6: warning: no previous prototype for > ‘avx512_status’ [-Wmissing-prototypes] > void avx512_status(struct seq_file *m, struct task_struct *task) > ^ Sorry

Re: [PATCH v10 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time

2019-02-12 Thread Thomas Gleixner
On Tue, 12 Feb 2019, Aubrey Li wrote: arch/x86/kernel/fpu/xstate.c:1252:6: warning: no previous prototype for ‘avx512_status’ [-Wmissing-prototypes] void avx512_status(struct seq_file *m, struct task_struct *task) ^ arch/x86/kernel/fpu/xstate.c: In function ‘avx512_status’:

[PATCH v10 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time

2019-02-12 Thread Aubrey Li
AVX-512 components use could cause core turbo frequency drop. So it's useful to expose AVX-512 usage elapsed time as a heuristic hint for the user space job scheduler to cluster the AVX-512 using tasks together. Example: $ cat /proc/pid/status | grep AVX512_elapsed_ms AVX512_elapsed_ms: 1020