Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-07 Thread Joe Perches
On Tue, 2016-06-07 at 12:50 +0200, Jens Wiklander wrote: > On Mon, Jun 06, 2016 at 04:44:42PM -0500, Nishanth Menon wrote: > > > > On 06/01/2016 07:41 AM, Jens Wiklander wrote: > > few minor comments below. > > > > I see the patch generated (with --strict): > > > > > > CHECK: Alignment should

Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-07 Thread Joe Perches
On Tue, 2016-06-07 at 12:50 +0200, Jens Wiklander wrote: > On Mon, Jun 06, 2016 at 04:44:42PM -0500, Nishanth Menon wrote: > > > > On 06/01/2016 07:41 AM, Jens Wiklander wrote: > > few minor comments below. > > > > I see the patch generated (with --strict): > > > > > > CHECK: Alignment should

Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-07 Thread Jens Wiklander
On Mon, Jun 06, 2016 at 04:44:42PM -0500, Nishanth Menon wrote: > On 06/01/2016 07:41 AM, Jens Wiklander wrote: > few minor comments below. > > I see the patch generated (with --strict): > > CHECK: Alignment should match open parenthesis > > #512: FILE: drivers/tee/tee.c:375: > > +static int

Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-07 Thread Jens Wiklander
On Mon, Jun 06, 2016 at 04:44:42PM -0500, Nishanth Menon wrote: > On 06/01/2016 07:41 AM, Jens Wiklander wrote: > few minor comments below. > > I see the patch generated (with --strict): > > CHECK: Alignment should match open parenthesis > > #512: FILE: drivers/tee/tee.c:375: > > +static int

Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-06 Thread Nishanth Menon
On 06/01/2016 07:41 AM, Jens Wiklander wrote: few minor comments below. I see the patch generated (with --strict): > CHECK: Alignment should match open parenthesis > #512: FILE: drivers/tee/tee.c:375: > +static int tee_ioctl_close_session(struct tee_context *ctx, > + struct

Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-06 Thread Nishanth Menon
On 06/01/2016 07:41 AM, Jens Wiklander wrote: few minor comments below. I see the patch generated (with --strict): > CHECK: Alignment should match open parenthesis > #512: FILE: drivers/tee/tee.c:375: > +static int tee_ioctl_close_session(struct tee_context *ctx, > + struct

Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-06 Thread Javier González
> > On 01 Jun 2016, at 14:41, Jens Wiklander wrote: > > Initial patch for generic TEE subsystem. > This subsystem provides: > * Registration/un-registration of TEE drivers. > * Shared memory between normal world and secure world. > * Ioctl interface for interaction

Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-06 Thread Javier González
> > On 01 Jun 2016, at 14:41, Jens Wiklander wrote: > > Initial patch for generic TEE subsystem. > This subsystem provides: > * Registration/un-registration of TEE drivers. > * Shared memory between normal world and secure world. > * Ioctl interface for interaction

Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-06 Thread Javier González
> > On 01 Jun 2016, at 14:41, Jens Wiklander wrote: > > Initial patch for generic TEE subsystem. > This subsystem provides: > * Registration/un-registration of TEE drivers. > * Shared memory between normal world and secure world. > * Ioctl interface for interaction with user space. > * Sysfs

Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-06 Thread Javier González
> > On 01 Jun 2016, at 14:41, Jens Wiklander wrote: > > Initial patch for generic TEE subsystem. > This subsystem provides: > * Registration/un-registration of TEE drivers. > * Shared memory between normal world and secure world. > * Ioctl interface for interaction with user space. > * Sysfs

Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-06 Thread Javier González
> > On 01 Jun 2016, at 14:41, Jens Wiklander wrote: > > Initial patch for generic TEE subsystem. > This subsystem provides: > * Registration/un-registration of TEE drivers. > * Shared memory between normal world and secure world. > * Ioctl interface for interaction

Re: [PATCH v10 2/4] tee: generic TEE subsystem

2016-06-06 Thread Javier González
> > On 01 Jun 2016, at 14:41, Jens Wiklander wrote: > > Initial patch for generic TEE subsystem. > This subsystem provides: > * Registration/un-registration of TEE drivers. > * Shared memory between normal world and secure world. > * Ioctl interface for interaction with user space. > * Sysfs

[PATCH v10 2/4] tee: generic TEE subsystem

2016-06-01 Thread Jens Wiklander
Initial patch for generic TEE subsystem. This subsystem provides: * Registration/un-registration of TEE drivers. * Shared memory between normal world and secure world. * Ioctl interface for interaction with user space. * Sysfs implementation_id of TEE driver A TEE (Trusted Execution Environment)

[PATCH v10 2/4] tee: generic TEE subsystem

2016-06-01 Thread Jens Wiklander
Initial patch for generic TEE subsystem. This subsystem provides: * Registration/un-registration of TEE drivers. * Shared memory between normal world and secure world. * Ioctl interface for interaction with user space. * Sysfs implementation_id of TEE driver A TEE (Trusted Execution Environment)