Re: [PATCH v10 20/21] ext4: Add DAX functionality

2014-09-15 Thread Boaz Harrosh
On 09/15/2014 09:15 AM, Dave Chinner wrote: > On Sun, Sep 14, 2014 at 03:25:45PM +0300, Boaz Harrosh wrote: <> > > Well, that's one way of working around the immediate issue, but I > don't think it solves the whole problem. e.g. what do you do with the > bit of the partial write that failed? We ma

Re: [PATCH v10 20/21] ext4: Add DAX functionality

2014-09-14 Thread Dave Chinner
On Sun, Sep 14, 2014 at 03:25:45PM +0300, Boaz Harrosh wrote: > On 09/11/2014 07:38 AM, Dave Chinner wrote: > <> > > > > And so ext4 is buggy, because what ext4 does > > > > ... is not a retry - it falls back to a fundamentally different > > code path. i.e: > > > > sys_write() > > > >

Re: [PATCH v10 20/21] ext4: Add DAX functionality

2014-09-14 Thread Boaz Harrosh
On 09/11/2014 07:38 AM, Dave Chinner wrote: <> > > And so ext4 is buggy, because what ext4 does > > ... is not a retry - it falls back to a fundamentally different > code path. i.e: > > sys_write() > > new_sync_write > ext4_file_write_iter > __generic_file_write

Re: [PATCH v10 20/21] ext4: Add DAX functionality

2014-09-10 Thread Dave Chinner
On Wed, Sep 10, 2014 at 07:49:40PM +0300, Boaz Harrosh wrote: > On 09/03/2014 02:13 PM, Dave Chinner wrote: > <> > > > > When direct IO fails ext4 falls back to buffered IO, right? And > > dax_do_io() can return partial writes, yes? > > > > There is no buffered writes with DAX. .I.E buffered wri

Re: [PATCH v10 20/21] ext4: Add DAX functionality

2014-09-10 Thread Boaz Harrosh
On 09/03/2014 02:13 PM, Dave Chinner wrote: <> > > When direct IO fails ext4 falls back to buffered IO, right? And > dax_do_io() can return partial writes, yes? > There is no buffered writes with DAX. .I.E buffered writes are always direct as well. (No page cache) > So that means if you get, sa

Re: [PATCH v10 20/21] ext4: Add DAX functionality

2014-09-03 Thread Dave Chinner
On Tue, Aug 26, 2014 at 11:45:40PM -0400, Matthew Wilcox wrote: > From: Ross Zwisler > > This is a port of the DAX functionality found in the current version of > ext2. > diff --git a/fs/ext4/indirect.c b/fs/ext4/indirect.c > index e75f840..fa9ec8d 100644 > --- a/fs/ext4/indirect.c > +++ b/f

[PATCH v10 20/21] ext4: Add DAX functionality

2014-08-26 Thread Matthew Wilcox
From: Ross Zwisler This is a port of the DAX functionality found in the current version of ext2. Signed-off-by: Ross Zwisler Reviewed-by: Andreas Dilger [heavily tweaked] Signed-off-by: Matthew Wilcox --- Documentation/filesystems/dax.txt | 1 + Documentation/filesystems/ext4.txt | 2 ++