Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-25 Thread Rafael Aquini
On Tue, Sep 25, 2012 at 02:40:24AM +0200, Michael S. Tsirkin wrote: > > @@ -139,9 +158,15 @@ static void fill_balloon(struct virtio_balloon *vb, > > size_t num) > > break; > > } > > set_page_pfns(vb->pfns + vb->num_pfns, page); > > -

Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-25 Thread Rafael Aquini
On Tue, Sep 25, 2012 at 02:40:24AM +0200, Michael S. Tsirkin wrote: @@ -139,9 +158,15 @@ static void fill_balloon(struct virtio_balloon *vb, size_t num) break; } set_page_pfns(vb-pfns + vb-num_pfns, page); - vb-num_pages +=

Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-24 Thread Michael S. Tsirkin
On Mon, Sep 17, 2012 at 01:38:18PM -0300, Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of >

Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-24 Thread Michael S. Tsirkin
On Mon, Sep 17, 2012 at 01:38:18PM -0300, Rafael Aquini wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of

Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-18 Thread Rafael Aquini
On Mon, Sep 17, 2012 at 03:15:52PM -0700, Andrew Morton wrote: > > + /* Number of balloon pages isolated from 'pages' list for compaction */ > > + unsigned int num_isolated_pages; > > Is it utterly inconceivable that this counter could exceed 4G, ever? > > > /* Number of balloon pages

Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-18 Thread Rafael Aquini
On Mon, Sep 17, 2012 at 03:15:52PM -0700, Andrew Morton wrote: + /* Number of balloon pages isolated from 'pages' list for compaction */ + unsigned int num_isolated_pages; Is it utterly inconceivable that this counter could exceed 4G, ever? /* Number of balloon pages we've told

Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:18 -0300 Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of >

[PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-17 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. Besides

[PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-17 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. Besides

Re: [PATCH v10 3/5] virtio_balloon: introduce migration primitives to balloon pages

2012-09-17 Thread Andrew Morton
On Mon, 17 Sep 2012 13:38:18 -0300 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number