Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-06 Thread Michal Simek
On 25. 10. 18 8:07, Manish Narani wrote: > Add ddrc memory controller node in dts. The size mentioned in dts is > 0x3, because we need to access DDR_QOS INTR registers located at > 0xFD090208 from this driver. > > Signed-off-by: Manish Narani > --- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi |

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-06 Thread Borislav Petkov
On Tue, Nov 06, 2018 at 07:46:55AM +0100, Michal Simek wrote: > I think Boris should take also this one (dt binding doc change) because > it is aligned with changes in the driver. > https://lkml.kernel.org/r/1538667328-9465-7-git-send-email-manish.nar...@xilinx.com Ok, done. -- Regards/Gruss,

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Michal Simek
On 05. 11. 18 21:43, Borislav Petkov wrote: > On Mon, Nov 05, 2018 at 12:38:05PM -0800, Olof Johansson wrote: >> Yeah, that's the way we've been trying to do for various subsystems >> and it's been working pretty well. Of course, if there's need to >> coordinate more closely for something in the fu

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Borislav Petkov
On Mon, Nov 05, 2018 at 12:38:05PM -0800, Olof Johansson wrote: > Yeah, that's the way we've been trying to do for various subsystems > and it's been working pretty well. Of course, if there's need to > coordinate more closely for something in the future we'll be happy to > do so. Goodie. Let's do

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Olof Johansson
On Mon, Nov 5, 2018 at 11:47 AM Borislav Petkov wrote: > > Hi Olof, > > On Mon, Nov 05, 2018 at 06:51:26AM -0800, Olof Johansson wrote: > > In general, for new functionality where needing both the driver change > > and a DT change to enable it (or a driver change and a config change > > to enable

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Borislav Petkov
Hi Olof, On Mon, Nov 05, 2018 at 06:51:26AM -0800, Olof Johansson wrote: > In general, for new functionality where needing both the driver change > and a DT change to enable it (or a driver change and a config change > to enable it), we have been merging the changes separately between > driver tre

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Olof Johansson
On Mon, Nov 5, 2018 at 5:42 AM Borislav Petkov wrote: > > On Mon, Nov 05, 2018 at 02:32:55PM +0100, Michal Simek wrote: > > you don't have that HW anyway. > > Grrr, I'm not talking about me - I'm talking about people testing > linux-next. And perhaps in this particular case it won't matter because

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Michal Simek
On 05. 11. 18 14:42, Borislav Petkov wrote: > On Mon, Nov 05, 2018 at 02:32:55PM +0100, Michal Simek wrote: >> you don't have that HW anyway. > > Grrr, I'm not talking about me - I'm talking about people testing > linux-next. And perhaps in this particular case it won't matter because > this hw is

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Borislav Petkov
On Mon, Nov 05, 2018 at 02:32:55PM +0100, Michal Simek wrote: > you don't have that HW anyway. Grrr, I'm not talking about me - I'm talking about people testing linux-next. And perhaps in this particular case it won't matter because this hw is not shipping yet or whatever but the question is about

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Michal Simek
On 05. 11. 18 14:20, Borislav Petkov wrote: > On Mon, Nov 05, 2018 at 02:06:11PM +0100, Michal Simek wrote: >> I don't think that driver will be broken. You can build them, use them >> on out of tree HW. And when this patch is merged to mainline it will be >> enabled for xilinx soc. > > But if the

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Borislav Petkov
On Mon, Nov 05, 2018 at 02:06:11PM +0100, Michal Simek wrote: > I don't think that driver will be broken. You can build them, use them > on out of tree HW. And when this patch is merged to mainline it will be > enabled for xilinx soc. But if the DT entries are missing, the driver won't load, would

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Michal Simek
Hi Boris, On 05. 11. 18 13:56, Borislav Petkov wrote: > On Thu, Oct 25, 2018 at 11:37:00AM +0530, Manish Narani wrote: >> Add ddrc memory controller node in dts. The size mentioned in dts is >> 0x3, because we need to access DDR_QOS INTR registers located at >> 0xFD090208 from this driver. >>

Re: [PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-11-05 Thread Borislav Petkov
On Thu, Oct 25, 2018 at 11:37:00AM +0530, Manish Narani wrote: > Add ddrc memory controller node in dts. The size mentioned in dts is > 0x3, because we need to access DDR_QOS INTR registers located at > 0xFD090208 from this driver. > > Signed-off-by: Manish Narani > --- > arch/arm64/boot/dts

[PATCH v10 5/6] arm64: zynqmp: Add DDRC node

2018-10-24 Thread Manish Narani
Add ddrc memory controller node in dts. The size mentioned in dts is 0x3, because we need to access DDR_QOS INTR registers located at 0xFD090208 from this driver. Signed-off-by: Manish Narani --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git