Re: [PATCH v11] NVMe: Convert to blk-mq

2014-08-15 Thread Matias Bjorling
On 08/15/2014 01:09 AM, Keith Busch wrote: The allocation and freeing of blk-mq parts seems a bit asymmetrical to me. The 'tags' belong to the tagset, but any request_queue using that tagset may free the tags. I looked to separate the tag allocation concerns, but that's more time than I have, so

Re: [PATCH v11] NVMe: Convert to blk-mq

2014-08-14 Thread Keith Busch
On Thu, 14 Aug 2014, Jens Axboe wrote: nr_tags must be uninitialized or screwed up somehow, otherwise I don't see how that kmalloc() could warn on being too large. Keith, are you running with slab debugging? Matias, might be worth trying. The allocation and freeing of blk-mq parts seems a bit a

Re: [PATCH v11] NVMe: Convert to blk-mq

2014-08-14 Thread Keith Busch
On Thu, 14 Aug 2014, Matias Bjorling wrote: nr_tags must be uninitialized or screwed up somehow, otherwise I don't see how that kmalloc() could warn on being too large. Keith, are you running with slab debugging? Matias, might be worth trying. The queue's tags were freed in 'blk_mq_map_swqueue'

Re: [PATCH v11] NVMe: Convert to blk-mq

2014-08-14 Thread Matias Bjorling
I haven't event tried debugging this next one: doing an insmod+rmmod caused this warning followed by a panic: I'll look into it. Thanks nr_tags must be uninitialized or screwed up somehow, otherwise I don't see how that kmalloc() could warn on being too large. Keith, are you running with sl

Re: [PATCH v11] NVMe: Convert to blk-mq

2014-08-14 Thread Keith Busch
On Thu, 14 Aug 2014, Jens Axboe wrote: On 08/14/2014 02:25 AM, Matias Bjørling wrote: The result is set to BLK_MQ_RQ_QUEUE_ERROR, or am I mistaken? Looks OK to me, looking at the code, 'result' is initialized to BLK_MQ_RQ_QUEUE_BUSY though. Which looks correct, we don't want to error on a susp

Re: [PATCH v11] NVMe: Convert to blk-mq

2014-08-14 Thread Jens Axboe
On 08/14/2014 02:25 AM, Matias Bjørling wrote: > On 08/14/2014 12:27 AM, Keith Busch wrote: >> On Sun, 10 Aug 2014, Matias Bjørling wrote: >>> On Sat, Jul 26, 2014 at 11:07 AM, Matias Bjørling wrote: This converts the NVMe driver to a blk-mq request-based driver. >>> >>> Willy, do you ne

Re: [PATCH v11] NVMe: Convert to blk-mq

2014-08-14 Thread Matias Bjørling
On 08/14/2014 12:27 AM, Keith Busch wrote: On Sun, 10 Aug 2014, Matias Bjørling wrote: On Sat, Jul 26, 2014 at 11:07 AM, Matias Bjørling wrote: This converts the NVMe driver to a blk-mq request-based driver. Willy, do you need me to make any changes to the conversion? Can you pick it up for

Re: [PATCH v11] NVMe: Convert to blk-mq

2014-08-13 Thread Keith Busch
On Sun, 10 Aug 2014, Matias Bjørling wrote: On Sat, Jul 26, 2014 at 11:07 AM, Matias Bjørling wrote: This converts the NVMe driver to a blk-mq request-based driver. Willy, do you need me to make any changes to the conversion? Can you pick it up for 3.17? Hi Matias, I'm starting to get a l

Re: [PATCH v11] NVMe: Convert to blk-mq

2014-08-10 Thread Matias Bjørling
On Sat, Jul 26, 2014 at 11:07 AM, Matias Bjørling wrote: > This converts the NVMe driver to a blk-mq request-based driver. > Willy, do you need me to make any changes to the conversion? Can you pick it up for 3.17? Thanks, Matias -- To unsubscribe from this list: send the line "unsubscribe linux

[PATCH v11] NVMe: Convert to blk-mq

2014-07-26 Thread Matias Bjørling
This converts the NVMe driver to a blk-mq request-based driver. The NVMe driver is currently bio-based and implements queue logic within itself. By using blk-mq, a lot of these responsibilities can be moved and simplified. The patch is divided into the following blocks: * Per-command data and c