Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8)

2017-06-01 Thread Chris Wilson
On Thu, Jun 01, 2017 at 02:26:01PM +0200, Hans de Goede wrote: > Hi, > > On 01-06-17 14:22, Chris Wilson wrote: > >On Thu, Jun 01, 2017 at 02:13:28PM +0200, Hans de Goede wrote: > >>Hi, > >> > >>On 31-05-17 04:39, jeffy wrote: > >>>Hi Hans, > >>> > >>>thanx for investigating :) > >>> > >>>On 05/30

Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8)

2017-06-01 Thread Hans de Goede
Hi, On 01-06-17 14:22, Chris Wilson wrote: On Thu, Jun 01, 2017 at 02:13:28PM +0200, Hans de Goede wrote: Hi, On 31-05-17 04:39, jeffy wrote: Hi Hans, thanx for investigating :) On 05/30/2017 03:06 PM, Hans de Goede wrote: Hi, On 29-05-17 22:25, Chris Wilson wrote: On Fri, Apr 14, 2017 a

Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8)

2017-06-01 Thread Chris Wilson
On Thu, Jun 01, 2017 at 02:13:28PM +0200, Hans de Goede wrote: > Hi, > > On 31-05-17 04:39, jeffy wrote: > >Hi Hans, > > > >thanx for investigating :) > > > >On 05/30/2017 03:06 PM, Hans de Goede wrote: > >>Hi, > >> > >>On 29-05-17 22:25, Chris Wilson wrote: > >>>On Fri, Apr 14, 2017 at 11:15:04AM

Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8)

2017-06-01 Thread Hans de Goede
Hi, On 31-05-17 04:39, jeffy wrote: Hi Hans, thanx for investigating :) On 05/30/2017 03:06 PM, Hans de Goede wrote: Hi, On 29-05-17 22:25, Chris Wilson wrote: On Fri, Apr 14, 2017 at 11:15:04AM -0400, Sean Paul wrote: On Thu, Apr 13, 2017 at 03:32:44PM +0800, Jeffy Chen wrote: After unbi

Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8)

2017-05-30 Thread jeffy
Hi Hans, thanx for investigating :) On 05/30/2017 03:06 PM, Hans de Goede wrote: Hi, On 29-05-17 22:25, Chris Wilson wrote: On Fri, Apr 14, 2017 at 11:15:04AM -0400, Sean Paul wrote: On Thu, Apr 13, 2017 at 03:32:44PM +0800, Jeffy Chen wrote: After unbinding drm, the user space may still ow

Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8)

2017-05-30 Thread Hans de Goede
Hi, On 29-05-17 22:25, Chris Wilson wrote: On Fri, Apr 14, 2017 at 11:15:04AM -0400, Sean Paul wrote: On Thu, Apr 13, 2017 at 03:32:44PM +0800, Jeffy Chen wrote: After unbinding drm, the user space may still owns the drm dev fd, and may still be able to call drm ioctl. We're using an unplugge

Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8)

2017-05-29 Thread Marco Diego Aurélio Mesquita
On Mon, May 29, 2017 at 5:25 PM, Chris Wilson wrote: > convince us to look into this patch again? > -Chris > >> > >> > drivers/gpu/drm/drm_drv.c | 26 ++ >> > drivers/gpu/drm/udl/udl_drv.c | 3 ++- >> > include/drm/drmP.h| 6 -- >> > include/drm/drm_d

Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8)

2017-05-29 Thread Chris Wilson
On Fri, Apr 14, 2017 at 11:15:04AM -0400, Sean Paul wrote: > On Thu, Apr 13, 2017 at 03:32:44PM +0800, Jeffy Chen wrote: > > After unbinding drm, the user space may still owns the drm dev fd, and > > may still be able to call drm ioctl. > > > > We're using an unplugged state to prevent something l

Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8)

2017-04-14 Thread Sean Paul
On Thu, Apr 13, 2017 at 03:32:44PM +0800, Jeffy Chen wrote: > After unbinding drm, the user space may still owns the drm dev fd, and > may still be able to call drm ioctl. > > We're using an unplugged state to prevent something like that, so let's > reuse it here. > > Also drop drm_unplug_dev, be

[PATCH v11] drm: Unplug drm device when unregistering it (v8)

2017-04-13 Thread Jeffy Chen
After unbinding drm, the user space may still owns the drm dev fd, and may still be able to call drm ioctl. We're using an unplugged state to prevent something like that, so let's reuse it here. Also drop drm_unplug_dev, because it would be unused after other changes. Verified on rk3399 chromebo