Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-29 Thread Maxime Ripard
On Mon, Jul 28, 2014 at 07:48:12PM +0530, Vinod Koul wrote: > On Mon, Jul 28, 2014 at 12:14:02PM +0200, Maxime Ripard wrote: > > On Fri, Jul 25, 2014 at 10:12:18PM +0530, Vinod Koul wrote: > > > On Fri, Jul 25, 2014 at 06:37:46PM +0200, Maxime Ripard wrote: > > > > > Can you please send follow patc

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-28 Thread Vinod Koul
On Mon, Jul 28, 2014 at 12:14:02PM +0200, Maxime Ripard wrote: > On Fri, Jul 25, 2014 at 10:12:18PM +0530, Vinod Koul wrote: > > On Fri, Jul 25, 2014 at 06:37:46PM +0200, Maxime Ripard wrote: > > > > Can you please send follow patches for these: > > > > - don't recall if I pointed earlier, but can

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-28 Thread Maxime Ripard
On Fri, Jul 25, 2014 at 10:12:18PM +0530, Vinod Koul wrote: > On Fri, Jul 25, 2014 at 06:37:46PM +0200, Maxime Ripard wrote: > > > Can you please send follow patches for these: > > > - don't recall if I pointed earlier, but can we use direct conversion for > > > calculating convert_burst() and co

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-28 Thread Maxime Ripard
Hi Russell, On Fri, Jul 25, 2014 at 05:45:19PM +0100, Russell King - ARM Linux wrote: > On Fri, Jul 25, 2014 at 06:37:46PM +0200, Maxime Ripard wrote: > > Hi Vinod, > > > > On Fri, Jul 25, 2014 at 06:42:17PM +0530, Vinod Koul wrote: > > > - don't use devm_request_irq(). You have irq enabled and y

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-25 Thread Vinod Koul
On Fri, Jul 25, 2014 at 06:37:46PM +0200, Maxime Ripard wrote: > > Can you please send follow patches for these: > > - don't recall if I pointed earlier, but can we use direct conversion for > > calculating convert_burst() and convert_buswidth(), latter one at least > > seem doable > > Ok. Do

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-25 Thread Russell King - ARM Linux
On Fri, Jul 25, 2014 at 06:37:46PM +0200, Maxime Ripard wrote: > Hi Vinod, > > On Fri, Jul 25, 2014 at 06:42:17PM +0530, Vinod Koul wrote: > > - don't use devm_request_irq(). You have irq enabled and you have killed > > tasklet. This is too racy. You need to ensure no irqs can be generated > >

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-25 Thread Maxime Ripard
Hi Vinod, On Fri, Jul 25, 2014 at 06:42:17PM +0530, Vinod Koul wrote: > On Thu, Jul 17, 2014 at 09:46:14PM +0200, Maxime Ripard wrote: > > Hi, > > > > This patchset adds support for the DMA controller found in the > > Allwinner A31 and A23 SoCs. > > > > This has been tested using the newly intro

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-25 Thread Vinod Koul
On Thu, Jul 17, 2014 at 09:46:14PM +0200, Maxime Ripard wrote: > Hi, > > This patchset adds support for the DMA controller found in the > Allwinner A31 and A23 SoCs. > > This has been tested using the newly introduced SPI driver on an A31 > EVK. Support for DMA-driven SPI transfers will be the su

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-25 Thread Andrew Morton
On Fri, 25 Jul 2014 11:43:20 +0530 Vinod Koul wrote: > On Fri, Jul 25, 2014 at 11:41:30AM +0530, Vinod Koul wrote: > > On Thu, Jul 24, 2014 at 04:44:20PM -0700, Andrew Morton wrote: > > > On Thu, 24 Jul 2014 14:13:15 +0200 Maxime Ripard > > > wrote: > > > > > > > On Thu, Jul 17, 2014 at 09:46:

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-24 Thread Vinod Koul
On Fri, Jul 25, 2014 at 11:41:30AM +0530, Vinod Koul wrote: > On Thu, Jul 24, 2014 at 04:44:20PM -0700, Andrew Morton wrote: > > On Thu, 24 Jul 2014 14:13:15 +0200 Maxime Ripard > > wrote: > > > > > On Thu, Jul 17, 2014 at 09:46:14PM +0200, Maxime Ripard wrote: > > > > Hi, > > > > > > > > This

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-24 Thread Vinod Koul
On Thu, Jul 24, 2014 at 04:44:20PM -0700, Andrew Morton wrote: > On Thu, 24 Jul 2014 14:13:15 +0200 Maxime Ripard > wrote: > > > On Thu, Jul 17, 2014 at 09:46:14PM +0200, Maxime Ripard wrote: > > > Hi, > > > > > > This patchset adds support for the DMA controller found in the > > > Allwinner A3

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-24 Thread Andrew Morton
On Thu, 24 Jul 2014 14:13:15 +0200 Maxime Ripard wrote: > On Thu, Jul 17, 2014 at 09:46:14PM +0200, Maxime Ripard wrote: > > Hi, > > > > This patchset adds support for the DMA controller found in the > > Allwinner A31 and A23 SoCs. > > > > This has been tested using the newly introduced SPI dr

Re: [PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-24 Thread Maxime Ripard
Vinod, Dan, On Thu, Jul 17, 2014 at 09:46:14PM +0200, Maxime Ripard wrote: > Hi, > > This patchset adds support for the DMA controller found in the > Allwinner A31 and A23 SoCs. > > This has been tested using the newly introduced SPI driver on an A31 > EVK. Support for DMA-driven SPI transfers w

[PATCH v11 0/2] Add support for the Allwinner A31 DMA Controller

2014-07-17 Thread Maxime Ripard
Hi, This patchset adds support for the DMA controller found in the Allwinner A31 and A23 SoCs. This has been tested using the newly introduced SPI driver on an A31 EVK. Support for DMA-driven SPI transfers will be the subject of another patch serie. This has been around for around 5 monthes now,