Re: [PATCH v11 01/12] add support for Clang's Shadow Call Stack (SCS)

2020-05-04 Thread Kees Cook
On Mon, May 04, 2020 at 05:52:28PM +0100, Will Deacon wrote: > On Mon, Apr 27, 2020 at 01:45:46PM -0700, Sami Tolvanen wrote: > > On Fri, Apr 24, 2020 at 12:21:14PM +0100, Will Deacon wrote: > > > The vmap version that I asked Sami to drop > > > is at least better in this regard, although the guard

Re: [PATCH v11 01/12] add support for Clang's Shadow Call Stack (SCS)

2020-05-04 Thread Jann Horn
On Mon, May 4, 2020 at 6:52 PM Will Deacon wrote: > On Mon, Apr 27, 2020 at 01:45:46PM -0700, Sami Tolvanen wrote: > > On Fri, Apr 24, 2020 at 12:21:14PM +0100, Will Deacon wrote: > > > Also, since you mentioned the lack of redzoning, isn't it a bit dodgy > > > allocating blindly out of the kmem_c

Re: [PATCH v11 01/12] add support for Clang's Shadow Call Stack (SCS)

2020-05-04 Thread Sami Tolvanen
On Mon, May 04, 2020 at 05:52:28PM +0100, Will Deacon wrote: > On Mon, Apr 27, 2020 at 01:45:46PM -0700, Sami Tolvanen wrote: > > I agree that allocating from a kmem_cache isn't ideal for safety. It's a > > compromise to reduce memory overhead. > > Do you think it would be a problem if we always a

Re: [PATCH v11 01/12] add support for Clang's Shadow Call Stack (SCS)

2020-05-04 Thread Will Deacon
On Mon, Apr 27, 2020 at 01:45:46PM -0700, Sami Tolvanen wrote: > On Fri, Apr 24, 2020 at 12:21:14PM +0100, Will Deacon wrote: > > Also, since you mentioned the lack of redzoning, isn't it a bit dodgy > > allocating blindly out of the kmem_cache? It means we don't have a redzone > > or a guard page,