Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-11-02 Thread Tony Krowiak
On 10/30/20 11:43 PM, Halil Pasic wrote: On Fri, 30 Oct 2020 16:37:04 -0400 Tony Krowiak wrote: On 10/30/20 1:42 PM, Halil Pasic wrote: On Thu, 29 Oct 2020 19:29:35 -0400 Tony Krowiak wrote: @@ -1177,7 +1166,10 @@ static int vfio_ap_mdev_reset_queues(struct mdev_device *mdev)

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Halil Pasic
On Fri, 30 Oct 2020 16:37:04 -0400 Tony Krowiak wrote: > On 10/30/20 1:42 PM, Halil Pasic wrote: > > On Thu, 29 Oct 2020 19:29:35 -0400 > > Tony Krowiak wrote: > > > @@ -1177,7 +1166,10 @@ static int vfio_ap_mdev_reset_queues(struct > mdev_device *mdev) >

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Tony Krowiak
On 10/30/20 1:56 PM, Halil Pasic wrote: On Thu, 29 Oct 2020 19:29:35 -0400 Tony Krowiak wrote: +void vfio_ap_mdev_remove_queue(struct ap_device *apdev) +{ + struct vfio_ap_queue *q; + struct ap_queue *queue; + int apid, apqi; + + queue = to_ap_queue(>device); What

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Tony Krowiak
On 10/30/20 4:53 PM, Tony Krowiak wrote: On 10/30/20 1:54 PM, Halil Pasic wrote: On Thu, 29 Oct 2020 19:29:35 -0400 Tony Krowiak wrote: @@ -1177,7 +1166,10 @@ static int vfio_ap_mdev_reset_queues(struct mdev_device *mdev)     */    if (ret)    rc

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Tony Krowiak
On 10/30/20 1:54 PM, Halil Pasic wrote: On Thu, 29 Oct 2020 19:29:35 -0400 Tony Krowiak wrote: @@ -1177,7 +1166,10 @@ static int vfio_ap_mdev_reset_queues(struct mdev_device *mdev) */ if (ret) rc = ret; -

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Tony Krowiak
On 10/30/20 1:27 PM, Halil Pasic wrote: On Thu, 29 Oct 2020 19:29:35 -0400 Tony Krowiak wrote: On 10/27/20 2:48 AM, Halil Pasic wrote: On Thu, 22 Oct 2020 13:11:56 -0400 Tony Krowiak wrote: The queues assigned to a matrix mediated device are currently reset when: * The

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Tony Krowiak
On 10/30/20 1:42 PM, Halil Pasic wrote: On Thu, 29 Oct 2020 19:29:35 -0400 Tony Krowiak wrote: @@ -1177,7 +1166,10 @@ static int vfio_ap_mdev_reset_queues(struct mdev_device *mdev) */ if (ret) rc = ret; -

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Halil Pasic
On Thu, 29 Oct 2020 19:29:35 -0400 Tony Krowiak wrote: > >> +void vfio_ap_mdev_remove_queue(struct ap_device *apdev) > >> +{ > >> + struct vfio_ap_queue *q; > >> + struct ap_queue *queue; > >> + int apid, apqi; > >> + > >> + queue = to_ap_queue(>device); > > What is the benefit of

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Halil Pasic
On Thu, 29 Oct 2020 19:29:35 -0400 Tony Krowiak wrote: > >> @@ -1177,7 +1166,10 @@ static int vfio_ap_mdev_reset_queues(struct > >> mdev_device *mdev) > >> */ > >>if (ret) > >>rc = ret; > >> -

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Halil Pasic
On Thu, 29 Oct 2020 19:29:35 -0400 Tony Krowiak wrote: > >> @@ -1177,7 +1166,10 @@ static int vfio_ap_mdev_reset_queues(struct > >> mdev_device *mdev) > >> */ > >>if (ret) > >>rc = ret; > >> -

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Halil Pasic
On Thu, 29 Oct 2020 19:29:35 -0400 Tony Krowiak wrote: > On 10/27/20 2:48 AM, Halil Pasic wrote: > > On Thu, 22 Oct 2020 13:11:56 -0400 > > Tony Krowiak wrote: > > > >> The queues assigned to a matrix mediated device are currently reset when: > >> > >> * The VFIO_DEVICE_RESET ioctl is invoked

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-30 Thread Tony Krowiak
On 10/29/20 7:29 PM, Tony Krowiak wrote: On 10/27/20 2:48 AM, Halil Pasic wrote: On Thu, 22 Oct 2020 13:11:56 -0400 Tony Krowiak wrote: The queues assigned to a matrix mediated device are currently reset when: * The VFIO_DEVICE_RESET ioctl is invoked * The mdev fd is closed by

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-29 Thread Tony Krowiak
On 10/27/20 2:48 AM, Halil Pasic wrote: On Thu, 22 Oct 2020 13:11:56 -0400 Tony Krowiak wrote: The queues assigned to a matrix mediated device are currently reset when: * The VFIO_DEVICE_RESET ioctl is invoked * The mdev fd is closed by userspace (QEMU) * The mdev is removed from sysfs.

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-27 Thread Halil Pasic
On Thu, 22 Oct 2020 13:11:56 -0400 Tony Krowiak wrote: > The queues assigned to a matrix mediated device are currently reset when: > > * The VFIO_DEVICE_RESET ioctl is invoked > * The mdev fd is closed by userspace (QEMU) > * The mdev is removed from sysfs. What about the situation when

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-26 Thread Tony Krowiak
On 10/22/20 3:44 PM, kernel test robot wrote: Hi Tony, I love your patch! Perhaps something to improve: [auto build test WARNING on s390/features] [also build test WARNING on linus/master kvms390/next linux/master v5.9 next-20201022] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-22 Thread kernel test robot
Hi Tony, I love your patch! Perhaps something to improve: [auto build test WARNING on s390/features] [also build test WARNING on linus/master kvms390/next linux/master v5.9 next-20201022] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

[PATCH v11 01/14] s390/vfio-ap: No need to disable IRQ after queue reset

2020-10-22 Thread Tony Krowiak
The queues assigned to a matrix mediated device are currently reset when: * The VFIO_DEVICE_RESET ioctl is invoked * The mdev fd is closed by userspace (QEMU) * The mdev is removed from sysfs. Immediately after the reset of a queue, a call is made to disable interrupts for the queue. This is