Re: [PATCH v11 01/19] arm: fiq: Add callbacks to manage FIQ routings

2014-09-03 Thread Daniel Thompson
On 03/09/14 01:03, Thomas Gleixner wrote: > On Tue, 2 Sep 2014, Daniel Thompson wrote: > >> Currently enable_fiq/disable_fiq use a simple offset to convert an IRQ >> virq into a FIQ virq. This is too inflexible for multi-platform kernels >> and makes runtime error checking impossible. > > You are

Re: [PATCH v11 01/19] arm: fiq: Add callbacks to manage FIQ routings

2014-09-02 Thread Thomas Gleixner
On Tue, 2 Sep 2014, Daniel Thompson wrote: > Currently enable_fiq/disable_fiq use a simple offset to convert an IRQ > virq into a FIQ virq. This is too inflexible for multi-platform kernels > and makes runtime error checking impossible. You are missing to explain WHY it is too inflexible >

Re: [PATCH v11 01/19] arm: fiq: Add callbacks to manage FIQ routings

2014-09-02 Thread Russell King - ARM Linux
On Tue, Sep 02, 2014 at 02:00:35PM +0100, Daniel Thompson wrote: > void enable_fiq(int fiq) > { > + struct fiq_data *data = lookup_fiq_data(fiq); > + > + if (data) { > + if (data->fiq_chip->fiq_enable) > + data->fiq_chip->fiq_enable(data->irq_data); > +

[PATCH v11 01/19] arm: fiq: Add callbacks to manage FIQ routings

2014-09-02 Thread Daniel Thompson
Currently enable_fiq/disable_fiq use a simple offset to convert an IRQ virq into a FIQ virq. This is too inflexible for multi-platform kernels and makes runtime error checking impossible. We solve this by introducing a flexible mapping that allows interrupt controllers that support FIQ to register