Re: [PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device

2020-11-13 Thread Tony Krowiak
On 11/5/20 7:27 AM, Halil Pasic wrote: On Wed, 4 Nov 2020 16:20:26 -0500 Tony Krowiak wrote: But I'm sure the code is suggesting it can, because vfio_ap_mdev_filter_guest_matrix() has a third parameter called filter_apid, which governs whether the apm or the aqm bit should be removed. And

Re: [PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device

2020-11-05 Thread Halil Pasic
On Wed, 4 Nov 2020 16:20:26 -0500 Tony Krowiak wrote: > > But I'm sure the code is suggesting it can, because > > vfio_ap_mdev_filter_guest_matrix() has a third parameter called filter_apid, > > which governs whether the apm or the aqm bit should be removed. And > >

Re: [PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device

2020-11-04 Thread Tony Krowiak
On 11/4/20 7:52 AM, Halil Pasic wrote: On Tue, 3 Nov 2020 17:49:21 -0500 Tony Krowiak wrote: +void vfio_ap_mdev_hot_unplug_queue(struct vfio_ap_queue *q) +{ + unsigned long apid = AP_QID_CARD(q->apqn); + + if ((q->matrix_mdev == NULL) ||

Re: [PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device

2020-11-04 Thread Halil Pasic
On Tue, 3 Nov 2020 17:49:21 -0500 Tony Krowiak wrote: > > We do this to show the no queues but bits set output in show? We could > > get rid of some code if we were to not z Managed to delete "eroize" fro "zeroize" > > I'm not sure what you are saying/asking here. The reason for this > is

Re: [PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device

2020-11-04 Thread Halil Pasic
On Tue, 3 Nov 2020 17:49:21 -0500 Tony Krowiak wrote: > >> > >> +void vfio_ap_mdev_hot_unplug_queue(struct vfio_ap_queue *q) > >> +{ > >> + unsigned long apid = AP_QID_CARD(q->apqn); > >> + > >> + if ((q->matrix_mdev == NULL) || !vfio_ap_mdev_has_crycb(q->matrix_mdev)) > >> +

Re: [PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device

2020-11-03 Thread Tony Krowiak
On 10/28/20 9:57 AM, Halil Pasic wrote: On Thu, 22 Oct 2020 13:12:03 -0400 Tony Krowiak wrote: In response to the probe or remove of a queue device, if a KVM guest is using the matrix mdev to which the APQN of the queue device is assigned, the vfio_ap device driver must respond

Re: [PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device

2020-10-28 Thread Halil Pasic
On Thu, 22 Oct 2020 13:12:03 -0400 Tony Krowiak wrote: > In response to the probe or remove of a queue device, if a KVM guest is > using the matrix mdev to which the APQN of the queue device is assigned, > the vfio_ap device driver must respond accordingly. In an ideal world, the > queue device

Re: [PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device

2020-10-26 Thread Tony Krowiak
On 10/22/20 4:30 PM, kernel test robot wrote: Hi Tony, I love your patch! Perhaps something to improve: [auto build test WARNING on s390/features] [also build test WARNING on linus/master kvms390/next linux/master v5.9 next-20201022] [If your patch is applied to the wrong git tree, kindly

Re: [PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device

2020-10-22 Thread kernel test robot
Hi Tony, I love your patch! Perhaps something to improve: [auto build test WARNING on s390/features] [also build test WARNING on linus/master kvms390/next linux/master v5.9 next-20201022] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

[PATCH v11 08/14] s390/vfio-ap: hot plug/unplug queues on bind/unbind of queue device

2020-10-22 Thread Tony Krowiak
In response to the probe or remove of a queue device, if a KVM guest is using the matrix mdev to which the APQN of the queue device is assigned, the vfio_ap device driver must respond accordingly. In an ideal world, the queue device being probed would be hot plugged into the guest. Likewise, the