Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header

2018-07-05 Thread Andy Shevchenko
On Thu, Jul 5, 2018 at 2:23 PM, 禹舟键 wrote: > Hi Michal and Andy > The enum oom_constraint will be added in the struct oom_control. So > I still think I should define it in oom.h. You missed the point. I'm talking about an array of string literals. Please, check what the warning I got from the

Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header

2018-07-05 Thread 禹舟键
Hi Michal and Andy The enum oom_constraint will be added in the struct oom_control. So I still think I should define it in oom.h. Michal Hocko 于2018年7月4日周三 下午4:17写道： > > On Wed 04-07-18 10:25:30, 禹舟键 wrote: > > Hi Andy > > The const char array need to be used by the new func > > mem_cgroup_print

Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header

2018-07-04 Thread Andy Shevchenko
On Wed, Jul 4, 2018 at 5:25 AM, 禹舟键 wrote: > Hi Andy > The const char array need to be used by the new func > mem_cgroup_print_oom_context and some funcs in oom_kill.c in the > second patch. Did I understand correctly that the array is added by you in this solely patch? Did I understand correctly

Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header

2018-07-04 Thread Michal Hocko
On Wed 04-07-18 10:25:30, 禹舟键 wrote: > Hi Andy > The const char array need to be used by the new func > mem_cgroup_print_oom_context and some funcs in oom_kill.c in the > second patch. Just declare it in oom.h and define in oom.c -- Michal Hocko SUSE Labs

Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header

2018-07-03 Thread 禹舟键
Hi Andy The const char array need to be used by the new func mem_cgroup_print_oom_context and some funcs in oom_kill.c in the second patch. Thanks > > On Sat, Jun 30, 2018 at 7:38 PM, wrote: > > From: yuzhoujian > > > > The current system wide oom report prints information about the victim > >

Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header

2018-07-03 Thread Andy Shevchenko
On Sat, Jun 30, 2018 at 7:38 PM, wrote: > From: yuzhoujian > > The current system wide oom report prints information about the victim > and the allocation context and restrictions. It, however, doesn't > provide any information about memory cgroup the victim belongs to. This > information can be

Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header

2018-07-03 Thread Michal Hocko
On Tue 03-07-18 18:57:14, 禹舟键 wrote: > Hi Michal > cpuset_print_current_mems_allowed is also invoked by > warn_alloc(page_alloc.c). So, can I remove the current->comm output in > the pr_info ? > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index d8b12e0d39cd..09b8ef6186c6 10064

Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header

2018-07-03 Thread 禹舟键
Hi Michal cpuset_print_current_mems_allowed is also invoked by warn_alloc(page_alloc.c). So, can I remove the current->comm output in the pr_info ? diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index d8b12e0d39cd..09b8ef6186c6 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/

Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header

2018-07-02 Thread Michal Hocko
On Sun 01-07-18 00:38:58, ufo19890...@gmail.com wrote: > From: yuzhoujian > > The current system wide oom report prints information about the victim > and the allocation context and restrictions. It, however, doesn't > provide any information about memory cgroup the victim belongs to. This > info

[PATCH v11 1/2] Refactor part of the oom report in dump_header

2018-06-30 Thread ufo19890607
From: yuzhoujian The current system wide oom report prints information about the victim and the allocation context and restrictions. It, however, doesn't provide any information about memory cgroup the victim belongs to. This information can be interesting for container users because they can fin