Re: [PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

2017-01-04 Thread Lee Jones
On Thu, 08 Dec 2016, Marek Vasut wrote: > On 12/08/2016 11:27 PM, Ksenija Stanojevic wrote: > > Add core files for low resolution analog-to-digital converter (mxs-lradc) > > MFD driver. > > > > Signed-off-by: Ksenija Stanojevic > > Just a nit below. > > > +++ b/include/linux/mfd/mxs-lradc.h >

Re: [PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

2016-12-08 Thread Marek Vasut
On 12/08/2016 11:27 PM, Ksenija Stanojevic wrote: > Add core files for low resolution analog-to-digital converter (mxs-lradc) > MFD driver. > > Signed-off-by: Ksenija Stanojevic Just a nit below. > +++ b/include/linux/mfd/mxs-lradc.h > @@ -0,0 +1,187 @@ > +/* [...] > +#define LRADC_CTRL1_MX28

[PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD

2016-12-08 Thread Ksenija Stanojevic
Add core files for low resolution analog-to-digital converter (mxs-lradc) MFD driver. Signed-off-by: Ksenija Stanojevic --- Changes in v11: - create static struct mfd_cells - don't set platform data in mfd cells, set driver data instead - remove mxs_lradc_reg_* functions, use writel function i