Re: [PATCH v11 19/21] dax: Add dax_zero_page_range

2014-10-18 Thread Mathieu Desnoyers
quot; > > Sent: Saturday, October 18, 2014 7:41:00 PM > Subject: Re: [PATCH v11 19/21] dax: Add dax_zero_page_range > > On Fri, Oct 17, 2014 at 03:49:39PM +, Mathieu Desnoyers wrote: > > > I kind of wonder if we shouldn't just declare the function. It's called >

Re: [PATCH v11 19/21] dax: Add dax_zero_page_range

2014-10-18 Thread Matthew Wilcox
On Fri, Oct 17, 2014 at 03:49:39PM +, Mathieu Desnoyers wrote: > > I kind of wonder if we shouldn't just declare the function. It's called > > like this: > > > > if (IS_DAX(inode)) > > return dax_zero_page_range(inode, from, length, > > ext4_get_block);

Re: [PATCH v11 19/21] dax: Add dax_zero_page_range

2014-10-17 Thread Mathieu Desnoyers
- Original Message - > From: "Matthew Wilcox" > To: "Mathieu Desnoyers" > Cc: "Matthew Wilcox" , > linux-fsde...@vger.kernel.org, linux...@kvack.org, > linux-kernel@vger.kernel.org, "Ross Zwisler" > Sent: Friday, October 17,

Re: [PATCH v11 19/21] dax: Add dax_zero_page_range

2014-10-17 Thread Matthew Wilcox
On Thu, Oct 16, 2014 at 02:38:24PM +0200, Mathieu Desnoyers wrote: > > +int dax_zero_page_range(struct inode *inode, loff_t from, unsigned length, > > nit: unsigned -> unsigned int ? > > Do we want a unsigned int or unsigned long here ? It's supposed to be for a fragment of a page, so until we s

Re: [PATCH v11 19/21] dax: Add dax_zero_page_range

2014-10-16 Thread Mathieu Desnoyers
On 25-Sep-2014 04:33:36 PM, Matthew Wilcox wrote: > This new function allows us to support hole-punch for DAX files by zeroing > a partial page, as opposed to the dax_truncate_page() function which can > only truncate to the end of the page. Reimplement dax_truncate_page() to > call dax_zero_page_

[PATCH v11 19/21] dax: Add dax_zero_page_range

2014-09-25 Thread Matthew Wilcox
This new function allows us to support hole-punch for DAX files by zeroing a partial page, as opposed to the dax_truncate_page() function which can only truncate to the end of the page. Reimplement dax_truncate_page() to call dax_zero_page_range(). Signed-off-by: Matthew Wilcox [ported to 3.13-r