Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-20 Thread Jarkko Nikula
On 06/19/2017 07:22 PM, Wolfram Sang wrote: I wonder if we haven't reached a state where Luis just could fix the buildbot error (missing 'select I2C_SLAVE') and the thing pointed out by Andy and we handle further small fixes incrementally during the v4.13 cycle? AFAICS there is no major show-st

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-19 Thread Wolfram Sang
> > I wonder if we haven't reached a state where Luis just could fix the > > buildbot error (missing 'select I2C_SLAVE') and the thing pointed out by > > Andy and we handle further small fixes incrementally during the v4.13 > > cycle? AFAICS there is no major show-stopper, or am I wrong? > > I wo

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-19 Thread Luis Oliveira
On 19-Jun-17 17:05, Andy Shevchenko wrote: > On Mon, Jun 19, 2017 at 6:58 PM, Wolfram Sang wrote: >>> Believe me I've looked for mistakes like this but I've read the code so many >>> times I don't think I can see the obvious anymore. >> >> Yes, I know this. And you worked hard on this slave featur

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-19 Thread Andy Shevchenko
On Mon, Jun 19, 2017 at 6:58 PM, Wolfram Sang wrote: >> Believe me I've looked for mistakes like this but I've read the code so many >> times I don't think I can see the obvious anymore. > > Yes, I know this. And you worked hard on this slave feature, > acknowledged. > > Patches 1-4 look good to m

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-19 Thread Wolfram Sang
Hiya, > Believe me I've looked for mistakes like this but I've read the code so many > times I don't think I can see the obvious anymore. Yes, I know this. And you worked hard on this slave feature, acknowledged. Patches 1-4 look good to me from what I glimpsed. I largely trust here the *much* a

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-17 Thread kbuild test robot
Hi Luis, [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v4.12-rc5 next-20170616] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Luis-Oliveira/i2c-designware-add-I2C-SLAVE-

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-14 Thread Luis Oliveira
On 14-Jun-17 13:20, Andy Shevchenko wrote: > On Wed, Jun 14, 2017 at 1:43 PM, Luis Oliveira > wrote: >> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support >> - Slave functions added to core library file >> - Slave abort sources added to common source file >> - New driver: i2c-designware-s

Re: [PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-14 Thread Andy Shevchenko
On Wed, Jun 14, 2017 at 1:43 PM, Luis Oliveira wrote: > - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support > - Slave functions added to core library file > - Slave abort sources added to common source file > - New driver: i2c-designware-slave added > - Changes in the Makefile to compile t

[PATCH v11 5/6] i2c: designware: add SLAVE mode functions

2017-06-14 Thread Luis Oliveira
- Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support - Slave functions added to core library file - Slave abort sources added to common source file - New driver: i2c-designware-slave added - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module when supported by the architectu