Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-11 Thread Rusty Russell
Rafael Aquini writes: > On Thu, Nov 08, 2012 at 09:32:18AM +1030, Rusty Russell wrote: >> The first one can be delayed, the second one can be delayed if the host >> didn't ask for VIRTIO_BALLOON_F_MUST_TELL_HOST (qemu doesn't). >> >> We could implement a proper request queue for these, and

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-11 Thread Rusty Russell
Rafael Aquini aqu...@redhat.com writes: On Thu, Nov 08, 2012 at 09:32:18AM +1030, Rusty Russell wrote: The first one can be delayed, the second one can be delayed if the host didn't ask for VIRTIO_BALLOON_F_MUST_TELL_HOST (qemu doesn't). We could implement a proper request queue for these,

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-10 Thread Michael S. Tsirkin
On Wed, Nov 07, 2012 at 01:05:52AM -0200, Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of >

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-10 Thread Michael S. Tsirkin
On Wed, Nov 07, 2012 at 04:11:46PM -0800, Andrew Morton wrote: > On Thu, 08 Nov 2012 09:32:18 +1030 > Rusty Russell wrote: > > > Rafael Aquini writes: > > > + * virtballoon_migratepage - perform the balloon page migration on > > > behalf of > > > + *a compation

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-10 Thread Michael S. Tsirkin
On Wed, Nov 07, 2012 at 04:11:46PM -0800, Andrew Morton wrote: On Thu, 08 Nov 2012 09:32:18 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Rafael Aquini aqu...@redhat.com writes: + * virtballoon_migratepage - perform the balloon page migration on behalf of + *

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-10 Thread Michael S. Tsirkin
On Wed, Nov 07, 2012 at 01:05:52AM -0200, Rafael Aquini wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Rafael Aquini
On Thu, Nov 08, 2012 at 09:32:18AM +1030, Rusty Russell wrote: > The first one can be delayed, the second one can be delayed if the host > didn't ask for VIRTIO_BALLOON_F_MUST_TELL_HOST (qemu doesn't). > > We could implement a proper request queue for these, and return -EAGAIN > if the queue

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Rafael Aquini
On Wed, Nov 07, 2012 at 04:11:46PM -0800, Andrew Morton wrote: > On Thu, 08 Nov 2012 09:32:18 +1030 > Rusty Russell wrote: > > > Rafael Aquini writes: > > > + * virtballoon_migratepage - perform the balloon page migration on > > > behalf of > > > + *a compation

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Andrew Morton
On Thu, 08 Nov 2012 09:32:18 +1030 Rusty Russell wrote: > Rafael Aquini writes: > > + * virtballoon_migratepage - perform the balloon page migration on behalf > > of > > + * a compation thread. (called under page lock) > > > + if (!mutex_trylock(>balloon_lock)) > >

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Rusty Russell
Rafael Aquini writes: > + * virtballoon_migratepage - perform the balloon page migration on behalf of > + *a compation thread. (called under page lock) > + if (!mutex_trylock(>balloon_lock)) > + return -EAGAIN; Erk, OK... > + /* balloon's page

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Rafael Aquini
On Wed, Nov 07, 2012 at 11:58:10AM -0800, Andrew Morton wrote: > On Wed, 7 Nov 2012 01:05:52 -0200 > Rafael Aquini wrote: > > > Memory fragmentation introduced by ballooning might reduce significantly > > the number of 2MB contiguous memory blocks that can be used within a guest, > > thus

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Andrew Morton
On Wed, 7 Nov 2012 01:05:52 -0200 Rafael Aquini wrote: > Memory fragmentation introduced by ballooning might reduce significantly > the number of 2MB contiguous memory blocks that can be used within a guest, > thus imposing performance penalties associated with the reduced number of >

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Andrew Morton
On Wed, 7 Nov 2012 01:05:52 -0200 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Rafael Aquini
On Wed, Nov 07, 2012 at 11:58:10AM -0800, Andrew Morton wrote: On Wed, 7 Nov 2012 01:05:52 -0200 Rafael Aquini aqu...@redhat.com wrote: Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest,

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Rusty Russell
Rafael Aquini aqu...@redhat.com writes: + * virtballoon_migratepage - perform the balloon page migration on behalf of + *a compation thread. (called under page lock) + if (!mutex_trylock(vb-balloon_lock)) + return -EAGAIN; Erk, OK... + /*

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Andrew Morton
On Thu, 08 Nov 2012 09:32:18 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Rafael Aquini aqu...@redhat.com writes: + * virtballoon_migratepage - perform the balloon page migration on behalf of + * a compation thread. (called under page lock) + if

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Rafael Aquini
On Wed, Nov 07, 2012 at 04:11:46PM -0800, Andrew Morton wrote: On Thu, 08 Nov 2012 09:32:18 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Rafael Aquini aqu...@redhat.com writes: + * virtballoon_migratepage - perform the balloon page migration on behalf of + *

Re: [PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-07 Thread Rafael Aquini
On Thu, Nov 08, 2012 at 09:32:18AM +1030, Rusty Russell wrote: The first one can be delayed, the second one can be delayed if the host didn't ask for VIRTIO_BALLOON_F_MUST_TELL_HOST (qemu doesn't). We could implement a proper request queue for these, and return -EAGAIN if the queue fills.

[PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-06 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. Besides

[PATCH v11 5/7] virtio_balloon: introduce migration primitives to balloon pages

2012-11-06 Thread Rafael Aquini
Memory fragmentation introduced by ballooning might reduce significantly the number of 2MB contiguous memory blocks that can be used within a guest, thus imposing performance penalties associated with the reduced number of transparent huge pages that could be used by the guest workload. Besides