Re: [PATCH v12] NVMe: Convert to blk-mq

2014-08-21 Thread Keith Busch
On Thu, 21 Aug 2014, Matias Bjørling wrote: On 08/19/2014 12:49 AM, Keith Busch wrote: I see the driver's queue suspend logic is removed, but I didn't mean to imply it was safe to do so without replacing it with something else. I thought maybe we could use the blk_stop/start_queue() functions

Re: [PATCH v12] NVMe: Convert to blk-mq

2014-08-21 Thread Matias Bjørling
On 08/19/2014 12:49 AM, Keith Busch wrote: On Fri, 15 Aug 2014, Matias Bjørling wrote: * NVMe queues are merged with the tags structure of blk-mq. I see the driver's queue suspend logic is removed, but I didn't mean to imply it was safe to do so without replacing it with something else. I

Re: [PATCH v12] NVMe: Convert to blk-mq

2014-08-21 Thread Matias Bjørling
On 08/19/2014 12:49 AM, Keith Busch wrote: On Fri, 15 Aug 2014, Matias Bjørling wrote: * NVMe queues are merged with the tags structure of blk-mq. I see the driver's queue suspend logic is removed, but I didn't mean to imply it was safe to do so without replacing it with something else. I

Re: [PATCH v12] NVMe: Convert to blk-mq

2014-08-21 Thread Keith Busch
On Thu, 21 Aug 2014, Matias Bjørling wrote: On 08/19/2014 12:49 AM, Keith Busch wrote: I see the driver's queue suspend logic is removed, but I didn't mean to imply it was safe to do so without replacing it with something else. I thought maybe we could use the blk_stop/start_queue() functions

Re: [PATCH v12] NVMe: Convert to blk-mq

2014-08-18 Thread Keith Busch
On Fri, 15 Aug 2014, Matias Bjørling wrote: * NVMe queues are merged with the tags structure of blk-mq. I see the driver's queue suspend logic is removed, but I didn't mean to imply it was safe to do so without replacing it with something else. I thought maybe we could use the

Re: [PATCH v12] NVMe: Convert to blk-mq

2014-08-18 Thread Keith Busch
On Fri, 15 Aug 2014, Matias Bjørling wrote: * NVMe queues are merged with the tags structure of blk-mq. I see the driver's queue suspend logic is removed, but I didn't mean to imply it was safe to do so without replacing it with something else. I thought maybe we could use the

[PATCH v12] NVMe: Convert to blk-mq

2014-08-15 Thread Matias Bjørling
This converts the NVMe driver to a blk-mq request-based driver. The NVMe driver is currently bio-based and implements queue logic within itself. By using blk-mq, a lot of these responsibilities can be moved and simplified. The patch is divided into the following blocks: * Per-command data and

[PATCH v12] NVMe: Convert to blk-mq

2014-08-15 Thread Matias Bjørling
This converts the NVMe driver to a blk-mq request-based driver. The NVMe driver is currently bio-based and implements queue logic within itself. By using blk-mq, a lot of these responsibilities can be moved and simplified. The patch is divided into the following blocks: * Per-command data and