RE: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Fernandes, Joel A
Russell King; Rob > Landley; Andrew Morton; Jason Kridner; Koen Kooi; Devicetree Discuss; Linux > OMAP List; Linux ARM Kernel List; Linux DaVinci Kernel List; Linux Kernel > Mailing List; Linux Documentation List; Linux MMC List; Linux SPI Devel List > Subject: Re: [PATCH v12 05/11] edma: con

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Arnd Bergmann
On Monday 24 June 2013, Joel A Fernandes wrote: > >> Yes sure, right now they are defined as follows in include/linux/edma.h: > >> > >> #if defined(CONFIG_TI_EDMA) || defined(CONFIG_TI_EDMA_MODULE) > >> bool edma_filter_fn(struct dma_chan *, void *); > >> #else > >> static inline bool edma_filter_

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Joel A Fernandes
On Mon, Jun 24, 2013 at 3:28 PM, Arnd Bergmann wrote: > On Saturday 22 June 2013, Joel A Fernandes wrote: >> >> >> > config TI_EDMA >> >> > tristate "TI EDMA support" >> >> > default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 >> >> > select DMA_ENGINE >> >> > se

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Arnd Bergmann
On Saturday 22 June 2013, Joel A Fernandes wrote: > > >> > config TI_EDMA > >> > tristate "TI EDMA support" > >> > default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 > >> > select DMA_ENGINE > >> > select DMA_VIRTUAL_CHANNELS > >> > >> > >> MMC depends on EDMA s

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Joel A Fernandes
On Mon, Jun 24, 2013 at 6:23 AM, Sekhar Nori wrote: > On 6/22/2013 3:23 AM, Joel A Fernandes wrote: >> Hi Arnd, >> >> On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >>> On Friday 21 June 2013, Joel A Fernandes wrote: I think we are talking about different things, I agree the 'select >

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Joel A Fernandes
On Mon, Jun 24, 2013 at 6:53 AM, Sekhar Nori wrote: > On 6/22/2013 8:23 AM, Joel A Fernandes wrote: > config TI_EDMA > tristate "TI EDMA support" > default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 > select DMA_ENGINE > select DMA_VIRTUAL_CH

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Sekhar Nori
On 6/22/2013 8:23 AM, Joel A Fernandes wrote: config TI_EDMA tristate "TI EDMA support" default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 select DMA_ENGINE select DMA_VIRTUAL_CHANNELS >>> >>> >>> MMC depends on EDMA specially on AM33xx t

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Sekhar Nori
On 6/24/2013 4:53 PM, Sekhar Nori wrote: > On 6/22/2013 3:23 AM, Joel A Fernandes wrote: >> Hi Arnd, >> >> On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >>> On Friday 21 June 2013, Joel A Fernandes wrote: I think we are talking about different things, I agree the 'select DMADEVIC

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-24 Thread Sekhar Nori
On 6/22/2013 3:23 AM, Joel A Fernandes wrote: > Hi Arnd, > > On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: >> On Friday 21 June 2013, Joel A Fernandes wrote: >>> I think we are talking about different things, I agree the 'select >>> DMADEVICES' can be dropped but lets please keep the defa

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Joel A Fernandes
>> > config TI_EDMA >> > tristate "TI EDMA support" >> > default m if 'ARCH_DAVINCI || ARCH_OMAP1 || ARCH_OMAP2 >> > select DMA_ENGINE >> > select DMA_VIRTUAL_CHANNELS >> >> >> MMC depends on EDMA specially on AM33xx there's no PIO mode AFAIK. The >> 'm' option will

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Arnd Bergmann
On Friday 21 June 2013, Joel A Fernandes wrote: > Hi Arnd, > > On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: > > On Friday 21 June 2013, Joel A Fernandes wrote: > >> I think we are talking about different things, I agree the 'select > >> DMADEVICES' can be dropped but lets please keep the

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Joel A Fernandes
Hi Arnd, On Fri, Jun 21, 2013 at 1:44 PM, Arnd Bergmann wrote: > On Friday 21 June 2013, Joel A Fernandes wrote: >> I think we are talking about different things, I agree the 'select >> DMADEVICES' can be dropped but lets please keep the default y option >> (not adding new select statements, just

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Arnd Bergmann
On Friday 21 June 2013, Joel A Fernandes wrote: > I think we are talking about different things, I agree the 'select > DMADEVICES' can be dropped but lets please keep the default y option > (not adding new select statements, just saying that if someone select > DMADEVICES in menuconfig and if they'

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Joel A Fernandes
On Fri, Jun 21, 2013 at 9:32 AM, Arnd Bergmann wrote: > On Friday 21 June 2013, Joel A Fernandes wrote: >> I haven't come across this problem but- are you saying there is a >> shortcoming in Kbuild/Kconfig that selects an option even if its >> dependency is not met? > > Well, the shortcoming is th

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Arnd Bergmann
On Friday 21 June 2013, Joel A Fernandes wrote: > I haven't come across this problem but- are you saying there is a > shortcoming in Kbuild/Kconfig that selects an option even if its > dependency is not met? Well, the shortcoming is that it lets you specify impossible contraints. You get a warning

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Joel A Fernandes
On Fri, Jun 21, 2013 at 9:00 AM, Arnd Bergmann wrote: > On Friday 21 June 2013, Joel A Fernandes wrote: >> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> >> index b1c66a4..7d58cd9 100644 >> >> --- a/arch/arm/Kconfig >> >> +++ b/arch/arm/Kconfig >> >> @@ -841,6 +841,7 @@ config ARCH_DAVINCI

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Arnd Bergmann
On Friday 21 June 2013, Joel A Fernandes wrote: > >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > >> index b1c66a4..7d58cd9 100644 > >> --- a/arch/arm/Kconfig > >> +++ b/arch/arm/Kconfig > >> @@ -841,6 +841,7 @@ config ARCH_DAVINCI > >> select HAVE_IDE > >> select NEED_MACH_GPIO_H

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Joel A Fernandes
On Fri, Jun 21, 2013 at 5:16 AM, Sekhar Nori wrote: > On 6/21/2013 2:36 AM, Joel A Fernandes wrote: >> From: Joel A Fernandes >> >> Build TI_EDMA by default for ARCH_DAVINCI and ARCH_OMAP2PLUS >> >> Signed-off-by: Joel A Fernandes > > You should sign-off with author e-mail address. > >> --- >>

Re: [PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-21 Thread Sekhar Nori
On 6/21/2013 2:36 AM, Joel A Fernandes wrote: > From: Joel A Fernandes > > Build TI_EDMA by default for ARCH_DAVINCI and ARCH_OMAP2PLUS > > Signed-off-by: Joel A Fernandes You should sign-off with author e-mail address. > --- > arch/arm/Kconfig|1 + > arch/arm/mach-omap2/Kcon

[PATCH v12 05/11] edma: config: Enable config options for EDMA

2013-06-20 Thread Joel A Fernandes
From: Joel A Fernandes Build TI_EDMA by default for ARCH_DAVINCI and ARCH_OMAP2PLUS Signed-off-by: Joel A Fernandes --- arch/arm/Kconfig|1 + arch/arm/mach-omap2/Kconfig |1 + drivers/dma/Kconfig |2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git