Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-27 Thread Pavel Machek
Hi! > > Actually you have it also: > > "Duration of 0 means brightness should immediately change to new value" > > > > According to this, to get instant changes your pattern should look > > like this: > > > > echo "0 100 0 0 20 100 20 0 40 100 40 0 80 100 80 0 100 100" > pattern > > Make sense.

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-27 Thread Pavel Machek
Hi! > > Actually you have it also: > > "Duration of 0 means brightness should immediately change to new value" > > > > According to this, to get instant changes your pattern should look > > like this: > > > > echo "0 100 0 0 20 100 20 0 40 100 40 0 80 100 80 0 100 100" > pattern > > Make sense.

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-25 Thread Baolin Wang
On 26 September 2018 at 04:00, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/25/2018 01:15 PM, Baolin Wang wrote: >> On 23 September 2018 at 20:25, Jacek Anaszewski >> wrote: >>> On 09/22/2018 09:44 PM, Pavel Machek wrote: On Sat 2018-09-22 00:18:13, Pavel Machek wrote: > On Sat

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-25 Thread Baolin Wang
On 26 September 2018 at 04:00, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/25/2018 01:15 PM, Baolin Wang wrote: >> On 23 September 2018 at 20:25, Jacek Anaszewski >> wrote: >>> On 09/22/2018 09:44 PM, Pavel Machek wrote: On Sat 2018-09-22 00:18:13, Pavel Machek wrote: > On Sat

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-25 Thread Jacek Anaszewski
Hi Baolin, On 09/25/2018 01:15 PM, Baolin Wang wrote: > On 23 September 2018 at 20:25, Jacek Anaszewski > wrote: >> On 09/22/2018 09:44 PM, Pavel Machek wrote: >>> On Sat 2018-09-22 00:18:13, Pavel Machek wrote: On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: > On 09/21/2018 11:17

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-25 Thread Jacek Anaszewski
Hi Baolin, On 09/25/2018 01:15 PM, Baolin Wang wrote: > On 23 September 2018 at 20:25, Jacek Anaszewski > wrote: >> On 09/22/2018 09:44 PM, Pavel Machek wrote: >>> On Sat 2018-09-22 00:18:13, Pavel Machek wrote: On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: > On 09/21/2018 11:17

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-25 Thread Baolin Wang
On 25 September 2018 at 07:54, Bjorn Andersson wrote: > On Mon 10 Sep 19:47 PDT 2018, Baolin Wang wrote: > [..] >> diff --git a/Documentation/ABI/testing/sysfs-class-led-trigger-pattern >> b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern > [..] >> +What:

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-25 Thread Baolin Wang
On 25 September 2018 at 07:54, Bjorn Andersson wrote: > On Mon 10 Sep 19:47 PDT 2018, Baolin Wang wrote: > [..] >> diff --git a/Documentation/ABI/testing/sysfs-class-led-trigger-pattern >> b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern > [..] >> +What:

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-25 Thread Baolin Wang
On 23 September 2018 at 20:25, Jacek Anaszewski wrote: > On 09/22/2018 09:44 PM, Pavel Machek wrote: >> On Sat 2018-09-22 00:18:13, Pavel Machek wrote: >>> On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: On 09/21/2018 11:17 PM, Pavel Machek wrote: > On Fri 2018-09-21 22:59:40, Jacek

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-25 Thread Baolin Wang
On 23 September 2018 at 20:25, Jacek Anaszewski wrote: > On 09/22/2018 09:44 PM, Pavel Machek wrote: >> On Sat 2018-09-22 00:18:13, Pavel Machek wrote: >>> On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: On 09/21/2018 11:17 PM, Pavel Machek wrote: > On Fri 2018-09-21 22:59:40, Jacek

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-24 Thread Bjorn Andersson
On Mon 10 Sep 19:47 PDT 2018, Baolin Wang wrote: [..] > diff --git a/Documentation/ABI/testing/sysfs-class-led-trigger-pattern > b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern [..] > +What:/sys/class/leds//hw_pattern > +Date:September 2018 >

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-24 Thread Bjorn Andersson
On Mon 10 Sep 19:47 PDT 2018, Baolin Wang wrote: [..] > diff --git a/Documentation/ABI/testing/sysfs-class-led-trigger-pattern > b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern [..] > +What:/sys/class/leds//hw_pattern > +Date:September 2018 >

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-23 Thread Jacek Anaszewski
On 09/22/2018 09:44 PM, Pavel Machek wrote: > On Sat 2018-09-22 00:18:13, Pavel Machek wrote: >> On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: >>> On 09/21/2018 11:17 PM, Pavel Machek wrote: On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-23 Thread Jacek Anaszewski
On 09/22/2018 09:44 PM, Pavel Machek wrote: > On Sat 2018-09-22 00:18:13, Pavel Machek wrote: >> On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: >>> On 09/21/2018 11:17 PM, Pavel Machek wrote: On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-22 Thread Pavel Machek
On Sat 2018-09-22 00:18:13, Pavel Machek wrote: > On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: > > On 09/21/2018 11:17 PM, Pavel Machek wrote: > > > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > > >> Hi Baolin, > > >> > > >> On 09/21/2018 05:31 AM, Baolin Wang wrote: > > >>> Hi

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-22 Thread Pavel Machek
On Sat 2018-09-22 00:18:13, Pavel Machek wrote: > On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: > > On 09/21/2018 11:17 PM, Pavel Machek wrote: > > > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > > >> Hi Baolin, > > >> > > >> On 09/21/2018 05:31 AM, Baolin Wang wrote: > > >>> Hi

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Baolin Wang
Hi, On 22 September 2018 at 06:18, Pavel Machek wrote: > On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: >> On 09/21/2018 11:17 PM, Pavel Machek wrote: >> > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: >> >> Hi Baolin, >> >> >> >> On 09/21/2018 05:31 AM, Baolin Wang wrote: >> >>> Hi

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Baolin Wang
Hi, On 22 September 2018 at 06:18, Pavel Machek wrote: > On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: >> On 09/21/2018 11:17 PM, Pavel Machek wrote: >> > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: >> >> Hi Baolin, >> >> >> >> On 09/21/2018 05:31 AM, Baolin Wang wrote: >> >>> Hi

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: > On 09/21/2018 11:17 PM, Pavel Machek wrote: > > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > >> Hi Baolin, > >> > >> On 09/21/2018 05:31 AM, Baolin Wang wrote: > >>> Hi Jacek and Pavel, > >>> > >>> On 11 September 2018 at 10:47, Baolin

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Sat 2018-09-22 00:11:29, Jacek Anaszewski wrote: > On 09/21/2018 11:17 PM, Pavel Machek wrote: > > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > >> Hi Baolin, > >> > >> On 09/21/2018 05:31 AM, Baolin Wang wrote: > >>> Hi Jacek and Pavel, > >>> > >>> On 11 September 2018 at 10:47, Baolin

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Jacek Anaszewski
On 09/21/2018 11:17 PM, Pavel Machek wrote: > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: >> Hi Baolin, >> >> On 09/21/2018 05:31 AM, Baolin Wang wrote: >>> Hi Jacek and Pavel, >>> >>> On 11 September 2018 at 10:47, Baolin Wang wrote: This patch adds one new led trigger that LED

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Jacek Anaszewski
On 09/21/2018 11:17 PM, Pavel Machek wrote: > On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: >> Hi Baolin, >> >> On 09/21/2018 05:31 AM, Baolin Wang wrote: >>> Hi Jacek and Pavel, >>> >>> On 11 September 2018 at 10:47, Baolin Wang wrote: This patch adds one new led trigger that LED

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Pavel Machek
On Fri 2018-09-21 22:59:40, Jacek Anaszewski wrote: > Hi Baolin, > > On 09/21/2018 05:31 AM, Baolin Wang wrote: > > Hi Jacek and Pavel, > > > > On 11 September 2018 at 10:47, Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Jacek Anaszewski
Hi Baolin, On 09/21/2018 05:31 AM, Baolin Wang wrote: > Hi Jacek and Pavel, > > On 11 September 2018 at 10:47, Baolin Wang wrote: >> This patch adds one new led trigger that LED device can configure >> the software or hardware pattern and trigger it. >> >> Consumers can write 'pattern' file to

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-21 Thread Jacek Anaszewski
Hi Baolin, On 09/21/2018 05:31 AM, Baolin Wang wrote: > Hi Jacek and Pavel, > > On 11 September 2018 at 10:47, Baolin Wang wrote: >> This patch adds one new led trigger that LED device can configure >> the software or hardware pattern and trigger it. >> >> Consumers can write 'pattern' file to

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-20 Thread Baolin Wang
Hi Jacek and Pavel, On 11 September 2018 at 10:47, Baolin Wang wrote: > This patch adds one new led trigger that LED device can configure > the software or hardware pattern and trigger it. > > Consumers can write 'pattern' file to enable the software pattern > which alters the brightness for the

Re: [PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-20 Thread Baolin Wang
Hi Jacek and Pavel, On 11 September 2018 at 10:47, Baolin Wang wrote: > This patch adds one new led trigger that LED device can configure > the software or hardware pattern and trigger it. > > Consumers can write 'pattern' file to enable the software pattern > which alters the brightness for the

[PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-10 Thread Baolin Wang
This patch adds one new led trigger that LED device can configure the software or hardware pattern and trigger it. Consumers can write 'pattern' file to enable the software pattern which alters the brightness for the specified duration with one software timer. Moreover consumers can write

[PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-10 Thread Baolin Wang
This patch adds one new led trigger that LED device can configure the software or hardware pattern and trigger it. Consumers can write 'pattern' file to enable the software pattern which alters the brightness for the specified duration with one software timer. Moreover consumers can write