Re: [PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module

2016-05-17 Thread Huang Shijie
On Tue, May 17, 2016 at 11:24:27AM +0100, Mark Brown wrote: > On Tue, May 17, 2016 at 05:57:33PM +0800, Huang Shijie wrote: > > On Wed, Apr 27, 2016 at 02:53:05PM -0400, David Long wrote: > > > > +#ifdef CONFIG_ARM64 > > > + pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n", > > > I think you

Re: [PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module

2016-05-17 Thread Huang Shijie
On Tue, May 17, 2016 at 11:24:27AM +0100, Mark Brown wrote: > On Tue, May 17, 2016 at 05:57:33PM +0800, Huang Shijie wrote: > > On Wed, Apr 27, 2016 at 02:53:05PM -0400, David Long wrote: > > > > +#ifdef CONFIG_ARM64 > > > + pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n", > > > I think you

Re: [PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module

2016-05-17 Thread Mark Brown
On Tue, May 17, 2016 at 05:57:33PM +0800, Huang Shijie wrote: > On Wed, Apr 27, 2016 at 02:53:05PM -0400, David Long wrote: > > +#ifdef CONFIG_ARM64 > > + pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n", > I think you miss the KERN_INFO here. That's what pr_info() does over printk() - it

Re: [PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module

2016-05-17 Thread Mark Brown
On Tue, May 17, 2016 at 05:57:33PM +0800, Huang Shijie wrote: > On Wed, Apr 27, 2016 at 02:53:05PM -0400, David Long wrote: > > +#ifdef CONFIG_ARM64 > > + pr_info("pre_handler: p->addr = 0x%p, pc = 0x%lx\n", > I think you miss the KERN_INFO here. That's what pr_info() does over printk() - it

Re: [PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module

2016-05-17 Thread Huang Shijie
On Wed, Apr 27, 2016 at 02:53:05PM -0400, David Long wrote: > From: Sandeepa Prabhu > > Add info prints in sample kprobe handlers for ARM64 > > Signed-off-by: Sandeepa Prabhu > --- > samples/kprobes/kprobe_example.c | 8 > 1

Re: [PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module

2016-05-17 Thread Huang Shijie
On Wed, Apr 27, 2016 at 02:53:05PM -0400, David Long wrote: > From: Sandeepa Prabhu > > Add info prints in sample kprobe handlers for ARM64 > > Signed-off-by: Sandeepa Prabhu > --- > samples/kprobes/kprobe_example.c | 8 > 1 file changed, 8 insertions(+) > > diff --git

[PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module

2016-04-27 Thread David Long
From: Sandeepa Prabhu Add info prints in sample kprobe handlers for ARM64 Signed-off-by: Sandeepa Prabhu --- samples/kprobes/kprobe_example.c | 8 1 file changed, 8 insertions(+) diff --git a/samples/kprobes/kprobe_example.c

[PATCH v12 10/10] kprobes: Add arm64 case in kprobe example module

2016-04-27 Thread David Long
From: Sandeepa Prabhu Add info prints in sample kprobe handlers for ARM64 Signed-off-by: Sandeepa Prabhu --- samples/kprobes/kprobe_example.c | 8 1 file changed, 8 insertions(+) diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c index 727eb21..0c72b8a