Re: [PATCH v12 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-27 Thread Loc Ho
Hi Balbi, >> +/* >> + * This function is used to configure the PHY to operation as either SATA >> Gen1 >> + * or Gen2 speed. >> + */ >> +static void xgene_phy_sata_force_gen(struct xgene_phy_ctx *ctx, >> + int lane, int gen) > > why do you need to *force* the gene

Re: [PATCH v12 3/4] PHY: add APM X-Gene SoC 15Gbps Multi-purpose PHY driver

2014-02-27 Thread Felipe Balbi
Hi, On Thu, Feb 27, 2014 at 11:14:07AM -0700, Loc Ho wrote: > +/* > + * This function is used to configure the PHY to operation as either SATA > Gen1 > + * or Gen2 speed. > + */ > +static void xgene_phy_sata_force_gen(struct xgene_phy_ctx *ctx, > + int lane, int g