Re: [PATCH v13 06/14] KVM: Make dirty ring exclusive to dirty bitmap log

2020-11-06 Thread Paolo Bonzini
On 01/10/20 03:22, Peter Xu wrote: + /* Dirty ring tracking is exclusive to dirty log tracking */ + if (kvm->dirty_ring_size) + return -EINVAL; + ENXIO is slightly more appropriate (especially for debugging, as EINVAL suggests that the arguments were wrong and not some e

[PATCH v13 06/14] KVM: Make dirty ring exclusive to dirty bitmap log

2020-09-30 Thread Peter Xu
There's no good reason to use both the dirty bitmap logging and the new dirty ring buffer to track dirty bits. We should be able to even support both of them at the same time, but it could complicate things which could actually help little. Let's simply make it the rule before we enable dirty rin