Re: [PATCH v13 12/14] perf, tools: Add support for event list topics

2015-06-03 Thread Jiri Olsa
On Wed, Jun 03, 2015 at 05:57:33AM -0700, Andi Kleen wrote: > > please split at least the jevents Topic parsing from the rest > > idelay also the alias update and the display change > > What's the point of all these splits? It's already one logical unit, > not too large, and is bisectable. splitt

Re: [PATCH v13 12/14] perf, tools: Add support for event list topics

2015-06-03 Thread Arnaldo Carvalho de Melo
Em Wed, Jun 03, 2015 at 05:57:33AM -0700, Andi Kleen escreveu: > > please split at least the jevents Topic parsing from the rest > > idelay also the alias update and the display change > > What's the point of all these splits? It's already one logical unit, > not too large, and is bisectable. Eas

Re: [PATCH v13 12/14] perf, tools: Add support for event list topics

2015-06-03 Thread Andi Kleen
> please split at least the jevents Topic parsing from the rest > idelay also the alias update and the display change What's the point of all these splits? It's already one logical unit, not too large, and is bisectable. -andi -- a...@linux.intel.com -- Speaking for myself only -- To unsubscrib

Re: [PATCH v13 12/14] perf, tools: Add support for event list topics

2015-06-03 Thread Jiri Olsa
On Tue, Jun 02, 2015 at 12:16:41PM -0700, Sukadev Bhattiprolu wrote: SNIP >[Speculative and retired macro-conditional branches] > br_inst_exec.all_direct_jmp >[Speculative and retired macro-unconditional branches excluding calls > and indirects] > br_inst_exec.all_direct_near

Re: [PATCH v13 12/14] perf, tools: Add support for event list topics

2015-06-02 Thread Sukadev Bhattiprolu
Sukadev Bhattiprolu [suka...@linux.vnet.ibm.com] wrote: | From: Andi Kleen | | Add support to group the output of perf list by the Topic field | in the JSON file. [PATCH 9/14] has been dropped from this set. This alters the current, patch [PATCH 12/14], slightly, which is included below. The br

[PATCH v13 12/14] perf, tools: Add support for event list topics

2015-06-02 Thread Sukadev Bhattiprolu
From: Andi Kleen Add support to group the output of perf list by the Topic field in the JSON file. Example output: % perf list ... Cache: l1d.replacement [L1D data line replacements] l1d_pend_miss.pending [L1D miss oustandings duration in cycles] l1d_pend_miss.pending_cycles