Re: [PATCH v13 13/23] x86/asm/crypto: Create stack frames in aesni-intel_asm.S

2015-10-01 Thread Josh Poimboeuf
On Thu, Oct 01, 2015 at 07:36:54PM +0200, Mathias Krause wrote: > On Do, Okt 01, 2015 at 08:29:50 -0500, Josh Poimboeuf wrote: > > On Thu, Oct 01, 2015 at 08:10:26AM +0200, mini...@ld-linux.so wrote: > > > On Tue, Sep 22, 2015 at 10:47:04AM -0500, Josh Poimboeuf wrote: > > > > ENTRY(aesni_set_key)

Re: [PATCH v13 13/23] x86/asm/crypto: Create stack frames in aesni-intel_asm.S

2015-10-01 Thread Mathias Krause
On Do, Okt 01, 2015 at 08:29:50 -0500, Josh Poimboeuf wrote: > On Thu, Oct 01, 2015 at 08:10:26AM +0200, mini...@ld-linux.so wrote: > > On Tue, Sep 22, 2015 at 10:47:04AM -0500, Josh Poimboeuf wrote: > > > ENTRY(aesni_set_key) > > > + FRAME_BEGIN > > > #ifndef __x86_64__ > > > pushl KEYP > > >

Re: [PATCH v13 13/23] x86/asm/crypto: Create stack frames in aesni-intel_asm.S

2015-10-01 Thread Josh Poimboeuf
On Thu, Oct 01, 2015 at 08:10:26AM +0200, mini...@ld-linux.so wrote: > On Tue, Sep 22, 2015 at 10:47:04AM -0500, Josh Poimboeuf wrote: > > aesni-intel_asm.S has several callable non-leaf functions which don't > > honor CONFIG_FRAME_POINTER, which can result in bad stack traces. > > > > Create stac

Re: [PATCH v13 13/23] x86/asm/crypto: Create stack frames in aesni-intel_asm.S

2015-09-30 Thread minipli
On Tue, Sep 22, 2015 at 10:47:04AM -0500, Josh Poimboeuf wrote: > aesni-intel_asm.S has several callable non-leaf functions which don't > honor CONFIG_FRAME_POINTER, which can result in bad stack traces. > > Create stack frames for them when CONFIG_FRAME_POINTER is enabled. > > Signed-off-by: Jos

[PATCH v13 13/23] x86/asm/crypto: Create stack frames in aesni-intel_asm.S

2015-09-22 Thread Josh Poimboeuf
aesni-intel_asm.S has several callable non-leaf functions which don't honor CONFIG_FRAME_POINTER, which can result in bad stack traces. Create stack frames for them when CONFIG_FRAME_POINTER is enabled. Signed-off-by: Josh Poimboeuf Cc: Herbert Xu Cc: David S. Miller --- arch/x86/crypto/aesni