Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-16 Thread David Rientjes
On Sun, 15 Jul 2018, 禹舟键 wrote: > Hi David > Could I use use plain old %d? Just like this, > pr_cont(",task=%s,pid=%d,uid=%d\n", p->comm, p->pid, > from_kuid(&init_user_ns, task_uid(p))); > Yes please!

Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-14 Thread 禹舟键
Hi David Could I use use plain old %d? Just like this, pr_cont(",task=%s,pid=%d,uid=%d\n", p->comm, p->pid, from_kuid(&init_user_ns, task_uid(p))); Thanks

Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-13 Thread David Rientjes
On Fri, 13 Jul 2018, ufo19890...@gmail.com wrote: > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 531b2c86d4db..7fbd389ea779 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -434,10 +434,11 @@ static void dump_header(struct oom_control *oc, struct > task_struct *p) >

Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-13 Thread Michal Hocko
On Fri 13-07-18 19:55:52, ufo19890...@gmail.com wrote: > From: yuzhoujian > > The current oom report doesn't display victim's memcg context during the > global OOM situation. While this information is not strictly needed, it > can be really helpful for containerized environments to locate which >

[PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-13 Thread ufo19890607
From: yuzhoujian The current oom report doesn't display victim's memcg context during the global OOM situation. While this information is not strictly needed, it can be really helpful for containerized environments to locate which container has lost a process. Now that we have a single line for t

Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-11 Thread Michal Hocko
On Wed 11-07-18 18:31:18, 禹舟键 wrote: > Hi Michal > > I think the single line output you want is just like that: > > oom-kill:constraint=,nodemask=,cpuset=,mems_allowed=,oom_memcg=,task_memcg=,task=,pid=,uid= > > Am I right? exactly. -- Michal Hocko SUSE Labs

Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-11 Thread 禹舟键
Hi Michal I think the single line output you want is just like that: oom-kill:constraint=,nodemask=,cpuset=,mems_allowed=,oom_memcg=,task_memcg=,task=,pid=,uid= Am I right?

Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-11 Thread Michal Hocko
On Wed 11-07-18 11:39:29, 禹舟键 wrote: > Hi Michal > Sorry , I l forget to update the changlog for the second patch, but > the cpuset information is not missing. The cpuset information is missing in the changelog. > Do I still need to make the > v14 or just update the changelog for v13? Wait for

Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-10 Thread 禹舟键
Hi Michal Sorry , I l forget to update the changlog for the second patch, but the cpuset information is not missing. Do I still need to make the v14 or just update the changelog for v13? Thanks

Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-10 Thread Michal Hocko
On Tue 10-07-18 18:19:48, ufo19890...@gmail.com wrote: > From: yuzhoujian > > The current oom report doesn't display victim's memcg context during the > global OOM situation. While this information is not strictly needed, it > can be really helpful for containerized environments to locate which >

[PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-10 Thread ufo19890607
From: yuzhoujian The current oom report doesn't display victim's memcg context during the global OOM situation. While this information is not strictly needed, it can be really helpful for containerized environments to locate which container has lost a process. Now that we have a single line for t