Re: [PATCH v13 2/5] remoteproc/mediatek: add SCP support for mt8183

2019-08-05 Thread Pi-Hsun Shih
Thanks for the review. I'll address most of the comments in the next version. On Mon, Jul 22, 2019 at 5:37 PM Alexandre Courbot wrote: > > Hi Pi-Hsun, > > On Tue, Jul 9, 2019 at 4:27 PM Pi-Hsun Shih wrote: > > +static void *scp_da_to_va(struct rproc *rproc, u64 da, int len) > > +{ > > + st

Re: [PATCH v13 2/5] remoteproc/mediatek: add SCP support for mt8183

2019-07-22 Thread Alexandre Courbot
Hi Pi-Hsun, On Tue, Jul 9, 2019 at 4:27 PM Pi-Hsun Shih wrote: > > From: Erin Lo > > Provide a basic driver to control Cortex M4 co-processor > > Signed-off-by: Erin Lo > Signed-off-by: Nicolas Boichat > Signed-off-by: Pi-Hsun Shih > --- > Changes from v12: > - Initialize cache before firmwa

[PATCH v13 2/5] remoteproc/mediatek: add SCP support for mt8183

2019-07-09 Thread Pi-Hsun Shih
From: Erin Lo Provide a basic driver to control Cortex M4 co-processor Signed-off-by: Erin Lo Signed-off-by: Nicolas Boichat Signed-off-by: Pi-Hsun Shih --- Changes from v12: - Initialize cache before firmware load, to avoid problem while loading large firmware. - Disable watchdog before