Re: [PATCH v13 4/6] PCI/DPC: Unify and plumb error handling into DPC

2018-04-09 Thread Sinan Kaya
On 4/9/2018 7:51 PM, Sinan Kaya wrote: > On 4/9/2018 7:29 PM, Keith Busch wrote: >> On Mon, Apr 09, 2018 at 10:41:52AM -0400, Oza Pawandeep wrote: >>> +static int find_dpc_dev_iter(struct device *device, void *data) >>> +{ >>> + struct pcie_port_service_driver *service_driver; >>> + struct

Re: [PATCH v13 4/6] PCI/DPC: Unify and plumb error handling into DPC

2018-04-09 Thread Sinan Kaya
On 4/9/2018 7:51 PM, Sinan Kaya wrote: > On 4/9/2018 7:29 PM, Keith Busch wrote: >> On Mon, Apr 09, 2018 at 10:41:52AM -0400, Oza Pawandeep wrote: >>> +static int find_dpc_dev_iter(struct device *device, void *data) >>> +{ >>> + struct pcie_port_service_driver *service_driver; >>> + struct

Re: [PATCH v13 4/6] PCI/DPC: Unify and plumb error handling into DPC

2018-04-09 Thread Sinan Kaya
On 4/9/2018 7:29 PM, Keith Busch wrote: > On Mon, Apr 09, 2018 at 10:41:52AM -0400, Oza Pawandeep wrote: >> +static int find_dpc_dev_iter(struct device *device, void *data) >> +{ >> +struct pcie_port_service_driver *service_driver; >> +struct device **dev; >> + >> +dev = (struct device

Re: [PATCH v13 4/6] PCI/DPC: Unify and plumb error handling into DPC

2018-04-09 Thread Sinan Kaya
On 4/9/2018 7:29 PM, Keith Busch wrote: > On Mon, Apr 09, 2018 at 10:41:52AM -0400, Oza Pawandeep wrote: >> +static int find_dpc_dev_iter(struct device *device, void *data) >> +{ >> +struct pcie_port_service_driver *service_driver; >> +struct device **dev; >> + >> +dev = (struct device

Re: [PATCH v13 4/6] PCI/DPC: Unify and plumb error handling into DPC

2018-04-09 Thread Keith Busch
On Mon, Apr 09, 2018 at 10:41:52AM -0400, Oza Pawandeep wrote: > +static int find_dpc_dev_iter(struct device *device, void *data) > +{ > + struct pcie_port_service_driver *service_driver; > + struct device **dev; > + > + dev = (struct device **) data; > + > + if (device->bus ==

Re: [PATCH v13 4/6] PCI/DPC: Unify and plumb error handling into DPC

2018-04-09 Thread Keith Busch
On Mon, Apr 09, 2018 at 10:41:52AM -0400, Oza Pawandeep wrote: > +static int find_dpc_dev_iter(struct device *device, void *data) > +{ > + struct pcie_port_service_driver *service_driver; > + struct device **dev; > + > + dev = (struct device **) data; > + > + if (device->bus ==

[PATCH v13 4/6] PCI/DPC: Unify and plumb error handling into DPC

2018-04-09 Thread Oza Pawandeep
Current DPC driver does not do recovery, e.g. calling end-point's driver's callbacks, which sanitize the sw. DPC driver implements link_reset callback, and calls pci_do_recovery(). Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c

[PATCH v13 4/6] PCI/DPC: Unify and plumb error handling into DPC

2018-04-09 Thread Oza Pawandeep
Current DPC driver does not do recovery, e.g. calling end-point's driver's callbacks, which sanitize the sw. DPC driver implements link_reset callback, and calls pci_do_recovery(). Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c index 98aeec4..d02e029