Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Tony Lindgren
* Tony Lindgren [150202 11:28]: > * Mike Turquette [150202 09:50]: > > Quoting Tony Lindgren (2015-02-02 08:12:37) > > > > > > [ 10.568206] [ cut here ] > > > [ 10.568206] WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:925 > > > clk_disable+0x28/0x34() > > > [ 10.5682

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Tony Lindgren
* Mike Turquette [150202 09:50]: > Quoting Tony Lindgren (2015-02-02 08:12:37) > > > > [ 10.568206] [ cut here ] > > [ 10.568206] WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:925 > > clk_disable+0x28/0x34() > > [ 10.568237] Modules linked in: > > [ 10.568237] CPU:

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Russell King - ARM Linux
On Mon, Feb 02, 2015 at 09:46:46AM -0800, Mike Turquette wrote: > This looks like mis-matched enable/disable calls. We now have unique > struct clk pointers for every call to clk_get. I haven't yet looked > through the hwmod code but I have a feeling that we're doing something > like this: > >

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Mike Turquette
Quoting Tony Lindgren (2015-02-02 08:12:37) > * Geert Uytterhoeven [150202 00:03]: > > On Sun, Feb 1, 2015 at 11:18 PM, Mike Turquette > > wrote: > > > Quoting Tomeu Vizoso (2015-01-31 10:36:22) > > >> On 31 January 2015 at 02:31, Stephen Boyd wrote: > > >> > On 01/29, Stephen Boyd wrote: > > >

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Tony Lindgren
* Geert Uytterhoeven [150202 00:03]: > On Sun, Feb 1, 2015 at 11:18 PM, Mike Turquette wrote: > > Quoting Tomeu Vizoso (2015-01-31 10:36:22) > >> On 31 January 2015 at 02:31, Stephen Boyd wrote: > >> > On 01/29, Stephen Boyd wrote: > >> >> On 01/29/15 05:31, Geert Uytterhoeven wrote: > >> >> > H

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-02 Thread Geert Uytterhoeven
On Sun, Feb 1, 2015 at 11:18 PM, Mike Turquette wrote: > Quoting Tomeu Vizoso (2015-01-31 10:36:22) >> On 31 January 2015 at 02:31, Stephen Boyd wrote: >> > On 01/29, Stephen Boyd wrote: >> >> On 01/29/15 05:31, Geert Uytterhoeven wrote: >> >> > Hi Tomeu, Mike, >> >> > >> >> > On Fri, Jan 23, 201

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-02-01 Thread Mike Turquette
Quoting Tomeu Vizoso (2015-01-31 10:36:22) > On 31 January 2015 at 02:31, Stephen Boyd wrote: > > On 01/29, Stephen Boyd wrote: > >> On 01/29/15 05:31, Geert Uytterhoeven wrote: > >> > Hi Tomeu, Mike, > >> > > >> > On Fri, Jan 23, 2015 at 12:03 PM, Tomeu Vizoso > >> > wrote: > >> >> --- a/drivers

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-01-31 Thread Tomeu Vizoso
On 31 January 2015 at 02:31, Stephen Boyd wrote: > On 01/29, Stephen Boyd wrote: >> On 01/29/15 05:31, Geert Uytterhoeven wrote: >> > Hi Tomeu, Mike, >> > >> > On Fri, Jan 23, 2015 at 12:03 PM, Tomeu Vizoso >> > wrote: >> >> --- a/drivers/clk/clk.c >> >> +++ b/drivers/clk/clk.c >> >> @@ -2391,25

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-01-30 Thread Stephen Boyd
On 01/29, Stephen Boyd wrote: > On 01/29/15 05:31, Geert Uytterhoeven wrote: > > Hi Tomeu, Mike, > > > > On Fri, Jan 23, 2015 at 12:03 PM, Tomeu Vizoso > > wrote: > >> --- a/drivers/clk/clk.c > >> +++ b/drivers/clk/clk.c > >> @@ -2391,25 +2543,24 @@ int __clk_get(struct clk *clk) > >> retu

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-01-29 Thread Stephen Boyd
On 01/29/15 05:31, Geert Uytterhoeven wrote: > Hi Tomeu, Mike, > > On Fri, Jan 23, 2015 at 12:03 PM, Tomeu Vizoso > wrote: >> --- a/drivers/clk/clk.c >> +++ b/drivers/clk/clk.c >> @@ -2391,25 +2543,24 @@ int __clk_get(struct clk *clk) >> return 1; >> } >> >> -static void clk_core_put(stru

Re: [PATCH v13 4/6] clk: Add rate constraints to clocks

2015-01-29 Thread Geert Uytterhoeven
Hi Tomeu, Mike, On Fri, Jan 23, 2015 at 12:03 PM, Tomeu Vizoso wrote: > Adds a way for clock consumers to set maximum and minimum rates. This > can be used for thermal drivers to set minimum rates, or by misc. > drivers to set maximum rates to assure a minimum performance level. > > Changes the s

[PATCH v13 4/6] clk: Add rate constraints to clocks

2015-01-23 Thread Tomeu Vizoso
Adds a way for clock consumers to set maximum and minimum rates. This can be used for thermal drivers to set minimum rates, or by misc. drivers to set maximum rates to assure a minimum performance level. Changes the signature of the determine_rate callback by adding the parameters min_rate and max