Re: [PATCH v13 5/5] leds: mt6360: Add LED driver for MT6360

2021-02-19 Thread Pavel Machek
Hi! > From: Gene Chen > > Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, > 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for > moonlight LED. What kind of ninja mutant hardware is this? Can we make this go to drivers/leds/flash? > +static int

Re: [PATCH v13 5/5] leds: mt6360: Add LED driver for MT6360

2021-01-12 Thread Matthias Brugger
On 21/12/2020 11:45, Gene Chen wrote: > From: Gene Chen [...] > + > +static const struct of_device_id __maybe_unused mt6360_led_of_id[] = { > + { .compatible = "mediatek,mt6360-led", }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, mt6360_led_of_id); > + I think we should fix MFD code to

[PATCH v13 5/5] leds: mt6360: Add LED driver for MT6360

2020-12-21 Thread Gene Chen
From: Gene Chen Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode, 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for moonlight LED. Signed-off-by: Gene Chen --- drivers/leds/Kconfig | 13 + drivers/leds/Makefile | 1 +