Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-11-09 Thread Pavel Machek
On Wed 2018-11-07 11:23:52, Baolin Wang wrote: > Hi Geert, > > On 6 November 2018 at 23:57, Geert Uytterhoeven wrote: > > Hi Baolin, > > > > On Tue, Oct 2, 2018 at 6:39 PM Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-11-09 Thread Pavel Machek
On Wed 2018-11-07 11:23:52, Baolin Wang wrote: > Hi Geert, > > On 6 November 2018 at 23:57, Geert Uytterhoeven wrote: > > Hi Baolin, > > > > On Tue, Oct 2, 2018 at 6:39 PM Baolin Wang wrote: > >> This patch adds one new led trigger that LED device can configure > >> the software or hardware

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-11-06 Thread Baolin Wang
Hi Geert, On 6 November 2018 at 23:57, Geert Uytterhoeven wrote: > Hi Baolin, > > On Tue, Oct 2, 2018 at 6:39 PM Baolin Wang wrote: >> This patch adds one new led trigger that LED device can configure >> the software or hardware pattern and trigger it. >> >> Consumers can write 'pattern' file

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-11-06 Thread Baolin Wang
Hi Geert, On 6 November 2018 at 23:57, Geert Uytterhoeven wrote: > Hi Baolin, > > On Tue, Oct 2, 2018 at 6:39 PM Baolin Wang wrote: >> This patch adds one new led trigger that LED device can configure >> the software or hardware pattern and trigger it. >> >> Consumers can write 'pattern' file

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-11-06 Thread Geert Uytterhoeven
Hi Baolin, On Tue, Oct 2, 2018 at 6:39 PM Baolin Wang wrote: > This patch adds one new led trigger that LED device can configure > the software or hardware pattern and trigger it. > > Consumers can write 'pattern' file to enable the software pattern > which alters the brightness for the

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-11-06 Thread Geert Uytterhoeven
Hi Baolin, On Tue, Oct 2, 2018 at 6:39 PM Baolin Wang wrote: > This patch adds one new led trigger that LED device can configure > the software or hardware pattern and trigger it. > > Consumers can write 'pattern' file to enable the software pattern > which alters the brightness for the

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-10 Thread Baolin Wang
Hi Jacek, On 11 October 2018 at 04:43, Jacek Anaszewski wrote: > Hi Baolin, > > I've finally managed to test this patch and it turned out > that this implementation doesn't prevent what I had concerns > about, i.e. setting intervals less then 50ms. > > What user needs to do to achieve that is

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-10 Thread Baolin Wang
Hi Jacek, On 11 October 2018 at 04:43, Jacek Anaszewski wrote: > Hi Baolin, > > I've finally managed to test this patch and it turned out > that this implementation doesn't prevent what I had concerns > about, i.e. setting intervals less then 50ms. > > What user needs to do to achieve that is

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-10 Thread Baolin Wang
Hi Pavel, On 11 October 2018 at 00:00, Pavel Machek wrote: > Hi! > > [Oops. I wrote this but forgot to send it? Anyway.. I guess it is > redundant now.] > >> > +++ b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern >> > @@ -0,0 +1,76 @@ >> > +What: /sys/class/leds//pattern

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-10 Thread Baolin Wang
Hi Pavel, On 11 October 2018 at 00:00, Pavel Machek wrote: > Hi! > > [Oops. I wrote this but forgot to send it? Anyway.. I guess it is > redundant now.] > >> > +++ b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern >> > @@ -0,0 +1,76 @@ >> > +What: /sys/class/leds//pattern

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-10 Thread Jacek Anaszewski
Hi Baolin, I've finally managed to test this patch and it turned out that this implementation doesn't prevent what I had concerns about, i.e. setting intervals less then 50ms. What user needs to do to achieve that is just e.g.: echo "10 1 10 0 20 1 20 0 30 1 30 0" > pattern Please refer below

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-10 Thread Jacek Anaszewski
Hi Baolin, I've finally managed to test this patch and it turned out that this implementation doesn't prevent what I had concerns about, i.e. setting intervals less then 50ms. What user needs to do to achieve that is just e.g.: echo "10 1 10 0 20 1 20 0 30 1 30 0" > pattern Please refer below

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-10 Thread Pavel Machek
Hi! [Oops. I wrote this but forgot to send it? Anyway.. I guess it is redundant now.] > > +++ b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern > > @@ -0,0 +1,76 @@ > > +What: /sys/class/leds//pattern > > +Date: September 2018 > > +KernelVersion: 4.20 > >

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-10 Thread Pavel Machek
Hi! [Oops. I wrote this but forgot to send it? Anyway.. I guess it is redundant now.] > > +++ b/Documentation/ABI/testing/sysfs-class-led-trigger-pattern > > @@ -0,0 +1,76 @@ > > +What: /sys/class/leds//pattern > > +Date: September 2018 > > +KernelVersion: 4.20 > >

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-09 Thread Baolin Wang
Hi Jacek, On 10 October 2018 at 02:37, Jacek Anaszewski wrote: > Hi Baolin, > > On 10/09/2018 02:01 PM, Baolin Wang wrote: >> Hi Jacek and Pavel, >> >> On 5 October 2018 at 04:00, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> On 10/03/2018 03:21 AM, Baolin Wang wrote: Hi Jacek,

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-09 Thread Baolin Wang
Hi Jacek, On 10 October 2018 at 02:37, Jacek Anaszewski wrote: > Hi Baolin, > > On 10/09/2018 02:01 PM, Baolin Wang wrote: >> Hi Jacek and Pavel, >> >> On 5 October 2018 at 04:00, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> On 10/03/2018 03:21 AM, Baolin Wang wrote: Hi Jacek,

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-09 Thread Jacek Anaszewski
Hi Baolin, On 10/09/2018 02:01 PM, Baolin Wang wrote: > Hi Jacek and Pavel, > > On 5 October 2018 at 04:00, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> On 10/03/2018 03:21 AM, Baolin Wang wrote: >>> Hi Jacek, >>> >>> On 3 October 2018 at 04:25, Jacek Anaszewski >>> wrote: Hi Baolin,

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-09 Thread Jacek Anaszewski
Hi Baolin, On 10/09/2018 02:01 PM, Baolin Wang wrote: > Hi Jacek and Pavel, > > On 5 October 2018 at 04:00, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> On 10/03/2018 03:21 AM, Baolin Wang wrote: >>> Hi Jacek, >>> >>> On 3 October 2018 at 04:25, Jacek Anaszewski >>> wrote: Hi Baolin,

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-09 Thread Baolin Wang
Hi Jacek and Pavel, On 5 October 2018 at 04:00, Jacek Anaszewski wrote: > Hi Baolin, > > On 10/03/2018 03:21 AM, Baolin Wang wrote: >> Hi Jacek, >> >> On 3 October 2018 at 04:25, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> Thank you for the v14. We'll probably need v15, though :-) >>>

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-09 Thread Baolin Wang
Hi Jacek and Pavel, On 5 October 2018 at 04:00, Jacek Anaszewski wrote: > Hi Baolin, > > On 10/03/2018 03:21 AM, Baolin Wang wrote: >> Hi Jacek, >> >> On 3 October 2018 at 04:25, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> Thank you for the v14. We'll probably need v15, though :-) >>>

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-04 Thread Jacek Anaszewski
Hi Baolin, On 10/03/2018 03:21 AM, Baolin Wang wrote: > Hi Jacek, > > On 3 October 2018 at 04:25, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> Thank you for the v14. We'll probably need v15, though :-) >> >> I added the comments in the code below. >> >> On 10/02/2018 05:43 PM, Baolin Wang

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-04 Thread Jacek Anaszewski
Hi Baolin, On 10/03/2018 03:21 AM, Baolin Wang wrote: > Hi Jacek, > > On 3 October 2018 at 04:25, Jacek Anaszewski > wrote: >> Hi Baolin, >> >> Thank you for the v14. We'll probably need v15, though :-) >> >> I added the comments in the code below. >> >> On 10/02/2018 05:43 PM, Baolin Wang

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-02 Thread Baolin Wang
Hi Jacek, On 3 October 2018 at 04:25, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the v14. We'll probably need v15, though :-) > > I added the comments in the code below. > > On 10/02/2018 05:43 PM, Baolin Wang wrote: >> This patch adds one new led trigger that LED device can

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-02 Thread Baolin Wang
Hi Jacek, On 3 October 2018 at 04:25, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the v14. We'll probably need v15, though :-) > > I added the comments in the code below. > > On 10/02/2018 05:43 PM, Baolin Wang wrote: >> This patch adds one new led trigger that LED device can

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-02 Thread Jacek Anaszewski
Hi Baolin, Thank you for the v14. We'll probably need v15, though :-) I added the comments in the code below. On 10/02/2018 05:43 PM, Baolin Wang wrote: > This patch adds one new led trigger that LED device can configure > the software or hardware pattern and trigger it. > > Consumers can

Re: [PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-02 Thread Jacek Anaszewski
Hi Baolin, Thank you for the v14. We'll probably need v15, though :-) I added the comments in the code below. On 10/02/2018 05:43 PM, Baolin Wang wrote: > This patch adds one new led trigger that LED device can configure > the software or hardware pattern and trigger it. > > Consumers can

[PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-02 Thread Baolin Wang
This patch adds one new led trigger that LED device can configure the software or hardware pattern and trigger it. Consumers can write 'pattern' file to enable the software pattern which alters the brightness for the specified duration with one software timer. Moreover consumers can write

[PATCH v14 1/2] leds: core: Introduce LED pattern trigger

2018-10-02 Thread Baolin Wang
This patch adds one new led trigger that LED device can configure the software or hardware pattern and trigger it. Consumers can write 'pattern' file to enable the software pattern which alters the brightness for the specified duration with one software timer. Moreover consumers can write