Re: [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-18 Thread Chao Fan
On Tue, Dec 18, 2018 at 12:28:48PM +0100, Borislav Petkov wrote: >On Tue, Dec 18, 2018 at 09:27:04AM +0800, Chao Fan wrote: >> The basic conflict is the kernel avoiding KASLR-randomizing into >> hot-removable memory areas. > >And this should be in a prominent place in your commit message to give >a

Re: [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-18 Thread Borislav Petkov
On Tue, Dec 18, 2018 at 09:27:04AM +0800, Chao Fan wrote: > The basic conflict is the kernel avoiding KASLR-randomizing into > hot-removable memory areas. And this should be in a prominent place in your commit message to give an idea *why* you're doing this in the first place. -- Regards/Gruss,

Re: [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-17 Thread Chao Fan
On Mon, Dec 17, 2018 at 06:25:10PM +0100, Ingo Molnar wrote: > >* Chao Fan wrote: > >> Memory information in SRAT is necessary to fix the conflict between >> KASLR and memory-hotremove. >> >> ACPI SRAT (System/Static Resource Affinity Table) shows the details >> about memory ranges, including ran

Re: [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-17 Thread Ingo Molnar
* Thomas Gleixner wrote: > On Mon, 17 Dec 2018, Ingo Molnar wrote: > > * Chao Fan wrote: > > > + val[len] = '\0'; > > > + return (acpi_physical_address)simple_strtoull(val, &e, 16); > > > > 'return' is not a function - no need for the parenthesis. > > It's a typecast which be

Re: [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-17 Thread Thomas Gleixner
On Mon, 17 Dec 2018, Ingo Molnar wrote: > * Chao Fan wrote: > > + val[len] = '\0'; > > + return (acpi_physical_address)simple_strtoull(val, &e, 16); > > 'return' is not a function - no need for the parenthesis. It's a typecast which better has parenthesis

Re: [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-17 Thread Ingo Molnar
* Chao Fan wrote: > Memory information in SRAT is necessary to fix the conflict between > KASLR and memory-hotremove. > > ACPI SRAT (System/Static Resource Affinity Table) shows the details > about memory ranges, including ranges of memory provided by hot-added > memory devices. SRAT is introd

[PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-14 Thread Chao Fan
Memory information in SRAT is necessary to fix the conflict between KASLR and memory-hotremove. ACPI SRAT (System/Static Resource Affinity Table) shows the details about memory ranges, including ranges of memory provided by hot-added memory devices. SRAT is introduced by Root System Description Po