Re: [PATCH v14 13/19] leds: lp55xx: Add multicolor framework support to lp55xx

2019-10-23 Thread Dan Murphy
Jacek On 10/18/19 5:02 PM, Jacek Anaszewski wrote: Dan, I forgot to mention one thing below. On 10/18/19 2:25 PM, Dan Murphy wrote: Add multicolor framework support for the lp55xx family. Signed-off-by: Dan Murphy --- [...] - led->cdev.default_trigger = pdata->led_config[chan].defa

Re: [PATCH v14 13/19] leds: lp55xx: Add multicolor framework support to lp55xx

2019-10-23 Thread Dan Murphy
Jacek On 10/18/19 4:48 PM, Jacek Anaszewski wrote: Dan, On 10/18/19 2:25 PM, Dan Murphy wrote: Add multicolor framework support for the lp55xx family. Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 1 + drivers/leds/leds-lp55xx-common.c | 185 +

Re: [PATCH v14 13/19] leds: lp55xx: Add multicolor framework support to lp55xx

2019-10-22 Thread Jacek Anaszewski
Dan, On 10/22/19 6:37 PM, Dan Murphy wrote: > Jacek > > On 10/18/19 4:56 PM, Jacek Anaszewski wrote: >> On 10/18/19 11:48 PM, Jacek Anaszewski wrote: >>> Dan, >> +    ret = lp5xx_parse_channel_child(child, cfg, i); >>> I went into details of this parsing and finally came up with >>> the code

Re: [PATCH v14 13/19] leds: lp55xx: Add multicolor framework support to lp55xx

2019-10-22 Thread Dan Murphy
Jacek On 10/18/19 4:56 PM, Jacek Anaszewski wrote: On 10/18/19 11:48 PM, Jacek Anaszewski wrote: Dan, + ret = lp5xx_parse_channel_child(child, cfg, i); I went into details of this parsing and finally came up with the code which is a bit greater in size, but IMHO cleaner. Note ch

Re: [PATCH v14 13/19] leds: lp55xx: Add multicolor framework support to lp55xx

2019-10-18 Thread Jacek Anaszewski
Dan, I forgot to mention one thing below. On 10/18/19 2:25 PM, Dan Murphy wrote: > Add multicolor framework support for the lp55xx family. > > Signed-off-by: Dan Murphy > --- [...] > - led->cdev.default_trigger = pdata->led_config[chan].default_trigger; > > if (led->chan_nr >= max_

Re: [PATCH v14 13/19] leds: lp55xx: Add multicolor framework support to lp55xx

2019-10-18 Thread Jacek Anaszewski
On 10/18/19 11:48 PM, Jacek Anaszewski wrote: > Dan, + ret = lp5xx_parse_channel_child(child, cfg, i); > > I went into details of this parsing and finally came up with > the code which is a bit greater in size, but IMHO cleaner. > Note changes in variable naming. It is not even com

Re: [PATCH v14 13/19] leds: lp55xx: Add multicolor framework support to lp55xx

2019-10-18 Thread Jacek Anaszewski
Dan, On 10/18/19 2:25 PM, Dan Murphy wrote: > Add multicolor framework support for the lp55xx family. > > Signed-off-by: Dan Murphy > --- > drivers/leds/Kconfig | 1 + > drivers/leds/leds-lp55xx-common.c | 185 +++--- > drivers/leds/leds-lp55xx-com

[PATCH v14 13/19] leds: lp55xx: Add multicolor framework support to lp55xx

2019-10-18 Thread Dan Murphy
Add multicolor framework support for the lp55xx family. Signed-off-by: Dan Murphy --- drivers/leds/Kconfig | 1 + drivers/leds/leds-lp55xx-common.c | 185 +++--- drivers/leds/leds-lp55xx-common.h | 9 ++ include/linux/platform_data/leds-lp