Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case

2019-02-20 Thread Steven Rostedt
On Wed, 20 Feb 2019 12:45:15 -0600 Tom Zanussi wrote: > > OK, so this has nothing to do with your patch set. I've tested > > everything else, and I'm ready to finally push my tree to linux-next. > > > > I'm thinking that we should get rid of xfail, as it's really > > confusing, > > and I don't

Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case

2019-02-20 Thread Tom Zanussi
On Wed, 2019-02-20 at 13:33 -0500, Steven Rostedt wrote: > On Wed, 20 Feb 2019 12:10:31 -0600 > Tom Zanussi wrote: > > > > > As far as I understand it (there's no other case of an xfail test > > in > > the testsuite, so nothing similar to compare it to), the test > > output is > > correct -

Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case

2019-02-20 Thread Steven Rostedt
On Wed, 20 Feb 2019 12:10:31 -0600 Tom Zanussi wrote: > > As far as I understand it (there's no other case of an xfail test in > the testsuite, so nothing similar to compare it to), the test output is > correct - here we get the expected fail, XFAIL, and not a FAIL as any > test, xfail or

Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case

2019-02-20 Thread Tom Zanussi
Hi Steve, On Wed, 2019-02-20 at 12:56 -0500, Steven Rostedt wrote: > On Wed, 20 Feb 2019 11:38:22 -0600 > Tom Zanussi wrote: > > > Hi Steve, > > > > On Wed, 2019-02-20 at 12:17 -0500, Steven Rostedt wrote: > > > On Wed, 13 Feb 2019 17:42:55 -0600 > > > Tom Zanussi wrote: > > > > > > >

Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case

2019-02-20 Thread Steven Rostedt
On Wed, 20 Feb 2019 11:38:22 -0600 Tom Zanussi wrote: > Hi Steve, > > On Wed, 2019-02-20 at 12:17 -0500, Steven Rostedt wrote: > > On Wed, 13 Feb 2019 17:42:55 -0600 > > Tom Zanussi wrote: > > > > > From: Tom Zanussi > > > > > > Add a test case verifying that basic action combinations

Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case

2019-02-20 Thread Tom Zanussi
Hi Steve, On Wed, 2019-02-20 at 12:17 -0500, Steven Rostedt wrote: > On Wed, 13 Feb 2019 17:42:55 -0600 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > Add a test case verifying that basic action combinations fail as > > expected. > > > > Hi Tom, > > This test appears to fail: > > #

Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case

2019-02-20 Thread Steven Rostedt
On Wed, 13 Feb 2019 17:42:55 -0600 Tom Zanussi wrote: > From: Tom Zanussi > > Add a test case verifying that basic action combinations fail as > expected. > Hi Tom, This test appears to fail: # echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)' >>

Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case

2019-02-15 Thread Steven Rostedt
On Sat, 16 Feb 2019 00:08:14 +0900 Masami Hiramatsu wrote: > Hi Tom, > > On Wed, 13 Feb 2019 17:42:55 -0600 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > Add a test case verifying that basic action combinations fail as > > expected. > > > > Signed-off-by: Tom Zanussi > > This

Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case

2019-02-15 Thread Masami Hiramatsu
Hi Tom, On Wed, 13 Feb 2019 17:42:55 -0600 Tom Zanussi wrote: > From: Tom Zanussi > > Add a test case verifying that basic action combinations fail as > expected. > > Signed-off-by: Tom Zanussi This looks good to me. Acked-by: Masami Hiramatsu Thank you! > --- >

[PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case

2019-02-13 Thread Tom Zanussi
From: Tom Zanussi Add a test case verifying that basic action combinations fail as expected. Signed-off-by: Tom Zanussi --- .../inter-event/trigger-action-hist-xfail.tc | 30 ++ 1 file changed, 30 insertions(+) create mode 100644