Re: [PATCH v16 13/22] mm/lru: introduce TestClearPageLRU

2020-07-19 Thread Alex Shi
在 2020/7/19 下午12:45, Alex Shi 写道: >>> It might make it more readable to pull in the later patch that modifies isolate_lru_pages that has it using TestClearPageLRU. >>> As to this change, It has to do in this patch, since any TestClearPageLRU >>> may >>> cause lru bit miss in the lru

Re: [PATCH v16 13/22] mm/lru: introduce TestClearPageLRU

2020-07-18 Thread Alex Shi
在 2020/7/18 上午2:26, Alexander Duyck 写道: > On Fri, Jul 17, 2020 at 12:46 AM Alex Shi wrote: >> >> >> >> 在 2020/7/17 上午5:12, Alexander Duyck 写道: >>> On Fri, Jul 10, 2020 at 5:59 PM Alex Shi wrote: Combine PageLRU check and ClearPageLRU into a function by new introduced func

Re: [PATCH v16 13/22] mm/lru: introduce TestClearPageLRU

2020-07-17 Thread Alexander Duyck
On Fri, Jul 17, 2020 at 12:46 AM Alex Shi wrote: > > > > 在 2020/7/17 上午5:12, Alexander Duyck 写道: > > On Fri, Jul 10, 2020 at 5:59 PM Alex Shi wrote: > >> > >> Combine PageLRU check and ClearPageLRU into a function by new > >> introduced func TestClearPageLRU. This function will be used as page >

Re: [PATCH v16 13/22] mm/lru: introduce TestClearPageLRU

2020-07-17 Thread Alex Shi
在 2020/7/17 上午5:12, Alexander Duyck 写道: > On Fri, Jul 10, 2020 at 5:59 PM Alex Shi wrote: >> >> Combine PageLRU check and ClearPageLRU into a function by new >> introduced func TestClearPageLRU. This function will be used as page >> isolation precondition to prevent other isolations some where

Re: [PATCH v16 13/22] mm/lru: introduce TestClearPageLRU

2020-07-16 Thread Alexander Duyck
On Fri, Jul 10, 2020 at 5:59 PM Alex Shi wrote: > > Combine PageLRU check and ClearPageLRU into a function by new > introduced func TestClearPageLRU. This function will be used as page > isolation precondition to prevent other isolations some where else. > Then there are may non PageLRU page on

Re: [PATCH v16 13/22] mm/lru: introduce TestClearPageLRU

2020-07-16 Thread Alex Shi
Hi Johannes, The patchset looks good from logical and testing part. Is there any concern for any patches? Thanks Alex 在 2020/7/11 上午8:58, Alex Shi 写道: > Combine PageLRU check and ClearPageLRU into a function by new > introduced func TestClearPageLRU. This function will be used as page >

[PATCH v16 13/22] mm/lru: introduce TestClearPageLRU

2020-07-10 Thread Alex Shi
Combine PageLRU check and ClearPageLRU into a function by new introduced func TestClearPageLRU. This function will be used as page isolation precondition to prevent other isolations some where else. Then there are may non PageLRU page on lru list, need to remove BUG checking accordingly. Hugh