Re: [PATCH v16 16/22] mm/mlock: reorder isolation sequence during munlock

2020-07-21 Thread Alex Shi
在 2020/7/21 下午5:26, Alex Shi 写道: > > > 在 2020/7/21 上午2:51, Alexander Duyck 写道: >>> Look into the __split_huge_page_tail, there is a tiny gap between tail page >>> get PG_mlocked, and it is added into lru list. >>> The TestClearPageLRU could blocked memcg changes of the page from stopping >>>

Re: [PATCH v16 16/22] mm/mlock: reorder isolation sequence during munlock

2020-07-21 Thread Alex Shi
在 2020/7/21 上午2:51, Alexander Duyck 写道: >> Look into the __split_huge_page_tail, there is a tiny gap between tail page >> get PG_mlocked, and it is added into lru list. >> The TestClearPageLRU could blocked memcg changes of the page from stopping >> isolate_lru_page. > I get that there is a gap

Re: [PATCH v16 16/22] mm/mlock: reorder isolation sequence during munlock

2020-07-20 Thread Alexander Duyck
On Sat, Jul 18, 2020 at 8:56 PM Alex Shi wrote: > > > > 在 2020/7/18 上午4:30, Alexander Duyck 写道: > > On Fri, Jul 10, 2020 at 5:59 PM Alex Shi wrote: > >> > >> This patch reorder the isolation steps during munlock, move the lru lock > >> to guard each pages, unfold __munlock_isolate_lru_page func,

Re: [PATCH v16 16/22] mm/mlock: reorder isolation sequence during munlock

2020-07-18 Thread Alex Shi
在 2020/7/18 上午4:30, Alexander Duyck 写道: > On Fri, Jul 10, 2020 at 5:59 PM Alex Shi wrote: >> >> This patch reorder the isolation steps during munlock, move the lru lock >> to guard each pages, unfold __munlock_isolate_lru_page func, to do the >> preparation for lru lock change. >> >>

Re: [PATCH v16 16/22] mm/mlock: reorder isolation sequence during munlock

2020-07-17 Thread Alexander Duyck
On Fri, Jul 10, 2020 at 5:59 PM Alex Shi wrote: > > This patch reorder the isolation steps during munlock, move the lru lock > to guard each pages, unfold __munlock_isolate_lru_page func, to do the > preparation for lru lock change. > > __split_huge_page_refcount doesn't exist, but we still have

[PATCH v16 16/22] mm/mlock: reorder isolation sequence during munlock

2020-07-10 Thread Alex Shi
This patch reorder the isolation steps during munlock, move the lru lock to guard each pages, unfold __munlock_isolate_lru_page func, to do the preparation for lru lock change. __split_huge_page_refcount doesn't exist, but we still have to guard PageMlocked and PageLRU for tail page in