Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-08-01 Thread atull
On Thu, 28 Jul 2016, Trent Piepho wrote: > On Thu, 2016-07-28 at 10:21 -0500, atull wrote: > > > > > > > > This isn't going work if more than one bridge is used. Each bridge has > > > > its own priv and thus priv->l3_remap_value. Each bridge's priv will > > > > have just the bit for it's own

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-08-01 Thread atull
On Thu, 28 Jul 2016, Trent Piepho wrote: > On Thu, 2016-07-28 at 10:21 -0500, atull wrote: > > > > > > > > This isn't going work if more than one bridge is used. Each bridge has > > > > its own priv and thus priv->l3_remap_value. Each bridge's priv will > > > > have just the bit for it's own

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-07-28 Thread Trent Piepho
On Thu, 2016-07-28 at 10:21 -0500, atull wrote: > > > > > > This isn't going work if more than one bridge is used. Each bridge has > > > its own priv and thus priv->l3_remap_value. Each bridge's priv will > > > have just the bit for it's own remap set. The 2nd bridge to be enabled > > > will

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-07-28 Thread Trent Piepho
On Thu, 2016-07-28 at 10:21 -0500, atull wrote: > > > > > > This isn't going work if more than one bridge is used. Each bridge has > > > its own priv and thus priv->l3_remap_value. Each bridge's priv will > > > have just the bit for it's own remap set. The 2nd bridge to be enabled > > > will

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-07-28 Thread atull
On Thu, 28 Jul 2016, Andrea Galbusera wrote: > On Fri, Jun 10, 2016 at 4:18 AM, Trent Piepho wrote: > > On Fri, 2016-02-05 at 15:30 -0600, at...@opensource.altera.com wrote: > >> Supports Altera SOCFPGA bridges: > >> * fpga2sdram > >> * fpga2hps > >> * hps2fpga > >> *

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-07-28 Thread atull
On Thu, 28 Jul 2016, Andrea Galbusera wrote: > On Fri, Jun 10, 2016 at 4:18 AM, Trent Piepho wrote: > > On Fri, 2016-02-05 at 15:30 -0600, at...@opensource.altera.com wrote: > >> Supports Altera SOCFPGA bridges: > >> * fpga2sdram > >> * fpga2hps > >> * hps2fpga > >> * lwhps2fpga > >> > >>

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-07-28 Thread Andrea Galbusera
On Fri, Jun 10, 2016 at 4:18 AM, Trent Piepho wrote: > On Fri, 2016-02-05 at 15:30 -0600, at...@opensource.altera.com wrote: >> Supports Altera SOCFPGA bridges: >> * fpga2sdram >> * fpga2hps >> * hps2fpga >> * lwhps2fpga >> >> Allows enabling/disabling the bridges

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-07-28 Thread Andrea Galbusera
On Fri, Jun 10, 2016 at 4:18 AM, Trent Piepho wrote: > On Fri, 2016-02-05 at 15:30 -0600, at...@opensource.altera.com wrote: >> Supports Altera SOCFPGA bridges: >> * fpga2sdram >> * fpga2hps >> * hps2fpga >> * lwhps2fpga >> >> Allows enabling/disabling the bridges through the FPGA >> Bridge

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-06-14 Thread Trent Piepho
On Mon, 2016-06-13 at 14:35 -0500, atull wrote: > > > + > > > + /* Allow bridge to be visible to L3 masters or not */ > > > + if (priv->remap_mask) { > > > + priv->l3_remap_value |= ALT_L3_REMAP_MPUZERO_MSK; > > > > Doesn't seem like this belongs here. I realize the write-only register >

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-06-14 Thread Trent Piepho
On Mon, 2016-06-13 at 14:35 -0500, atull wrote: > > > + > > > + /* Allow bridge to be visible to L3 masters or not */ > > > + if (priv->remap_mask) { > > > + priv->l3_remap_value |= ALT_L3_REMAP_MPUZERO_MSK; > > > > Doesn't seem like this belongs here. I realize the write-only register >

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-06-13 Thread atull
On Fri, 10 Jun 2016, Trent Piepho wrote: > On Fri, 2016-02-05 at 15:30 -0600, at...@opensource.altera.com wrote: > > Supports Altera SOCFPGA bridges: > > * fpga2sdram > > * fpga2hps > > * hps2fpga > > * lwhps2fpga > > > > Allows enabling/disabling the bridges through the FPGA > > Bridge

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-06-13 Thread atull
On Fri, 10 Jun 2016, Trent Piepho wrote: > On Fri, 2016-02-05 at 15:30 -0600, at...@opensource.altera.com wrote: > > Supports Altera SOCFPGA bridges: > > * fpga2sdram > > * fpga2hps > > * hps2fpga > > * lwhps2fpga > > > > Allows enabling/disabling the bridges through the FPGA > > Bridge

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-06-09 Thread Trent Piepho
On Fri, 2016-02-05 at 15:30 -0600, at...@opensource.altera.com wrote: > Supports Altera SOCFPGA bridges: > * fpga2sdram > * fpga2hps > * hps2fpga > * lwhps2fpga > > Allows enabling/disabling the bridges through the FPGA > Bridge Framework API functions. I'm replying to v16 because it exists

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-06-09 Thread Trent Piepho
On Fri, 2016-02-05 at 15:30 -0600, at...@opensource.altera.com wrote: > Supports Altera SOCFPGA bridges: > * fpga2sdram > * fpga2hps > * hps2fpga > * lwhps2fpga > > Allows enabling/disabling the bridges through the FPGA > Bridge Framework API functions. I'm replying to v16 because it exists

[PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-02-05 Thread atull
From: Alan Tull Supports Altera SOCFPGA bridges: * fpga2sdram * fpga2hps * hps2fpga * lwhps2fpga Allows enabling/disabling the bridges through the FPGA Bridge Framework API functions. The fpga2sdram driver only supports enabling and disabling of the ports that been configured early on.

[PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-02-05 Thread atull
From: Alan Tull Supports Altera SOCFPGA bridges: * fpga2sdram * fpga2hps * hps2fpga * lwhps2fpga Allows enabling/disabling the bridges through the FPGA Bridge Framework API functions. The fpga2sdram driver only supports enabling and disabling of the ports that