Re: [PATCH v17 00/21] per memcg lru lock

>From e2918c8fa741442255a2f12659f95dae94fdfe5d Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Tue, 4 Aug 2020 16:20:02 +0800 Subject: [PATCH 0/3] optimzing following per memcg lru_lock The first 2 patches are code clean up. And the 3rd one is a lru_add optimize. Alex Shi (3): mm/mlock: remove

Re: [PATCH v17 00/21] per memcg lru lock

>From 0696a2a4a8ca5e9bf62f208126ea4af7727d2edc Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Sat, 25 Jul 2020 22:31:03 +0800 Subject: [PATCH 1/3] mm/mlock: remove lru_lock on TestClearPageMlocked in munlock_vma_page In the func munlock_vma_page, the page must be PageLocked as well as pages in sp

Re: [PATCH v17 00/21] per memcg lru lock

>From e2918c8fa741442255a2f12659f95dae94fdfe5d Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Sat, 1 Aug 2020 22:49:31 +0800 Subject: [PATCH 3/3] mm/swap.c: optimizing __pagevec_lru_add lru_lock The current relock will unlock/lock lru_lock with every time lruvec changes, so it would cause frequenc

Re: [PATCH v17 00/21] per memcg lru lock

>From 6f3ac2a72448291a88f50df836d829a23e7df736 Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Sat, 25 Jul 2020 22:52:11 +0800 Subject: [PATCH 2/3] mm/mlock: remove __munlock_isolate_lru_page The func only has one caller, remove it to clean up code and simplify code. Signed-off-by: Alex Shi Cc: K

Re: [PATCH v17 00/21] per memcg lru lock

在 2020/8/3 下午11:07, Michal Hocko 写道: > On Thu 30-07-20 10:16:13, Alex Shi wrote: >> >> >> 在 2020/7/30 上午2:06, Hugh Dickins 写道: >>> On Wed, 29 Jul 2020, Alex Shi wrote: Is there any comments or suggestion for this patchset? Any hints will be very appreciated. >>> >>> Alex: it is no

Re: [PATCH v17 00/21] per memcg lru lock

On Thu 30-07-20 10:16:13, Alex Shi wrote: > > > 在 2020/7/30 上午2:06, Hugh Dickins 写道: > > On Wed, 29 Jul 2020, Alex Shi wrote: > >> > >> Is there any comments or suggestion for this patchset? > >> Any hints will be very appreciated. > > > > Alex: it is now v5.8-rc7, obviously too late for this pa

Re: [PATCH v17 00/21] per memcg lru lock

On Sat, Jul 25, 2020 at 6:00 AM Alex Shi wrote: > > The new version which bases on v5.8-rc6. It includes Hugh Dickins fix in > mm/swap.c and mm/mlock.c fix which Alexander Duyck pointed out, then > removes 'mm/mlock: reorder isolation sequence during munlock' > > Hi Johanness & Hugh & Alexander &

Re: [PATCH v17 00/21] per memcg lru lock

在 2020/7/30 上午2:06, Hugh Dickins 写道: > On Wed, 29 Jul 2020, Alex Shi wrote: >> >> Is there any comments or suggestion for this patchset? >> Any hints will be very appreciated. > > Alex: it is now v5.8-rc7, obviously too late for this patchset to make > v5.9, so I'm currently concentrated on che

Re: [PATCH v17 00/21] per memcg lru lock

On Wed, 29 Jul 2020, Alex Shi wrote: > > Is there any comments or suggestion for this patchset? > Any hints will be very appreciated. Alex: it is now v5.8-rc7, obviously too late for this patchset to make v5.9, so I'm currently concentrated on checking some patches headed for v5.9 (and some bugfi

Re: [PATCH v17 00/21] per memcg lru lock

Is there any comments or suggestion for this patchset? Any hints will be very appreciated. Thanks Alex 在 2020/7/27 下午1:40, Alex Shi 写道: > A standard for new page isolation steps like the following: > 1, get_page(); #pin the page avoid be free > 2, TestClearPageLRU(); #serialize other isolation

Re: [PATCH v17 00/21] per memcg lru lock

A standard for new page isolation steps like the following: 1, get_page(); #pin the page avoid be free 2, TestClearPageLRU(); #serialize other isolation, also memcg change 3, spin_lock on lru_lock; #serialize lru list access The step 2 could be optimzed/replaced in scenarios which page is un

[PATCH v17 00/21] per memcg lru lock

The new version which bases on v5.8-rc6. It includes Hugh Dickins fix in mm/swap.c and mm/mlock.c fix which Alexander Duyck pointed out, then removes 'mm/mlock: reorder isolation sequence during munlock' Hi Johanness & Hugh & Alexander & Willy, Could you like to give a reviewed by since you add