Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-21 Thread Baolin Wang
On 22 December 2016 at 07:47, NeilBrown wrote: > On Wed, Dec 21 2016, Baolin Wang wrote: > >> On 21 December 2016 at 11:48, NeilBrown wrote: >>> On Wed, Dec 21 2016, Baolin Wang wrote: >>> Hi, On 21 December 2016 at 06:07, NeilBrown

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-21 Thread Baolin Wang
On 22 December 2016 at 07:47, NeilBrown wrote: > On Wed, Dec 21 2016, Baolin Wang wrote: > >> On 21 December 2016 at 11:48, NeilBrown wrote: >>> On Wed, Dec 21 2016, Baolin Wang wrote: >>> Hi, On 21 December 2016 at 06:07, NeilBrown wrote: > On Tue, Dec 20 2016, Baolin Wang

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-21 Thread NeilBrown
On Wed, Dec 21 2016, Baolin Wang wrote: > On 21 December 2016 at 11:48, NeilBrown wrote: >> On Wed, Dec 21 2016, Baolin Wang wrote: >> >>> Hi, >>> >>> On 21 December 2016 at 06:07, NeilBrown wrote: On Tue, Dec 20 2016, Baolin Wang wrote: > Hi Neil,

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-21 Thread NeilBrown
On Wed, Dec 21 2016, Baolin Wang wrote: > On 21 December 2016 at 11:48, NeilBrown wrote: >> On Wed, Dec 21 2016, Baolin Wang wrote: >> >>> Hi, >>> >>> On 21 December 2016 at 06:07, NeilBrown wrote: On Tue, Dec 20 2016, Baolin Wang wrote: > Hi Neil, > > On 3 November 2016

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-21 Thread Baolin Wang
On 21 December 2016 at 11:48, NeilBrown wrote: > On Wed, Dec 21 2016, Baolin Wang wrote: > >> Hi, >> >> On 21 December 2016 at 06:07, NeilBrown wrote: >>> On Tue, Dec 20 2016, Baolin Wang wrote: >>> Hi Neil, On 3 November 2016 at 09:25, NeilBrown

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-21 Thread Baolin Wang
On 21 December 2016 at 11:48, NeilBrown wrote: > On Wed, Dec 21 2016, Baolin Wang wrote: > >> Hi, >> >> On 21 December 2016 at 06:07, NeilBrown wrote: >>> On Tue, Dec 20 2016, Baolin Wang wrote: >>> Hi Neil, On 3 November 2016 at 09:25, NeilBrown wrote: > On Tue, Nov 01 2016,

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-20 Thread NeilBrown
On Wed, Dec 21 2016, Baolin Wang wrote: > Hi, > > On 21 December 2016 at 06:07, NeilBrown wrote: >> On Tue, Dec 20 2016, Baolin Wang wrote: >> >>> Hi Neil, >>> >>> On 3 November 2016 at 09:25, NeilBrown wrote: On Tue, Nov 01 2016, Baolin Wang wrote:

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-20 Thread NeilBrown
On Wed, Dec 21 2016, Baolin Wang wrote: > Hi, > > On 21 December 2016 at 06:07, NeilBrown wrote: >> On Tue, Dec 20 2016, Baolin Wang wrote: >> >>> Hi Neil, >>> >>> On 3 November 2016 at 09:25, NeilBrown wrote: On Tue, Nov 01 2016, Baolin Wang wrote: >> So I won't be

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-20 Thread Baolin Wang
Hi, On 21 December 2016 at 06:07, NeilBrown wrote: > On Tue, Dec 20 2016, Baolin Wang wrote: > >> Hi Neil, >> >> On 3 November 2016 at 09:25, NeilBrown wrote: >>> On Tue, Nov 01 2016, Baolin Wang wrote: >>> >>> > So I won't be responding on this topic any

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-20 Thread Baolin Wang
Hi, On 21 December 2016 at 06:07, NeilBrown wrote: > On Tue, Dec 20 2016, Baolin Wang wrote: > >> Hi Neil, >> >> On 3 November 2016 at 09:25, NeilBrown wrote: >>> On Tue, Nov 01 2016, Baolin Wang wrote: >>> >>> > So I won't be responding on this topic any further until I see a genuine >

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-20 Thread NeilBrown
On Tue, Dec 20 2016, Baolin Wang wrote: > Hi Neil, > > On 3 November 2016 at 09:25, NeilBrown wrote: >> On Tue, Nov 01 2016, Baolin Wang wrote: >> >> So I won't be responding on this topic any further until I see a genuine attempt to understand and resolve the

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-20 Thread NeilBrown
On Tue, Dec 20 2016, Baolin Wang wrote: > Hi Neil, > > On 3 November 2016 at 09:25, NeilBrown wrote: >> On Tue, Nov 01 2016, Baolin Wang wrote: >> >> So I won't be responding on this topic any further until I see a genuine attempt to understand and resolve the inconsistencies with

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-19 Thread Baolin Wang
Hi Neil, On 3 November 2016 at 09:25, NeilBrown wrote: > On Tue, Nov 01 2016, Baolin Wang wrote: > > >>> So I won't be responding on this topic any further until I see a genuine >>> attempt to understand and resolve the inconsistencies with >>> usb_register_notifier(). >> >> Any

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-12-19 Thread Baolin Wang
Hi Neil, On 3 November 2016 at 09:25, NeilBrown wrote: > On Tue, Nov 01 2016, Baolin Wang wrote: > > >>> So I won't be responding on this topic any further until I see a genuine >>> attempt to understand and resolve the inconsistencies with >>> usb_register_notifier(). >> >> Any better solution?

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-27 Thread Baolin Wang
On 25 November 2016 at 21:00, Mark Brown wrote: > On Tue, Nov 22, 2016 at 09:40:07AM +1100, NeilBrown wrote: > >> I agree that the question of where the responsibility for information >> aggregation lies is open for discussion. If fact all details on how >> things should work

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-27 Thread Baolin Wang
On 25 November 2016 at 21:00, Mark Brown wrote: > On Tue, Nov 22, 2016 at 09:40:07AM +1100, NeilBrown wrote: > >> I agree that the question of where the responsibility for information >> aggregation lies is open for discussion. If fact all details on how >> things should work are always open for

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-25 Thread NeilBrown
On Sat, Nov 26 2016, Mark Brown wrote: > [ Unknown signature status ] > On Tue, Nov 22, 2016 at 09:40:07AM +1100, NeilBrown wrote: > >> I agree that the question of where the responsibility for information >> aggregation lies is open for discussion. If fact all details on how >> things should

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-25 Thread NeilBrown
On Sat, Nov 26 2016, Mark Brown wrote: > [ Unknown signature status ] > On Tue, Nov 22, 2016 at 09:40:07AM +1100, NeilBrown wrote: > >> I agree that the question of where the responsibility for information >> aggregation lies is open for discussion. If fact all details on how >> things should

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-25 Thread Mark Brown
On Tue, Nov 22, 2016 at 09:40:07AM +1100, NeilBrown wrote: > I agree that the question of where the responsibility for information > aggregation lies is open for discussion. If fact all details on how > things should work are always open for discussion. > I don't agree that this is the main

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-25 Thread Mark Brown
On Tue, Nov 22, 2016 at 09:40:07AM +1100, NeilBrown wrote: > I agree that the question of where the responsibility for information > aggregation lies is open for discussion. If fact all details on how > things should work are always open for discussion. > I don't agree that this is the main

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-21 Thread NeilBrown
On Tue, Nov 22 2016, Mark Brown wrote: > [ Unknown signature status ] > On Thu, Nov 17, 2016 at 05:46:13PM +1100, NeilBrown wrote: >> On Thu, Nov 17 2016, Mark Brown wrote: > >> > To me that's pretty much what's being done here, the code just happens >> > to sit in USB instead but fundamentally

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-21 Thread NeilBrown
On Tue, Nov 22 2016, Mark Brown wrote: > [ Unknown signature status ] > On Thu, Nov 17, 2016 at 05:46:13PM +1100, NeilBrown wrote: >> On Thu, Nov 17 2016, Mark Brown wrote: > >> > To me that's pretty much what's being done here, the code just happens >> > to sit in USB instead but fundamentally

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-21 Thread Mark Brown
On Thu, Nov 17, 2016 at 05:46:13PM +1100, NeilBrown wrote: > On Thu, Nov 17 2016, Mark Brown wrote: > > To me that's pretty much what's being done here, the code just happens > > to sit in USB instead but fundamentally it's just a blob of helper code, > > you could replace the notifier with a

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-21 Thread Mark Brown
On Thu, Nov 17, 2016 at 05:46:13PM +1100, NeilBrown wrote: > On Thu, Nov 17 2016, Mark Brown wrote: > > To me that's pretty much what's being done here, the code just happens > > to sit in USB instead but fundamentally it's just a blob of helper code, > > you could replace the notifier with a

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-16 Thread NeilBrown
On Thu, Nov 17 2016, Mark Brown wrote: > [ Unknown signature status ] > On Tue, Nov 15, 2016 at 08:35:13AM +1100, NeilBrown wrote: >> On Mon, Nov 14 2016, Mark Brown wrote: > >> > Conflating the two seems like the whole point here. We're looking for >> > something that sits between the power

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-16 Thread NeilBrown
On Thu, Nov 17 2016, Mark Brown wrote: > [ Unknown signature status ] > On Tue, Nov 15, 2016 at 08:35:13AM +1100, NeilBrown wrote: >> On Mon, Nov 14 2016, Mark Brown wrote: > >> > Conflating the two seems like the whole point here. We're looking for >> > something that sits between the power

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-16 Thread Mark Brown
On Tue, Nov 15, 2016 at 08:35:13AM +1100, NeilBrown wrote: > On Mon, Nov 14 2016, Mark Brown wrote: > > Conflating the two seems like the whole point here. We're looking for > > something that sits between the power supply code and the USB code and > > tells the power supply code what it's

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-16 Thread Mark Brown
On Tue, Nov 15, 2016 at 08:35:13AM +1100, NeilBrown wrote: > On Mon, Nov 14 2016, Mark Brown wrote: > > Conflating the two seems like the whole point here. We're looking for > > something that sits between the power supply code and the USB code and > > tells the power supply code what it's

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-14 Thread Peter Chen
On Tue, Nov 15, 2016 at 08:35:13AM +1100, NeilBrown wrote: > On Mon, Nov 14 2016, Mark Brown wrote: > > > On Mon, Nov 14, 2016 at 03:21:13PM +1100, NeilBrown wrote: > >> On Thu, Nov 10 2016, Baolin Wang wrote: > > > >> > Fourth, we need integrate all charger plugin/out > >> > event in one

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-14 Thread Peter Chen
On Tue, Nov 15, 2016 at 08:35:13AM +1100, NeilBrown wrote: > On Mon, Nov 14 2016, Mark Brown wrote: > > > On Mon, Nov 14, 2016 at 03:21:13PM +1100, NeilBrown wrote: > >> On Thu, Nov 10 2016, Baolin Wang wrote: > > > >> > Fourth, we need integrate all charger plugin/out > >> > event in one

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-14 Thread NeilBrown
On Mon, Nov 14 2016, Mark Brown wrote: > On Mon, Nov 14, 2016 at 03:21:13PM +1100, NeilBrown wrote: >> On Thu, Nov 10 2016, Baolin Wang wrote: > >> > Fourth, we need integrate all charger plugin/out >> > event in one framework, not from extcon, maybe type-c in future. > >> Why not extcon? Given

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-14 Thread NeilBrown
On Mon, Nov 14 2016, Mark Brown wrote: > On Mon, Nov 14, 2016 at 03:21:13PM +1100, NeilBrown wrote: >> On Thu, Nov 10 2016, Baolin Wang wrote: > >> > Fourth, we need integrate all charger plugin/out >> > event in one framework, not from extcon, maybe type-c in future. > >> Why not extcon? Given

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-14 Thread Baolin Wang
On 14 November 2016 at 12:21, NeilBrown wrote: > On Thu, Nov 10 2016, Baolin Wang wrote: > >> Hi >> >> On 8 November 2016 at 04:36, NeilBrown wrote: >>> On Mon, Nov 07 2016, Baolin Wang wrote: >>> On 3 November 2016 at 09:25, NeilBrown wrote:

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-14 Thread Baolin Wang
On 14 November 2016 at 12:21, NeilBrown wrote: > On Thu, Nov 10 2016, Baolin Wang wrote: > >> Hi >> >> On 8 November 2016 at 04:36, NeilBrown wrote: >>> On Mon, Nov 07 2016, Baolin Wang wrote: >>> On 3 November 2016 at 09:25, NeilBrown wrote: > On Tue, Nov 01 2016, Baolin Wang wrote:

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-14 Thread Mark Brown
On Mon, Nov 14, 2016 at 03:21:13PM +1100, NeilBrown wrote: > On Thu, Nov 10 2016, Baolin Wang wrote: > > Fourth, we need integrate all charger plugin/out > > event in one framework, not from extcon, maybe type-c in future. > Why not extcon? Given that a charger is connected by an external >

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-14 Thread Mark Brown
On Mon, Nov 14, 2016 at 03:21:13PM +1100, NeilBrown wrote: > On Thu, Nov 10 2016, Baolin Wang wrote: > > Fourth, we need integrate all charger plugin/out > > event in one framework, not from extcon, maybe type-c in future. > Why not extcon? Given that a charger is connected by an external >

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-13 Thread NeilBrown
On Thu, Nov 10 2016, Baolin Wang wrote: > Hi > > On 8 November 2016 at 04:36, NeilBrown wrote: >> On Mon, Nov 07 2016, Baolin Wang wrote: >> >>> On 3 November 2016 at 09:25, NeilBrown wrote: On Tue, Nov 01 2016, Baolin Wang wrote: >>> >>> I agree with your

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-13 Thread NeilBrown
On Thu, Nov 10 2016, Baolin Wang wrote: > Hi > > On 8 November 2016 at 04:36, NeilBrown wrote: >> On Mon, Nov 07 2016, Baolin Wang wrote: >> >>> On 3 November 2016 at 09:25, NeilBrown wrote: On Tue, Nov 01 2016, Baolin Wang wrote: >>> >>> I agree with your most opinions, but these are

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-10 Thread Baolin Wang
Hi On 8 November 2016 at 04:36, NeilBrown wrote: > On Mon, Nov 07 2016, Baolin Wang wrote: > >> On 3 November 2016 at 09:25, NeilBrown wrote: >>> On Tue, Nov 01 2016, Baolin Wang wrote: >> >> I agree with your most opinions, but these are optimization. > > I see

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-10 Thread Baolin Wang
Hi On 8 November 2016 at 04:36, NeilBrown wrote: > On Mon, Nov 07 2016, Baolin Wang wrote: > >> On 3 November 2016 at 09:25, NeilBrown wrote: >>> On Tue, Nov 01 2016, Baolin Wang wrote: >> >> I agree with your most opinions, but these are optimization. > > I see them as bug fixes, not

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-08 Thread Peter Chen
On Wed, Nov 09, 2016 at 07:38:36AM +1100, NeilBrown wrote: > On Tue, Nov 08 2016, Peter Chen wrote: > > > On Thu, Nov 03, 2016 at 12:25:42PM +1100, NeilBrown wrote: > >> > >> > >> > >> 2/ Change all usb phys to register an extcon and to send appropriate > >>notifications. Many already do,

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-08 Thread Peter Chen
On Wed, Nov 09, 2016 at 07:38:36AM +1100, NeilBrown wrote: > On Tue, Nov 08 2016, Peter Chen wrote: > > > On Thu, Nov 03, 2016 at 12:25:42PM +1100, NeilBrown wrote: > >> > >> > >> > >> 2/ Change all usb phys to register an extcon and to send appropriate > >>notifications. Many already do,

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-08 Thread NeilBrown
On Tue, Nov 08 2016, Peter Chen wrote: > On Thu, Nov 03, 2016 at 12:25:42PM +1100, NeilBrown wrote: >> >> >> >> 2/ Change all usb phys to register an extcon and to send appropriate >>notifications. Many already do, but I don't think it is universal. >>It is probable that the extcon

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-08 Thread NeilBrown
On Tue, Nov 08 2016, Peter Chen wrote: > On Thu, Nov 03, 2016 at 12:25:42PM +1100, NeilBrown wrote: >> >> >> >> 2/ Change all usb phys to register an extcon and to send appropriate >>notifications. Many already do, but I don't think it is universal. >>It is probable that the extcon

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-08 Thread Peter Chen
On Thu, Nov 03, 2016 at 12:25:42PM +1100, NeilBrown wrote: > On Tue, Nov 01 2016, Baolin Wang wrote: > > > >> So I won't be responding on this topic any further until I see a genuine > >> attempt to understand and resolve the inconsistencies with > >> usb_register_notifier(). > > > > Any better

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-08 Thread Peter Chen
On Thu, Nov 03, 2016 at 12:25:42PM +1100, NeilBrown wrote: > On Tue, Nov 01 2016, Baolin Wang wrote: > > > >> So I won't be responding on this topic any further until I see a genuine > >> attempt to understand and resolve the inconsistencies with > >> usb_register_notifier(). > > > > Any better

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-07 Thread NeilBrown
On Mon, Nov 07 2016, Baolin Wang wrote: > On 3 November 2016 at 09:25, NeilBrown wrote: >> On Tue, Nov 01 2016, Baolin Wang wrote: > > I agree with your most opinions, but these are optimization. I see them as bug fixes, not optimizations. >

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-07 Thread NeilBrown
On Mon, Nov 07 2016, Baolin Wang wrote: > On 3 November 2016 at 09:25, NeilBrown wrote: >> On Tue, Nov 01 2016, Baolin Wang wrote: > > I agree with your most opinions, but these are optimization. I see them as bug fixes, not optimizations. >

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-07 Thread Baolin Wang
On 3 November 2016 at 09:25, NeilBrown wrote: > On Tue, Nov 01 2016, Baolin Wang wrote: > > >>> So I won't be responding on this topic any further until I see a genuine >>> attempt to understand and resolve the inconsistencies with >>> usb_register_notifier(). >> >> Any better

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-07 Thread Baolin Wang
On 3 November 2016 at 09:25, NeilBrown wrote: > On Tue, Nov 01 2016, Baolin Wang wrote: > > >>> So I won't be responding on this topic any further until I see a genuine >>> attempt to understand and resolve the inconsistencies with >>> usb_register_notifier(). >> >> Any better solution? > > I'm

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-02 Thread NeilBrown
On Tue, Nov 01 2016, Baolin Wang wrote: >> So I won't be responding on this topic any further until I see a genuine >> attempt to understand and resolve the inconsistencies with >> usb_register_notifier(). > > Any better solution? I'm not sure exactly what you are asking, so I'll assume you are

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-02 Thread NeilBrown
On Tue, Nov 01 2016, Baolin Wang wrote: >> So I won't be responding on this topic any further until I see a genuine >> attempt to understand and resolve the inconsistencies with >> usb_register_notifier(). > > Any better solution? I'm not sure exactly what you are asking, so I'll assume you are

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-01 Thread Baolin Wang
Hi, On 31 October 2016 at 08:00, NeilBrown wrote: > On Fri, Oct 28 2016, Baolin Wang wrote: > >>> >>> 3/ usb_charger_notify_state() does nothing if the state doesn't change. >>> When the extcon detects an SDP, it will be called to set the state >>> to USB_CHARGER_PRESENT.

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-01 Thread Baolin Wang
Hi, On 31 October 2016 at 08:00, NeilBrown wrote: > On Fri, Oct 28 2016, Baolin Wang wrote: > >>> >>> 3/ usb_charger_notify_state() does nothing if the state doesn't change. >>> When the extcon detects an SDP, it will be called to set the state >>> to USB_CHARGER_PRESENT. The value of

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-31 Thread Baolin Wang
On 29 October 2016 at 01:03, Mark Brown wrote: > On Fri, Oct 28, 2016 at 08:51:41PM +0800, Baolin Wang wrote: >> On 28 October 2016 at 06:00, NeilBrown wrote: > >> > 1/ I think we agreed that it doesn't make sense for there to be >> > two chargers registered

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-31 Thread Baolin Wang
On 29 October 2016 at 01:03, Mark Brown wrote: > On Fri, Oct 28, 2016 at 08:51:41PM +0800, Baolin Wang wrote: >> On 28 October 2016 at 06:00, NeilBrown wrote: > >> > 1/ I think we agreed that it doesn't make sense for there to be >> > two chargers registered in a system. > >> Yes, until now...

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-30 Thread NeilBrown
On Fri, Oct 28 2016, Baolin Wang wrote: >> >> 3/ usb_charger_notify_state() does nothing if the state doesn't change. >> When the extcon detects an SDP, it will be called to set the state >> to USB_CHARGER_PRESENT. The value of cur.sdp_max will be whatever >> it happened to be before,

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-30 Thread NeilBrown
On Fri, Oct 28 2016, Baolin Wang wrote: >> >> 3/ usb_charger_notify_state() does nothing if the state doesn't change. >> When the extcon detects an SDP, it will be called to set the state >> to USB_CHARGER_PRESENT. The value of cur.sdp_max will be whatever >> it happened to be before,

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-28 Thread Mark Brown
On Fri, Oct 28, 2016 at 08:51:41PM +0800, Baolin Wang wrote: > On 28 October 2016 at 06:00, NeilBrown wrote: > > 1/ I think we agreed that it doesn't make sense for there to be > > two chargers registered in a system. > Yes, until now... > > However usb_charger_register()

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-28 Thread Mark Brown
On Fri, Oct 28, 2016 at 08:51:41PM +0800, Baolin Wang wrote: > On 28 October 2016 at 06:00, NeilBrown wrote: > > 1/ I think we agreed that it doesn't make sense for there to be > > two chargers registered in a system. > Yes, until now... > > However usb_charger_register() still allows that,

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-28 Thread Baolin Wang
Hi, On 28 October 2016 at 06:00, NeilBrown wrote: > On Thu, Oct 27 2016, Baolin Wang wrote: > >> Hi Felipe, >> >> On 19 October 2016 at 10:37, Baolin Wang wrote: >>> Currently the Linux kernel does not provide any standard integration of this >>> feature

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-28 Thread Baolin Wang
Hi, On 28 October 2016 at 06:00, NeilBrown wrote: > On Thu, Oct 27 2016, Baolin Wang wrote: > >> Hi Felipe, >> >> On 19 October 2016 at 10:37, Baolin Wang wrote: >>> Currently the Linux kernel does not provide any standard integration of this >>> feature that integrates the USB subsystem with

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-27 Thread NeilBrown
On Thu, Oct 27 2016, Baolin Wang wrote: > Hi Felipe, > > On 19 October 2016 at 10:37, Baolin Wang wrote: >> Currently the Linux kernel does not provide any standard integration of this >> feature that integrates the USB subsystem with the system power regulation >>

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-27 Thread NeilBrown
On Thu, Oct 27 2016, Baolin Wang wrote: > Hi Felipe, > > On 19 October 2016 at 10:37, Baolin Wang wrote: >> Currently the Linux kernel does not provide any standard integration of this >> feature that integrates the USB subsystem with the system power regulation >> provided by PMICs meaning that

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-27 Thread Baolin Wang
Hi Felipe, On 19 October 2016 at 10:37, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-27 Thread Baolin Wang
Hi Felipe, On 19 October 2016 at 10:37, Baolin Wang wrote: > Currently the Linux kernel does not provide any standard integration of this > feature that integrates the USB subsystem with the system power regulation > provided by PMICs meaning that either vendors must add this in their kernels >

[PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-18 Thread Baolin Wang
Currently the Linux kernel does not provide any standard integration of this feature that integrates the USB subsystem with the system power regulation provided by PMICs meaning that either vendors must add this in their kernels or USB gadget devices based on Linux (such as mobile phones) may not

[PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-10-18 Thread Baolin Wang
Currently the Linux kernel does not provide any standard integration of this feature that integrates the USB subsystem with the system power regulation provided by PMICs meaning that either vendors must add this in their kernels or USB gadget devices based on Linux (such as mobile phones) may not