Re: [PATCH v2][RESENT] dma: add R-Car Audio DMAC peri peri driver

2014-03-10 Thread Shevchenko, Andriy
On Sun, 2014-03-09 at 18:34 -0700, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Add support Audio DMAC peri peri driver > for Renesas R-Car Gen2 SoC, using 'shdma-base' > DMA driver framework. Few comments below. > > Signed-off-by: Kuninori Morimoto > --- > resent > > - add missin

Re: [PATCH v2][RESENT] dma: add R-Car Audio DMAC peri peri driver

2014-03-09 Thread Kuninori Morimoto
Hi Joe > > diff --git a/drivers/dma/sh/rcar-audmapp.c b/drivers/dma/sh/rcar-audmapp.c > [] > > +static int audmapp_chan_probe(struct platform_device *pdev, > > + struct audmapp_device *audev, int id) > > +{ > [] > > + auchan = devm_kzalloc(dev, sizeof(struct audmapp_chan

Re: [PATCH v2][RESENT] dma: add R-Car Audio DMAC peri peri driver

2014-03-09 Thread Joe Perches
On Sun, 2014-03-09 at 18:34 -0700, Kuninori Morimoto wrote: > Add support Audio DMAC peri peri driver > for Renesas R-Car Gen2 SoC, using 'shdma-base' > DMA driver framework. Trivial notes: > diff --git a/drivers/dma/sh/rcar-audmapp.c b/drivers/dma/sh/rcar-audmapp.c [] > +static int audmapp_chan_

[PATCH v2][RESENT] dma: add R-Car Audio DMAC peri peri driver

2014-03-09 Thread Kuninori Morimoto
From: Kuninori Morimoto Add support Audio DMAC peri peri driver for Renesas R-Car Gen2 SoC, using 'shdma-base' DMA driver framework. Signed-off-by: Kuninori Morimoto --- resent - add missing "dmaeng...@vger.kernel.org" v1 -> v2 - run scripts/checkpatch.pl - ecchange length settings on aud