Re: [PATCH v2][RFC] tracing/context-tracking: Add preempt_schedule_context() for tracing

2013-06-06 Thread Steven Rostedt
On Thu, 2013-06-06 at 12:07 +0200, Peter Zijlstra wrote: > > Are you OK with this? > > Yep, applied. Ah, so you'll take it. Great! I'll drop it from my queue. Thanks, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vge

Re: [PATCH v2][RFC] tracing/context-tracking: Add preempt_schedule_context() for tracing

2013-06-06 Thread Peter Zijlstra
On Wed, Jun 05, 2013 at 10:49:48PM -0400, Steven Rostedt wrote: > Peter, > > Are you fine with this answer, or do you still believe I should put it > into sched/core.c? Its ok I suppose. I just had to wrap my head around this context_tracking muck; first time I ever looked at it. > I switched it

Re: [PATCH v2][RFC] tracing/context-tracking: Add preempt_schedule_context() for tracing

2013-06-05 Thread Steven Rostedt
On Wed, 2013-06-05 at 09:41 -0400, Steven Rostedt wrote: > > > > If preempt_enable_notrace() is the only user, why does this live in > > kernel/context_tracking.c and not in kernel/sched/core.c? > > Then we would need to add #ifdef CONFIG_CONTEXT_TRACKING around it too. > As we have in preempt.h:

Re: [PATCH v2][RFC] tracing/context-tracking: Add preempt_schedule_context() for tracing

2013-06-05 Thread Steven Rostedt
On Wed, 2013-06-05 at 13:45 +0200, Peter Zijlstra wrote: > On Tue, Jun 04, 2013 at 10:16:56AM -0400, Steven Rostedt wrote: > > index 65349f0..73b89d9 100644 > > --- a/kernel/context_tracking.c > > +++ b/kernel/context_tracking.c > > @@ -71,6 +71,46 @@ void user_enter(void) > > local_irq_restore

Re: [PATCH v2][RFC] tracing/context-tracking: Add preempt_schedule_context() for tracing

2013-06-05 Thread Peter Zijlstra
On Tue, Jun 04, 2013 at 10:16:56AM -0400, Steven Rostedt wrote: > index 65349f0..73b89d9 100644 > --- a/kernel/context_tracking.c > +++ b/kernel/context_tracking.c > @@ -71,6 +71,46 @@ void user_enter(void) > local_irq_restore(flags); > } > > +#ifdef CONFIG_PREEMPT > +/** > + * preempt_sch

Re: [PATCH v2][RFC] tracing/context-tracking: Add preempt_schedule_context() for tracing

2013-06-04 Thread Steven Rostedt
On Tue, 2013-06-04 at 14:27 +0200, Frederic Weisbecker wrote: > On Fri, May 31, 2013 at 09:30:18PM -0400, Steven Rostedt wrote: > > diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c > > index 65349f0..15c9f2e 100644 > > --- a/kernel/context_tracking.c > > +++ b/kernel/context_track

Re: [PATCH v2][RFC] tracing/context-tracking: Add preempt_schedule_context() for tracing

2013-06-04 Thread Frederic Weisbecker
On Tue, Jun 04, 2013 at 08:16:29AM -0400, Steven Rostedt wrote: > On Tue, 2013-06-04 at 14:09 +0200, Frederic Weisbecker wrote: > > > > > +/** > > > + * preempt_schedule_context - preempt_schedule called by tracing > > > + * > > > + * The tracing infrastructure uses preempt_enable_notrace to prev

Re: [PATCH v2][RFC] tracing/context-tracking: Add preempt_schedule_context() for tracing

2013-06-04 Thread Frederic Weisbecker
On Fri, May 31, 2013 at 09:30:18PM -0400, Steven Rostedt wrote: > diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c > index 65349f0..15c9f2e 100644 > --- a/kernel/context_tracking.c > +++ b/kernel/context_tracking.c > @@ -71,6 +71,44 @@ void user_enter(void) > local_irq_resto

Re: [PATCH v2][RFC] tracing/context-tracking: Add preempt_schedule_context() for tracing

2013-06-04 Thread Steven Rostedt
On Tue, 2013-06-04 at 14:09 +0200, Frederic Weisbecker wrote: > > > +/** > > + * preempt_schedule_context - preempt_schedule called by tracing > > + * > > + * The tracing infrastructure uses preempt_enable_notrace to prevent > > + * recursion and tracing preempt enabling caused by the tracing > >

Re: [PATCH v2][RFC] tracing/context-tracking: Add preempt_schedule_context() for tracing

2013-06-04 Thread Frederic Weisbecker
On Fri, May 31, 2013 at 09:30:18PM -0400, Steven Rostedt wrote: > Dave Jones hit the following bug report: > > === > [ INFO: suspicious RCU usage. ] > 3.10.0-rc2+ #1 Not tainted > --- > include/linux/rcupdate.h:771 rcu_read_lock() used i

[PATCH v2][RFC] tracing/context-tracking: Add preempt_schedule_context() for tracing

2013-05-31 Thread Steven Rostedt
Dave Jones hit the following bug report: === [ INFO: suspicious RCU usage. ] 3.10.0-rc2+ #1 Not tainted --- include/linux/rcupdate.h:771 rcu_read_lock() used illegally while idle! other info that might help us debug this: RCU used ille