Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-05 Thread Rafael J. Wysocki
On Monday, February 4, 2019 12:05:10 PM CET Thierry Reding wrote: > > --FCuugMFkClbJLl1L > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Mon, Feb 04, 2019 at 09:53:32AM +, Jon Hunter wrote: > >=20 > >=20 > > On 04

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-05 Thread Rafael J. Wysocki
On Monday, February 4, 2019 11:04:50 AM CET Jon Hunter wrote: > > On 04/02/2019 08:16, Sameer Pujar wrote: > > ... > > > Objective is to have things working with or without CONFIG_PM enabled. > > From previous comments and discussions it appears that there is mixed > > response > > for calling h

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Dmitry Osipenko
04.02.2019 19:17, Thierry Reding пишет: > On Mon, Feb 04, 2019 at 05:28:23PM +0300, Dmitry Osipenko wrote: >> 04.02.2019 17:00, Thierry Reding пишет: >>> On Mon, Feb 04, 2019 at 03:03:49PM +0300, Dmitry Osipenko wrote: 04.02.2019 14:05, Thierry Reding пишет: > On Mon, Feb 04, 2019 at 09:53

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 05:28:23PM +0300, Dmitry Osipenko wrote: > 04.02.2019 17:00, Thierry Reding пишет: > > On Mon, Feb 04, 2019 at 03:03:49PM +0300, Dmitry Osipenko wrote: > >> 04.02.2019 14:05, Thierry Reding пишет: > >>> On Mon, Feb 04, 2019 at 09:53:32AM +, Jon Hunter wrote: > > >>>

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Dmitry Osipenko
04.02.2019 17:00, Thierry Reding пишет: > On Mon, Feb 04, 2019 at 03:03:49PM +0300, Dmitry Osipenko wrote: >> 04.02.2019 14:05, Thierry Reding пишет: >>> On Mon, Feb 04, 2019 at 09:53:32AM +, Jon Hunter wrote: On 04/02/2019 08:45, Thierry Reding wrote: ... > Th

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 03:03:49PM +0300, Dmitry Osipenko wrote: > 04.02.2019 14:05, Thierry Reding пишет: > > On Mon, Feb 04, 2019 at 09:53:32AM +, Jon Hunter wrote: > >> > >> > >> On 04/02/2019 08:45, Thierry Reding wrote: > >> > >> ... > >> > >>> The idea was, as I was saying below, to reuse

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Dmitry Osipenko
04.02.2019 14:05, Thierry Reding пишет: > On Mon, Feb 04, 2019 at 09:53:32AM +, Jon Hunter wrote: >> >> >> On 04/02/2019 08:45, Thierry Reding wrote: >> >> ... >> >>> The idea was, as I was saying below, to reuse dev_pm_ops even if >>> !CONFIG_PM. So pm_runtime_enable() could be something like

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 09:53:32AM +, Jon Hunter wrote: > > > On 04/02/2019 08:45, Thierry Reding wrote: > > ... > > > The idea was, as I was saying below, to reuse dev_pm_ops even if > > !CONFIG_PM. So pm_runtime_enable() could be something like this: > > > > pm_runtime_enable(dev) >

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Takashi Iwai
On Mon, 04 Feb 2019 11:04:50 +0100, Jon Hunter wrote: > > > On 04/02/2019 08:16, Sameer Pujar wrote: > > ... > > > Objective is to have things working with or without CONFIG_PM enabled. > > From previous comments and discussions it appears that there is mixed > > response > > for calling hda_te

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Jon Hunter
On 04/02/2019 08:16, Sameer Pujar wrote: ... > Objective is to have things working with or without CONFIG_PM enabled. > From previous comments and discussions it appears that there is mixed > response > for calling hda_tegra_runtime_resume() or runtime PM APIs in probe() > call. Need > to have

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Jon Hunter
On 04/02/2019 08:45, Thierry Reding wrote: ... > The idea was, as I was saying below, to reuse dev_pm_ops even if > !CONFIG_PM. So pm_runtime_enable() could be something like this: > > pm_runtime_enable(dev) > { > if (!CONFIG_PM) > if (dev->pm_o

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Thierry Reding
On Mon, Feb 04, 2019 at 01:46:20PM +0530, Sameer Pujar wrote: > > On 2/1/2019 4:54 AM, Rafael J. Wysocki wrote: > > On Thursday, January 31, 2019 3:30:24 PM CET Thierry Reding wrote: > > > --Pk/CTwBz1VvfPIDp > > > Content-Type: text/plain; charset=us-ascii > > > Content-Disposition: inline > > > C

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Thierry Reding
On Fri, Feb 01, 2019 at 12:24:31AM +0100, Rafael J. Wysocki wrote: > On Thursday, January 31, 2019 3:30:24 PM CET Thierry Reding wrote: > > > > --Pk/CTwBz1VvfPIDp > > Content-Type: text/plain; charset=us-ascii > > Content-Disposition: inline > > Content-Transfer-Encoding: quoted-printable > > > >

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-02-04 Thread Sameer Pujar
On 2/1/2019 4:54 AM, Rafael J. Wysocki wrote: On Thursday, January 31, 2019 3:30:24 PM CET Thierry Reding wrote: --Pk/CTwBz1VvfPIDp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 31, 2019 at 01:10:01PM +0100, Rafa

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-31 Thread Rafael J. Wysocki
On Thursday, January 31, 2019 3:30:24 PM CET Thierry Reding wrote: > > --Pk/CTwBz1VvfPIDp > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Thu, Jan 31, 2019 at 01:10:01PM +0100, Rafael J. Wysocki wrote: > > On Thu, Jan

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-31 Thread Thierry Reding
On Thu, Jan 31, 2019 at 01:10:01PM +0100, Rafael J. Wysocki wrote: > On Thu, Jan 31, 2019 at 12:59 PM Takashi Iwai wrote: > > > > On Thu, 31 Jan 2019 12:46:54 +0100, > > Rafael J. Wysocki wrote: > > > > > > On Thu, Jan 31, 2019 at 12:21 PM Takashi Iwai wrote: > > > > > > > > On Thu, 31 Jan 2019 1

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-31 Thread Sameer Pujar
On 1/31/2019 5:40 PM, Rafael J. Wysocki wrote: On Thu, Jan 31, 2019 at 12:59 PM Takashi Iwai wrote: On Thu, 31 Jan 2019 12:46:54 +0100, Rafael J. Wysocki wrote: On Thu, Jan 31, 2019 at 12:21 PM Takashi Iwai wrote: On Thu, 31 Jan 2019 12:05:30 +0100, Thierry Reding wrote: On Wed, Jan 30, 2

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-31 Thread Rafael J. Wysocki
On Thu, Jan 31, 2019 at 12:59 PM Takashi Iwai wrote: > > On Thu, 31 Jan 2019 12:46:54 +0100, > Rafael J. Wysocki wrote: > > > > On Thu, Jan 31, 2019 at 12:21 PM Takashi Iwai wrote: > > > > > > On Thu, 31 Jan 2019 12:05:30 +0100, > > > Thierry Reding wrote: > > > > > > > > On Wed, Jan 30, 2019 at

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-31 Thread Takashi Iwai
On Thu, 31 Jan 2019 12:46:54 +0100, Rafael J. Wysocki wrote: > > On Thu, Jan 31, 2019 at 12:21 PM Takashi Iwai wrote: > > > > On Thu, 31 Jan 2019 12:05:30 +0100, > > Thierry Reding wrote: > > > > > > On Wed, Jan 30, 2019 at 05:40:42PM +0100, Takashi Iwai wrote: > > [cut] > > > > > If I understa

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-31 Thread Rafael J. Wysocki
On Thu, Jan 31, 2019 at 12:46 PM Rafael J. Wysocki wrote: > > On Thu, Jan 31, 2019 at 12:21 PM Takashi Iwai wrote: > > > > On Thu, 31 Jan 2019 12:05:30 +0100, > > Thierry Reding wrote: > > > > > > On Wed, Jan 30, 2019 at 05:40:42PM +0100, Takashi Iwai wrote: > > [cut] > > > > > If I understand co

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-31 Thread Rafael J. Wysocki
On Thu, Jan 31, 2019 at 12:21 PM Takashi Iwai wrote: > > On Thu, 31 Jan 2019 12:05:30 +0100, > Thierry Reding wrote: > > > > On Wed, Jan 30, 2019 at 05:40:42PM +0100, Takashi Iwai wrote: [cut] > > > If I understand correctly the code, the pm domain is already activated > > > at calling driver's

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-31 Thread Takashi Iwai
On Thu, 31 Jan 2019 12:05:30 +0100, Thierry Reding wrote: > > On Wed, Jan 30, 2019 at 05:40:42PM +0100, Takashi Iwai wrote: > > On Wed, 30 Jan 2019 13:45:49 +0100, > > Jon Hunter wrote: > > > > > > > > > On 25/01/2019 11:06, Sameer Pujar wrote: > > > > If CONFIG_PM is disabled or runtime PM call

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-31 Thread Thierry Reding
On Wed, Jan 30, 2019 at 05:40:42PM +0100, Takashi Iwai wrote: > On Wed, 30 Jan 2019 13:45:49 +0100, > Jon Hunter wrote: > > > > > > On 25/01/2019 11:06, Sameer Pujar wrote: > > > If CONFIG_PM is disabled or runtime PM calls are forbidden, the clocks > > > will not be ON. This could cause issue du

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-31 Thread Sameer Pujar
On 1/30/2019 10:10 PM, Takashi Iwai wrote: On Wed, 30 Jan 2019 13:45:49 +0100, Jon Hunter wrote: On 25/01/2019 11:06, Sameer Pujar wrote: If CONFIG_PM is disabled or runtime PM calls are forbidden, the clocks will not be ON. This could cause issue during probe, where hda init setup is done.

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-30 Thread Takashi Iwai
On Wed, 30 Jan 2019 13:45:49 +0100, Jon Hunter wrote: > > > On 25/01/2019 11:06, Sameer Pujar wrote: > > If CONFIG_PM is disabled or runtime PM calls are forbidden, the clocks > > will not be ON. This could cause issue during probe, where hda init > > setup is done. This patch enables clocks unco

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-30 Thread Jon Hunter
On 25/01/2019 11:06, Sameer Pujar wrote: > If CONFIG_PM is disabled or runtime PM calls are forbidden, the clocks > will not be ON. This could cause issue during probe, where hda init > setup is done. This patch enables clocks unconditionally during probe. > > Along with above, follwoing changes

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-25 Thread Jon Hunter
On 25/01/2019 12:19, Sameer Pujar wrote: > > On 1/25/2019 5:12 PM, Jon Hunter wrote: >> On 25/01/2019 11:06, Sameer Pujar wrote: >>> If CONFIG_PM is disabled or runtime PM calls are forbidden, the clocks >>> will not be ON. This could cause issue during probe, where hda init >>> setup is done. T

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-25 Thread Sameer Pujar
On 1/25/2019 5:12 PM, Jon Hunter wrote: On 25/01/2019 11:06, Sameer Pujar wrote: If CONFIG_PM is disabled or runtime PM calls are forbidden, the clocks will not be ON. This could cause issue during probe, where hda init setup is done. This patch enables clocks unconditionally during probe. Al

Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-25 Thread Jon Hunter
On 25/01/2019 11:06, Sameer Pujar wrote: > If CONFIG_PM is disabled or runtime PM calls are forbidden, the clocks > will not be ON. This could cause issue during probe, where hda init > setup is done. This patch enables clocks unconditionally during probe. > > Along with above, follwoing changes

[PATCH v2] ALSA: hda/tegra: enable clock during probe

2019-01-25 Thread Sameer Pujar
If CONFIG_PM is disabled or runtime PM calls are forbidden, the clocks will not be ON. This could cause issue during probe, where hda init setup is done. This patch enables clocks unconditionally during probe. Along with above, follwoing changes are done. * enable runtime PM before exiting from