Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-13 Thread Karol Herbst
On Tue, Apr 13, 2021 at 1:17 PM Roy Spliet wrote: > > Op 13-04-2021 om 10:48 schreef Karol Herbst: > > On Tue, Apr 13, 2021 at 10:24 AM Roy Spliet wrote: > >> > >> Op 13-04-2021 om 01:10 schreef Karol Herbst: > >>> On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet wrote: > > Hello Aaron, >

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-13 Thread Roy Spliet
Op 13-04-2021 om 10:48 schreef Karol Herbst: On Tue, Apr 13, 2021 at 10:24 AM Roy Spliet wrote: Op 13-04-2021 om 01:10 schreef Karol Herbst: On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet wrote: Hello Aaron, Thanks for your insights. A follow-up query and some observations in-line. Op

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-13 Thread Karol Herbst
On Tue, Apr 13, 2021 at 10:24 AM Roy Spliet wrote: > > Op 13-04-2021 om 01:10 schreef Karol Herbst: > > On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet wrote: > >> > >> Hello Aaron, > >> > >> Thanks for your insights. A follow-up query and some observations in-line. > >> > >> Op 12-04-2021 om 20:06

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-13 Thread Roy Spliet
Op 13-04-2021 om 01:10 schreef Karol Herbst: On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet wrote: Hello Aaron, Thanks for your insights. A follow-up query and some observations in-line. Op 12-04-2021 om 20:06 schreef Aaron Plattner: On 4/10/21 1:48 PM, Roy Spliet wrote: Op 10-04-2021 om

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-12 Thread Karol Herbst
On Mon, Apr 12, 2021 at 9:36 PM Roy Spliet wrote: > > Hello Aaron, > > Thanks for your insights. A follow-up query and some observations in-line. > > Op 12-04-2021 om 20:06 schreef Aaron Plattner: > > On 4/10/21 1:48 PM, Roy Spliet wrote: > >> Op 10-04-2021 om 20:23 schreef Lukas Wunner: > >>> On

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-12 Thread Ilia Mirkin
On Mon, Apr 12, 2021 at 4:01 PM Aaron Plattner wrote: > > On 4/12/21 12:36 PM, Roy Spliet wrote: > > Hello Aaron, > > > > Thanks for your insights. A follow-up query and some observations > > in-line. > > > > Op 12-04-2021 om 20:06 schreef Aaron Plattner: > >> On 4/10/21 1:48 PM, Roy Spliet

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-12 Thread Aaron Plattner
On 4/12/21 12:36 PM, Roy Spliet wrote: Hello Aaron, Thanks for your insights. A follow-up query and some observations in-line. Op 12-04-2021 om 20:06 schreef Aaron Plattner: On 4/10/21 1:48 PM, Roy Spliet wrote: Op 10-04-2021 om 20:23 schreef Lukas Wunner: On Sat, Apr 10, 2021 at

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-12 Thread Roy Spliet
Hello Aaron, Thanks for your insights. A follow-up query and some observations in-line. Op 12-04-2021 om 20:06 schreef Aaron Plattner: On 4/10/21 1:48 PM, Roy Spliet wrote: Op 10-04-2021 om 20:23 schreef Lukas Wunner: On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote: Can I ask

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-12 Thread Aaron Plattner
On 4/10/21 1:48 PM, Roy Spliet wrote: Op 10-04-2021 om 20:23 schreef Lukas Wunner: On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote: Can I ask someone with more technical knowledge of snd_hda_intel and vgaswitcheroo to brainstorm about the possible challenges of nouveau taking

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-10 Thread Roy Spliet
Op 10-04-2021 om 20:23 schreef Lukas Wunner: On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote: Can I ask someone with more technical knowledge of snd_hda_intel and vgaswitcheroo to brainstorm about the possible challenges of nouveau taking matters into its own hand rather than keeping

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-10 Thread Lukas Wunner
On Sat, Apr 10, 2021 at 04:51:27PM +0100, Roy Spliet wrote: > Can I ask someone with more > technical knowledge of snd_hda_intel and vgaswitcheroo to brainstorm about > the possible challenges of nouveau taking matters into its own hand rather > than keeping this PCI quirk around? It sounds to me

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-04-10 Thread Roy Spliet
Reviving this thread as we have another user (rightfully) complaining on IRC about this. The way I see it there's two issues: 1) snd_hda_intel not allowing runpm (or w/e vgaswitcheroo needs) when there's missing codecs, inhibiting the entire GPU from performing runpm. This needlessly wastes

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2021-01-04 Thread Karol Herbst
On Tue, Dec 22, 2020 at 3:50 AM Kai-Heng Feng wrote: > > On Tue, Dec 22, 2020 at 1:56 AM Ilia Mirkin wrote: > > > > On Mon, Dec 21, 2020 at 11:33 AM Kai-Heng Feng > > wrote: > > > > > > [+Cc nouveau] > > > > > > On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai wrote: > > > [snip] > > > > > Quite

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-21 Thread Kai-Heng Feng
On Tue, Dec 22, 2020 at 1:56 AM Ilia Mirkin wrote: > > On Mon, Dec 21, 2020 at 11:33 AM Kai-Heng Feng > wrote: > > > > [+Cc nouveau] > > > > On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai wrote: > > [snip] > > > > Quite possibly the system doesn't power up HDA controller when there's > > > > no

Re: [Nouveau] [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-21 Thread Ilia Mirkin
On Mon, Dec 21, 2020 at 11:33 AM Kai-Heng Feng wrote: > > [+Cc nouveau] > > On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai wrote: > [snip] > > > Quite possibly the system doesn't power up HDA controller when there's > > > no external monitor. > > > So when it's connected to external monitor, it's

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-21 Thread Kai-Heng Feng
On Tue, Dec 22, 2020 at 12:47 AM Takashi Iwai wrote: [snip] > But what happens if you plug the HDMI cable later and want to use the > HDMI audio? It won't work with your fix, right? No it won't. It's possible to fix from nouveau, but it's at the mercy of Nvidia to fix their proprietary driver,

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-21 Thread Takashi Iwai
On Mon, 21 Dec 2020 17:33:20 +0100, Kai-Heng Feng wrote: > > [+Cc nouveau] > > On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai wrote: > [snip] > > > Quite possibly the system doesn't power up HDA controller when there's > > > no external monitor. > > > So when it's connected to external monitor,

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-21 Thread Kai-Heng Feng
[+Cc nouveau] On Fri, Dec 18, 2020 at 4:06 PM Takashi Iwai wrote: [snip] > > Quite possibly the system doesn't power up HDA controller when there's > > no external monitor. > > So when it's connected to external monitor, it's still needed for HDMI > > audio. > > Let me ask the user to confirm

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-18 Thread Takashi Iwai
On Fri, 18 Dec 2020 06:09:38 +0100, Kai-Heng Feng wrote: > > [+Cc Bjorn, Alan and linux-pci] > > On Thu, Dec 17, 2020 at 12:57 AM Takashi Iwai wrote: > > > > On Wed, 16 Dec 2020 17:22:17 +0100, > > Takashi Iwai wrote: > > > > > > On Wed, 16 Dec 2020 17:07:45 +0100, > > > Kai-Heng Feng wrote: >

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-17 Thread Kai-Heng Feng
[+Cc Bjorn, Alan and linux-pci] On Thu, Dec 17, 2020 at 12:57 AM Takashi Iwai wrote: > > On Wed, 16 Dec 2020 17:22:17 +0100, > Takashi Iwai wrote: > > > > On Wed, 16 Dec 2020 17:07:45 +0100, > > Kai-Heng Feng wrote: > > > > > > On Wed, Dec 16, 2020 at 11:58 PM Takashi Iwai wrote: > > > > > > >

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-16 Thread Takashi Iwai
On Wed, 16 Dec 2020 17:22:17 +0100, Takashi Iwai wrote: > > On Wed, 16 Dec 2020 17:07:45 +0100, > Kai-Heng Feng wrote: > > > > On Wed, Dec 16, 2020 at 11:58 PM Takashi Iwai wrote: > > > > > > On Wed, 16 Dec 2020 16:50:20 +0100, > > > Kai-Heng Feng wrote: > > > > > > > > On Wed, Dec 16, 2020 at

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-16 Thread Takashi Iwai
On Wed, 16 Dec 2020 17:07:45 +0100, Kai-Heng Feng wrote: > > On Wed, Dec 16, 2020 at 11:58 PM Takashi Iwai wrote: > > > > On Wed, 16 Dec 2020 16:50:20 +0100, > > Kai-Heng Feng wrote: > > > > > > On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai wrote: > > > > > > > > On Wed, 16 Dec 2020 13:47:24

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-16 Thread Kai-Heng Feng
On Wed, Dec 16, 2020 at 11:58 PM Takashi Iwai wrote: > > On Wed, 16 Dec 2020 16:50:20 +0100, > Kai-Heng Feng wrote: > > > > On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai wrote: > > > > > > On Wed, 16 Dec 2020 13:47:24 +0100, > > > Kai-Heng Feng wrote: > > > > > > > > Similar to commit

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-16 Thread Takashi Iwai
On Wed, 16 Dec 2020 16:50:20 +0100, Kai-Heng Feng wrote: > > On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai wrote: > > > > On Wed, 16 Dec 2020 13:47:24 +0100, > > Kai-Heng Feng wrote: > > > > > > Similar to commit 9479e75fca37 ("ALSA: hda: Keep the controller > > > initialization even if no

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-16 Thread Kai-Heng Feng
On Wed, Dec 16, 2020 at 11:41 PM Takashi Iwai wrote: > > On Wed, 16 Dec 2020 13:47:24 +0100, > Kai-Heng Feng wrote: > > > > Similar to commit 9479e75fca37 ("ALSA: hda: Keep the controller > > initialization even if no codecs found"), when codec probe fails, it > > doesn't enable runtime suspend,

Re: [PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-16 Thread Takashi Iwai
On Wed, 16 Dec 2020 13:47:24 +0100, Kai-Heng Feng wrote: > > Similar to commit 9479e75fca37 ("ALSA: hda: Keep the controller > initialization even if no codecs found"), when codec probe fails, it > doesn't enable runtime suspend, and can prevent graphics card from > getting powered down: > [

[PATCH v2] ALSA: hda: Continue to probe when codec probe fails

2020-12-16 Thread Kai-Heng Feng
Similar to commit 9479e75fca37 ("ALSA: hda: Keep the controller initialization even if no codecs found"), when codec probe fails, it doesn't enable runtime suspend, and can prevent graphics card from getting powered down: [4.280991] snd_hda_intel :01:00.1: no codecs initialized $ cat