Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread Karl Palsson
However, and possibly out of line, but should we consider submitting a patch to remove the pullups by default for exynos that Doug hinted at? Cheers, Karl P On Wed, Oct 29, 2014 at 03:34:27PM +0100, NEO-Technologies / Julien CHAUVEAU wrote: > Hi everyone, > > Okay, I understand your

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread NEO-Technologies / Julien CHAUVEAU
Hi everyone, Okay, I understand your opinion. So let's drop my patch in this case. Thank you for your comments. Julien Le 29/10/2014 15:02, Max Schwarz a écrit : Hi, I'll agree with Karl and Doug. If you (as a board vendor/maintainer/etc) want to use I2C, it's *your* responsibility to

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread Max Schwarz
Hi, I'll agree with Karl and Doug. If you (as a board vendor/maintainer/etc) want to use I2C, it's *your* responsibility to provide the pullup resistors by either including pullup resistors on the board or by enabling the internal ones. Either way, you should think a moment about the

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread Karl Palsson
I'd be more inclined to have pulls disabled by default, it's more standard with what smaller micros do, but I've no experience with these bigger cortex-a parts. It's also the "least surprise" path. If you want to try and use the onboard pullups, you can specify that in your board file, but

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread Heiko Stübner
Hi Addy, Max, Wolfram, after Doug's explanation of disfavour [0] and Julien's subsequent response I'm not sure which direction to go. So if possible I'd like to collect some more opinions of people knowing a lot more about i2c internals than myself :-) . Thanks Heiko [0]

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread NEO-Technologies / Julien CHAUVEAU
Hi Doug, Le 29/10/2014 05:45, Doug Anderson a écrit : Julien, On Tue, Oct 28, 2014 at 3:36 AM, Julien CHAUVEAU wrote: According to the I2C bus specification, it is required to use pull-up resistors on the clock and data lines. Probing the I2C busses with i2cdetect results in bad results when

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread NEO-Technologies / Julien CHAUVEAU
Hi Doug, Le 29/10/2014 05:45, Doug Anderson a écrit : Julien, On Tue, Oct 28, 2014 at 3:36 AM, Julien CHAUVEAU julien.chauv...@neo-technologies.fr wrote: According to the I2C bus specification, it is required to use pull-up resistors on the clock and data lines. Probing the I2C busses with

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread Heiko Stübner
Hi Addy, Max, Wolfram, after Doug's explanation of disfavour [0] and Julien's subsequent response I'm not sure which direction to go. So if possible I'd like to collect some more opinions of people knowing a lot more about i2c internals than myself :-) . Thanks Heiko [0]

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread Karl Palsson
I'd be more inclined to have pulls disabled by default, it's more standard with what smaller micros do, but I've no experience with these bigger cortex-a parts. It's also the least surprise path. If you want to try and use the onboard pullups, you can specify that in your board file, but for

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread Max Schwarz
Hi, I'll agree with Karl and Doug. If you (as a board vendor/maintainer/etc) want to use I2C, it's *your* responsibility to provide the pullup resistors by either including pullup resistors on the board or by enabling the internal ones. Either way, you should think a moment about the

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread NEO-Technologies / Julien CHAUVEAU
Hi everyone, Okay, I understand your opinion. So let's drop my patch in this case. Thank you for your comments. Julien Le 29/10/2014 15:02, Max Schwarz a écrit : Hi, I'll agree with Karl and Doug. If you (as a board vendor/maintainer/etc) want to use I2C, it's *your* responsibility to

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-29 Thread Karl Palsson
However, and possibly out of line, but should we consider submitting a patch to remove the pullups by default for exynos that Doug hinted at? Cheers, Karl P On Wed, Oct 29, 2014 at 03:34:27PM +0100, NEO-Technologies / Julien CHAUVEAU wrote: Hi everyone, Okay, I understand your opinion.

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-28 Thread Doug Anderson
Julien, On Tue, Oct 28, 2014 at 3:36 AM, Julien CHAUVEAU wrote: > According to the I2C bus specification, it is required to use pull-up > resistors > on the clock and data lines. Probing the I2C busses with i2cdetect results in > bad results when no devices are connected and no external

[PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-28 Thread Julien CHAUVEAU
According to the I2C bus specification, it is required to use pull-up resistors on the clock and data lines. Probing the I2C busses with i2cdetect results in bad results when no devices are connected and no external resistors are used. This patch configures the I2C busses to use the internal

[PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-28 Thread Julien CHAUVEAU
According to the I2C bus specification, it is required to use pull-up resistors on the clock and data lines. Probing the I2C busses with i2cdetect results in bad results when no devices are connected and no external resistors are used. This patch configures the I2C busses to use the internal

Re: [PATCH v2] ARM: dts: rockchip: use internal pull-up resistors on I2C busses

2014-10-28 Thread Doug Anderson
Julien, On Tue, Oct 28, 2014 at 3:36 AM, Julien CHAUVEAU julien.chauv...@neo-technologies.fr wrote: According to the I2C bus specification, it is required to use pull-up resistors on the clock and data lines. Probing the I2C busses with i2cdetect results in bad results when no devices are