Re: [PATCH v2] ARM: kprobes: rewrite test-[arm|thumb].c in UAL

2021-03-29 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 1:40 AM Ard Biesheuvel wrote: > > On Fri, 29 Jan 2021 at 01:22, Nick Desaulniers > wrote: > > > > > On Thu, 28 Jan 2021 at 20:34, Nick Desaulniers > > > wrote: > > > > + TEST_RX("tbh[pc, r",7, (9f-(1f+4))>>1,", lsl #1]", > > > > > > > On Thu, Jan 28, 2021 at 1

Re: [PATCH v2] ARM: kprobes: rewrite test-[arm|thumb].c in UAL

2021-02-13 Thread Ard Biesheuvel
On Fri, 29 Jan 2021 at 00:30, Ard Biesheuvel wrote: > > On Thu, 28 Jan 2021 at 23:28, Arnd Bergmann wrote: > > > > On Thu, Jan 28, 2021 at 10:03 PM Ard Biesheuvel wrote: > > > On Thu, 28 Jan 2021 at 20:34, Nick Desaulniers > > > wrote: > > > > @@ -468,15 +468,15 @@ void kprobe_thumb32_test_cas

Re: [PATCH v2] ARM: kprobes: rewrite test-[arm|thumb].c in UAL

2021-01-28 Thread Nick Desaulniers
> On Thu, 28 Jan 2021 at 20:34, Nick Desaulniers > wrote: > > + TEST_RX("tbh[pc, r",7, (9f-(1f+4))>>1,", lsl #1]", > > > On Thu, Jan 28, 2021 at 1:03 PM Ard Biesheuvel wrote: > Why is this change needed? Are the resulting opcodes equivalent? Does > GAS infer the lsl #1 but Clang doesn'

Re: [PATCH v2] ARM: kprobes: rewrite test-[arm|thumb].c in UAL

2021-01-28 Thread Ard Biesheuvel
On Thu, 28 Jan 2021 at 23:28, Arnd Bergmann wrote: > > On Thu, Jan 28, 2021 at 10:03 PM Ard Biesheuvel wrote: > > On Thu, 28 Jan 2021 at 20:34, Nick Desaulniers > > wrote: > > > @@ -468,15 +468,15 @@ void kprobe_thumb32_test_cases(void) > > > > > > TEST_UNSUPPORTED("strexbr0, r1

Re: [PATCH v2] ARM: kprobes: rewrite test-[arm|thumb].c in UAL

2021-01-28 Thread Arnd Bergmann
On Thu, Jan 28, 2021 at 10:03 PM Ard Biesheuvel wrote: > On Thu, 28 Jan 2021 at 20:34, Nick Desaulniers > wrote: > > @@ -468,15 +468,15 @@ void kprobe_thumb32_test_cases(void) > > > > TEST_UNSUPPORTED("strexbr0, r1, [r2]") > > TEST_UNSUPPORTED("strexhr0, r1, [r2]"

Re: [PATCH v2] ARM: kprobes: rewrite test-[arm|thumb].c in UAL

2021-01-28 Thread Ard Biesheuvel
On Thu, 28 Jan 2021 at 20:34, Nick Desaulniers wrote: > > Clang's integrated assembler only accepts UAL syntax, rewrite the > instructions that were changed by RVCTv2.1. > > The document "Assembly language changes after RVCTv2.1" was very > helpful. > > This exposed a bug in Clang's integrated ass